[HDFS-5100] TestNamenodeRetryCache fails on Windows due to incorrect cleanup

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1.1-beta, 3.0.0-alpha1
• Fix Version/s: 2.1.1-beta
• Component/s: test
• Target Version/s: 2.1.1-beta
• Hadoop Flags: Reviewed
• Assignee: Chuan Liu
• Reporter: Chuan Liu
• Created: 15/Aug/13 08:16
• Updated: 12/May/16 21:14
• Resolved: 16/Aug/13 08:33

Description

The test case fails on Windows with the following exceptions.

java.io.IOException: Could not fully delete C:\hdc\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\name1
	at org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:759)
	at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:644)
	at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:334)
	at org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:316)
	at org.apache.hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits.setupCluster(TestInitializeSharedEdits.java:68)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

The root cause is that the cleanup() only try to delete root directory instead of shutting down the MiniDFSCluster. Every test case in this unit test will create a new MiniDFSCluster during setup() step. Without shutting down the previous cluster, the new cluster creation will fail with the above exception due to blocking file handling on Windows.

Issue Links

• is part of: HDFS-3602 Enhancements to HDFS for Windows Server and Windows Azure development and runtime environments