Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-510

Rename DatanodeBlockInfo to be ReplicaInfo

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Rename DatanodeBlockInfo to be ReplicaInfo to improve readablility.

      1. HDFS-510.patch
        21 kB
        Jakob Homan
      2. replicaInfo.patch
        14 kB
        Hairong Kuang

        Issue Links

          Activity

          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          > Not sure how to do it yet. Will try later.
          I should mention that Arun and I have spent sometime this afternoon but we are still not sure how to resurrect the change history. Please help if you know how to do so.

          Show
          Tsz Wo Nicholas Sze added a comment - > Not sure how to do it yet. Will try later. I should mention that Arun and I have spent sometime this afternoon but we are still not sure how to resurrect the change history. Please help if you know how to do so.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          > ... So Nicholas if know how to do this, please reopen the issue and correct it. I give up.
          Not sure how to do it yet. Will try later.

          Show
          Tsz Wo Nicholas Sze added a comment - > ... So Nicholas if know how to do this, please reopen the issue and correct it. I give up. Not sure how to do it yet. Will try later.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #34 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/34/)
          . Rename DatanodeBlockInfo to be ReplicaInfo. Contributed by Jakob Homan & Hairong Kuang.
          . Reverting incorrect commit.
          . Correction: Contributed by Jakob Homan and Hairong Kuang.
          . Rename DatanodeBlockInfo to be ReplicaInfo. Contributed by Hairong Kuang.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #34 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/34/ ) . Rename DatanodeBlockInfo to be ReplicaInfo. Contributed by Jakob Homan & Hairong Kuang. . Reverting incorrect commit. . Correction: Contributed by Jakob Homan and Hairong Kuang. . Rename DatanodeBlockInfo to be ReplicaInfo. Contributed by Hairong Kuang.
          Hide
          Konstantin Shvachko added a comment -

          Sorry for multiple commits. I was trying preserve the history of DatanodeBlockInfo.java in ReplicaInfo.java. Did svn move, but history seems to disappear anyway. So Nicholas if know how to do this, please reopen the issue and correct it. I give up.

          Show
          Konstantin Shvachko added a comment - Sorry for multiple commits. I was trying preserve the history of DatanodeBlockInfo.java in ReplicaInfo.java. Did svn move, but history seems to disappear anyway. So Nicholas if know how to do this, please reopen the issue and correct it. I give up.
          Hairong Kuang made changes -
          Attachment replicaInfo.patch [ 12414973 ]
          Hide
          Hairong Kuang added a comment -

          This patch does a rename.

          Show
          Hairong Kuang added a comment - This patch does a rename.
          Hairong Kuang made changes -
          Link This issue blocks HDFS-509 [ HDFS-509 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I think we need a "svn move" for committing this. Otherwise, we will lose the change history.

          Show
          Tsz Wo Nicholas Sze added a comment - I think we need a "svn move" for committing this. Otherwise, we will lose the change history.
          Konstantin Shvachko made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Hide
          Konstantin Shvachko added a comment -

          I just committed this. Thank you Jakob and Hairong.

          Show
          Konstantin Shvachko added a comment - I just committed this. Thank you Jakob and Hairong.
          Hide
          Jakob Homan added a comment -

          Unit tests all pass.

               [exec] +1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
               [exec] 
               [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
          
          Show
          Jakob Homan added a comment - Unit tests all pass. [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          Hairong Kuang made changes -
          Assignee Hairong Kuang [ hairong ] Jakob Homan [ jghoman ]
          Hide
          Hairong Kuang added a comment -

          +1

          Show
          Hairong Kuang added a comment - +1
          Hide
          Hairong Kuang added a comment -

          Oops! My attachment duplicated Jacob's. Removing them for easy management.

          Show
          Hairong Kuang added a comment - Oops! My attachment duplicated Jacob's. Removing them for easy management.
          Hairong Kuang made changes -
          Attachment replicaInfo.patch [ 12414778 ]
          Hairong Kuang made changes -
          Attachment HDFS-510.patch [ 12414797 ]
          Hairong Kuang made changes -
          Attachment HDFS-510.patch [ 12414797 ]
          Hide
          Hairong Kuang added a comment -

          My previous patch seems to have a problem. Thanks Jacob for generating a new patch for me.

          Show
          Hairong Kuang added a comment - My previous patch seems to have a problem. Thanks Jacob for generating a new patch for me.
          Jakob Homan made changes -
          Attachment HDFS-510.patch [ 12414796 ]
          Hide
          Jakob Homan added a comment -

          I had trouble applying the patch as uploaded. Looks like there may be a Subversion issue. Since it's a simple refactor, I regenerated the patch. Is attached.

          Show
          Jakob Homan added a comment - I had trouble applying the patch as uploaded. Looks like there may be a Subversion issue. Since it's a simple refactor, I regenerated the patch. Is attached.
          Hairong Kuang made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hairong Kuang made changes -
          Field Original Value New Value
          Attachment replicaInfo.patch [ 12414778 ]
          Hide
          Hairong Kuang added a comment -

          Here is the patch that does the rename.

          Show
          Hairong Kuang added a comment - Here is the patch that does the rename.
          Hairong Kuang created issue -

            People

            • Assignee:
              Jakob Homan
              Reporter:
              Hairong Kuang
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development