[HDFS-49] MiniDFSCluster.stopDataNode will always shut down a node in the cluster if a matching name is not found

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.20.204.0, 0.20.205.0, 1.1.0
• Fix Version/s: 2.7.0
• Component/s: test
• Labels: codereview newbie
• Target Version/s: 2.6.0
• Assignee: Steve Loughran
• Reporter: Steve Loughran
• Created: 04/Aug/08 15:31
• Updated: 24/Apr/15 23:22
• Resolved: 27/Jan/15 11:11

Description

The stopDataNode method will shut down the last node in the list of nodes, if one matching a specific name is not found

This is possibly not what was intended. Better to return false or fail in some other manner if the named node was not located

synchronized boolean stopDataNode(String name) {
int i;
for (i = 0; i < dataNodes.size(); i++) {
DataNode dn = dataNodes.get.datanode;
if (dn.dnRegistration.getName().equals(name))

{ break; }

}
return stopDataNode;
}

Issue Links

• is related to: HADOOP-4278 TestDatanodeDeath failed occasionally