Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-4880

Diagnostic logging while loading name/edits files

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0, 3.0.0
    • Fix Version/s: 2.1.0-beta, 1.2.1
    • Component/s: namenode
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Add some minimal diagnostic logging to help determine location of the files being loaded.

      1. HDFS-4880.branch-1.patch
        1 kB
        Arpit Agarwal
      2. HDFS-4880.branch-1.patch
        2 kB
        Arpit Agarwal
      3. HDFS-4880.trunk.patch
        2 kB
        Arpit Agarwal

        Activity

        Hide
        Suresh Srinivas added a comment -

        I merged this to branch-1.2 for release 1.2.1

        Show
        Suresh Srinivas added a comment - I merged this to branch-1.2 for release 1.2.1
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3880 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3880/)
        HDFS-4880. Print the image and edits file loaded by the namenode in the logs. Contributed by Arpit Agarwal. (Revision 1490746)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1490746
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormat.java
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #3880 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3880/ ) HDFS-4880 . Print the image and edits file loaded by the namenode in the logs. Contributed by Arpit Agarwal. (Revision 1490746) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1490746 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormat.java
        Hide
        Suresh Srinivas added a comment -

        I have committed the patch to trunk, branch-2, branch-2.1 and branch-1.

        Thank you Arpit!

        Show
        Suresh Srinivas added a comment - I have committed the patch to trunk, branch-2, branch-2.1 and branch-1. Thank you Arpit!
        Hide
        Suresh Srinivas added a comment -

        +1 for the branch-1 patch as well.

        Show
        Suresh Srinivas added a comment - +1 for the branch-1 patch as well.
        Hide
        Suresh Srinivas added a comment -

        +1 for the trunk patch. This is a very useful information to check where Namenode loaded image and edits from.

        Show
        Suresh Srinivas added a comment - +1 for the trunk patch. This is a very useful information to check where Namenode loaded image and edits from.
        Hide
        Arpit Agarwal added a comment -

        No new tests should be necessary since this change just adds some logging.

        Show
        Arpit Agarwal added a comment - No new tests should be necessary since this change just adds some logging.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12586611/HDFS-4880.trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4493//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4493//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12586611/HDFS-4880.trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4493//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4493//console This message is automatically generated.
        Hide
        Arpit Agarwal added a comment -

        Updated patch for branch-1 and patch for trunk.

        Show
        Arpit Agarwal added a comment - Updated patch for branch-1 and patch for trunk.
        Hide
        Suresh Srinivas added a comment -

        On trunk, doing similar change to the following line of code, would make it consistent with branch-1.

              LOG.info("Image file of size " + curFile.length() + " loaded in " 
                  + (now() - startTime)/1000 + " seconds.");
        
        Show
        Suresh Srinivas added a comment - On trunk, doing similar change to the following line of code, would make it consistent with branch-1. LOG.info("Image file of size " + curFile.length() + " loaded in " + (now() - startTime)/1000 + " seconds.");
        Hide
        Suresh Srinivas added a comment -

        Also if this is only applicable to branch-1, then please change Affects Version/s field accordingly.

        Show
        Suresh Srinivas added a comment - Also if this is only applicable to branch-1, then please change Affects Version/s field accordingly.
        Hide
        Suresh Srinivas added a comment -

        BTW do we print the complete path to the editlog file that is loaded by namenode?

        Show
        Suresh Srinivas added a comment - BTW do we print the complete path to the editlog file that is loaded by namenode?
        Hide
        Suresh Srinivas added a comment -

        +1 for the patch.

        Show
        Suresh Srinivas added a comment - +1 for the patch.
        Hide
        Arpit Agarwal added a comment -

        edits file location is already logged on branch-1, start logging image file location.

        Show
        Arpit Agarwal added a comment - edits file location is already logged on branch-1, start logging image file location.

          People

          • Assignee:
            Suresh Srinivas
            Reporter:
            Arpit Agarwal
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development