edits file location is already logged on branch-1, start logging image file location.

+1 for the patch.

BTW do we print the complete path to the editlog file that is loaded by namenode?

Also if this is only applicable to branch-1, then please change Affects Version/s field accordingly.

On trunk, doing similar change to the following line of code, would make it consistent with branch-1.

      LOG.info("Image file of size " + curFile.length() + " loaded in " 
          + (now() - startTime)/1000 + " seconds.");

Updated patch for branch-1 and patch for trunk.

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12586611/HDFS-4880.trunk.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4493//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4493//console

This message is automatically generated.

No new tests should be necessary since this change just adds some logging.

+1 for the trunk patch. This is a very useful information to check where Namenode loaded image and edits from.

+1 for the branch-1 patch as well.

I have committed the patch to trunk, branch-2, branch-2.1 and branch-1.

Thank you Arpit!

Integrated in Hadoop-trunk-Commit #3880 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3880/)
HDFS-4880. Print the image and edits file loaded by the namenode in the logs. Contributed by Arpit Agarwal. (Revision 1490746)

Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1490746
Files :

• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormat.java

I merged this to branch-1.2 for release 1.2.1