[HDFS-4815] TestRBWBlockInvalidation#testBlockInvalidationWhenRBWReplicaMissedInDN: Double call countReplicas() to fetch corruptReplicas and liveReplicas is not needed

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.1.0-beta
• Component/s: datanode, test
• Labels: patch
• Target Version/s: 2.1.0-beta
• Hadoop Flags: Reviewed
• Assignee: Tian Hong Wang
• Reporter: Tian Hong Wang
• Created: 11/May/13 00:20
• Updated: 27/Aug/13 22:08
• Resolved: 04/Jun/13 23:15

Description

tesIn TestRBWBlockInvalidation, the original code is:
while (!isCorruptReported) {
if (countReplicas(namesystem, blk).corruptReplicas() > 0)

{ isCorruptReported = true; }

Thread.sleep(100);
}
assertEquals("There should be 1 replica in the corruptReplicasMap", 1,
countReplicas(namesystem, blk).corruptReplicas());

Once the program detects there exists one corruptReplica, it will break the while loop. After that, it call countReplicas() again in assertEquals(). But sometimes I met the following error:
java.lang.AssertionError: There should be 1 replica in the corruptReplicasMap expected:<1> but was:<0>

It's obviously that second function call countReplicas() in assertEquals(), the corruptReplicas value has been changed since program go to sleep and BlockManger recovered the corrupt block during this sleep time.

So what I do is:
1) once detecting there exists one corruptReplica, break the loop and don't call sleep(), the same as liveReplicas
2) don't double check the countReplicas & liveReplicas in assertEquals()
3) sometimes I meet the problem of testcase timeout, so I speed up the block report interval