Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-4776

Backport SecondaryNameNode web ui to branch-1

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The related JIRAs are

      • HADOOP-3741: SecondaryNameNode has http server on dfs.secondary.http.address but without any contents
      • HDFS-1728: SecondaryNameNode.checkpointSize is in byte but not MB.
      1. h4776_20130429.patch
        6 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop 1.2.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this.

          Thanks, Chris and Suresh for reviewing this.

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Chris and Suresh for reviewing this.
          Hide
          Suresh Srinivas added a comment -

          +1 from me as well for the patch. Can you please commit this in branch 1.2 as well?

          Show
          Suresh Srinivas added a comment - +1 from me as well for the patch. Can you please commit this in branch 1.2 as well?
          Hide
          Chris Nauroth added a comment -

          +1 for the patch. It looks like a clean backport.

          [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
          [exec] Please justify why no tests are needed for this patch.

          I tested the patch manually by building the distro and running 1 each of NN, DN, and 2NN. I accessed the 2NN's web UI and ran some file system operations. I saw the 2NN checkpoint successfully, and I verified that the web UI updated the displayed information about the last checkpoint.

          Thanks for doing the backport, Nicholas!

          Show
          Chris Nauroth added a comment - +1 for the patch. It looks like a clean backport. [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. I tested the patch manually by building the distro and running 1 each of NN, DN, and 2NN. I accessed the 2NN's web UI and ran some file system operations. I saw the 2NN checkpoint successfully, and I verified that the web UI updated the displayed information about the last checkpoint. Thanks for doing the backport, Nicholas!
          Hide
          Tsz Wo Nicholas Sze added a comment -
               [exec] -1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
               [exec]                         Please justify why no tests are needed for this patch.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     -1 findbugs.  The patch appears to introduce 19 new Findbugs (version 1.3.9) warnings.
          

          The findbugs warnings are not related to the patch.

          Show
          Tsz Wo Nicholas Sze added a comment - [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 19 new Findbugs (version 1.3.9) warnings. The findbugs warnings are not related to the patch.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          h4776_20130429.patch

          Show
          Tsz Wo Nicholas Sze added a comment - h4776_20130429.patch

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development