[HDFS-4751] TestLeaseRenewer#testThreadName flakes

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1.0-beta, 3.0.0-alpha1
• Fix Version/s: 2.1.0-beta
• Component/s: test
• Hadoop Flags: Reviewed
• Assignee: Andrew Wang
• Reporter: Andrew Wang
• Created: 25/Apr/13 01:15
• Updated: 12/May/16 18:11
• Resolved: 10/May/13 19:54

Description

Seen internally and during upstream trunk builds, error like the following:

Error Message:
 Unfinished stubbing detected here: -> at org.apache.hadoop.hdfs.TestLeaseRenewer.testThreadName(TestLeaseRenewer.java:197)  E.g. thenReturn() may be missing. Examples of correct stubbing:     when(mock.isOk()).thenReturn(true);     when(mock.isOk()).thenThrow(exception);     doThrow(exception).when(mock).someVoidMethod(); Hints:  1. missing thenReturn()  2. although stubbed methods may return mocks, you cannot inline mock creation (mock()) call inside a thenReturn method (see issue 53)

Stack Trace:
org.mockito.exceptions.misusing.UnfinishedStubbingException:
Unfinished stubbing detected here:
-> at org.apache.hadoop.hdfs.TestLeaseRenewer.testThreadName(TestLeaseRenewer.java:197)

I believe it's due to mocking while being concurrently accessed by another thread.