[HDFS-4675] Fix rename across snapshottable directories

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Snapshot (HDFS-2802)
• Component/s: namenode
• Hadoop Flags: Reviewed
• Assignee: Jing Zhao
• Reporter: Jing Zhao
• Created: 09/Apr/13 01:15
• Updated: 13/Apr/13 13:44
• Resolved: 13/Apr/13 03:15

Description

For rename across snapshottable directories, suppose there are two snapshottable directories: /user1 and /user2 and we have the following steps:

1. Take snapshot s1 on /user1 at time t1.
2. Take snapshot s2 on /user2 at time t2.
3. Take snapshot s3 on /user1 at time t3.
4. Rename /user2/foo/ (an INodeDirectoryWithSnapshot instance) to /user1/foo/.

After the rename we update the subtree of /user1/foo/ again (e.g., delete /user1/foo/bar), we need to decide where to record the diff. The problem is that the current implementation will identify s3 as the latest snapshot, thus recording the snapshot copy of bar to s3. However, the parent of bar, /user1/foo, is still in the created list of s3. Thus here we should record the snapshot copy of bar to s2.

If we further take snapshot s4 on /user1, and make some further change under /user1/foo, these changes will be recorded in s4. Then if we delete the snapshot s4, similar with above, we should merge the change to s2, not s3.

Thus in general, we may need to record the latest snapshots of both the src/dst subtree in the renamed inode and update the current INodeDirectory#getExistingINodeInPath accordingly.

Issue Links

• contains: HDFS-4673 Renaming file in subdirectory of a snapshotted directory does not work.