Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.0-beta
    • Component/s: datanode, hdfs-client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      • For the log statement in DataXceiver below,
        • it has two String.format(..);
        • it uses %s for string constants.
          BlockSender.ClientTraceLog.info(String.format(
                    String.format(
                      "src: %s, dest: %s, op: %s, blockid: %s, srvID: %s, " +
                        "success: %b",
                      "127.0.0.1",                   // src IP
                      "127.0.0.1",                   // dst IP
                      "REQUEST_SHORT_CIRCUIT_FDS",   // operation
                      blk.getBlockId(),             // block id
                      dnR.getStorageID(),
                      (fis != null)
                    )));
          
      • The new method getShortCircuitFdsForRead(..) added to FsDatasetSpi is unecssary.
      • FileInputStreamCache.Key.equals mistakenly uses & instead of &&.
      • In FileInputStreamCache.CacheCleaner, it uncessarily call map.entries().iterator()) for each loop.
      • The cache objects should not be passed in BlockReader.close(..)

        Attachments

        1. HDFS-4661.004.patch
          36 kB
          Colin P. McCabe
        2. HDFS-4661.003.patch
          35 kB
          Colin P. McCabe
        3. HDFS-4661.002.patch
          8 kB
          Colin P. McCabe
        4. HDFS-4661.001.patch
          5 kB
          Colin P. McCabe

          Activity

            People

            • Assignee:
              cmccabe Colin P. McCabe
              Reporter:
              cmccabe Colin P. McCabe
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: