[HDFS-4643] Fix flakiness in TestQuorumJournalManager

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.0.3-alpha, 3.0.0-alpha1
• Fix Version/s: 2.1.0-beta
• Component/s: qjm, test
• Target Version/s: 2.0.4-alpha
• Hadoop Flags: Reviewed
• Assignee: Todd Lipcon
• Reporter: Todd Lipcon
• Created: 27/Mar/13 17:50
• Updated: 12/May/16 18:15
• Resolved: 09/Apr/13 21:34

Description

TestQuorumJournalManager can occasionally fail if two consecutive test cases pick the same port number for the JournalNodes. In this case, sometimes an IPC client can be cached from a previous test case, and then fail when it tries to make an IPC over that cached connection to the now-broken connection. We need to more carefully call close() on all the QJMs to prevent this.