[HDFS-4636] Update quota usage when deleting files/dirs that were created after taking the latest snapshot

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Snapshot (HDFS-2802)
• Component/s: namenode
• Hadoop Flags: Reviewed
• Assignee: Jing Zhao
• Reporter: Jing Zhao
• Created: 25/Mar/13 23:56
• Updated: 29/Mar/13 13:14
• Resolved: 28/Mar/13 23:25

Description

This jira aims to fix two bugs in deleting files with snapshot:

1. We should update the quota usage when the file/dir to be deleted is not included in the latest snapshot (i.e., the to-be-deleted file/dir is recorded in the created list of the latest snapshot). In particular, in FSDirectory#removeLastINode, instead of checking if the latest snapshot is null to decide whether we should update the quota usage, we should use INode#isInLatestSnapshot(Snapshot) as the check condition.

2. Similarly, in FSDirectory#unprotectedDelete(...), we should update quota usage after calling INode#cleanSubtree, considering during cleanSubtree() we may delete files that were created after taking the latest snapshot.