Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0
    • Component/s: webhdfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HDFS-3598 adds cancat to WebHDFS. Let's also add it to branch-1.

      1. h4597_20130313.patch
        15 kB
        Tsz Wo Nicholas Sze
      2. h4597_20130313b.patch
        15 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Tsz Wo Nicholas Sze created issue -
          Tsz Wo Nicholas Sze made changes -
          Field Original Value New Value
          Link This issue relates to HDFS-4456 [ HDFS-4456 ]
          Tsz Wo Nicholas Sze made changes -
          Link This issue relates to HDFS-3598 [ HDFS-3598 ]
          Tsz Wo Nicholas Sze made changes -
          Link This issue relates to HDFS-4598 [ HDFS-4598 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          h4597_20130313.patch: backport cancat.

          Show
          Tsz Wo Nicholas Sze added a comment - h4597_20130313.patch: backport cancat.
          Tsz Wo Nicholas Sze made changes -
          Attachment h4597_20130313.patch [ 12573464 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -
               [exec] -1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     +1 tests included.  The patch appears to include 7 new or modified tests.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     -1 findbugs.  The patch appears to introduce 17 new Findbugs (version 1.3.9) warnings.
          
          Show
          Tsz Wo Nicholas Sze added a comment - [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 7 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 17 new Findbugs (version 1.3.9) warnings.
          Hide
          Suresh Srinivas added a comment -

          Comments:

          1. ConcatSourcesParam#DEFAULT is NULL in trunk and "" in this patch?
          2. Equivalent changes from FilterFileSystem.java is not implemented?
          3. The following changes is not in the backport?
            -              path.getAbsolutePath(), op, bufferSize);
            +              path.getAbsolutePath(), op, concatSrcs, bufferSize);
            
          4. webhdfs.xml change in this patch is not in trunk? (I could not find it on a quick look).
          Show
          Suresh Srinivas added a comment - Comments: ConcatSourcesParam#DEFAULT is NULL in trunk and "" in this patch? Equivalent changes from FilterFileSystem.java is not implemented? The following changes is not in the backport? - path.getAbsolutePath(), op, bufferSize); + path.getAbsolutePath(), op, concatSrcs, bufferSize); webhdfs.xml change in this patch is not in trunk? (I could not find it on a quick look).
          Hide
          Tsz Wo Nicholas Sze added a comment -

          1. According to the WebHDFS API doc, the default value should be an empty string. Filed HDFS-4598 for trunk.

          2. Oops, forgot to change FilterFileSystem.

          3. Trunk has two post(..) methods but branch-1 only has one so that the change is not required.

          4. The corresponding doc change in trunk is in HDFS-4456. This patch includes all three JIRAs, HDFS-3598, HDFS-4456 and HDFS-4598.

          Show
          Tsz Wo Nicholas Sze added a comment - 1. According to the WebHDFS API doc, the default value should be an empty string. Filed HDFS-4598 for trunk. 2. Oops, forgot to change FilterFileSystem. 3. Trunk has two post(..) methods but branch-1 only has one so that the change is not required. 4. The corresponding doc change in trunk is in HDFS-4456 . This patch includes all three JIRAs, HDFS-3598 , HDFS-4456 and HDFS-4598 .
          Hide
          Tsz Wo Nicholas Sze added a comment -

          h4597_20130313b.patch: adds the FilterFileSystem change.

          Show
          Tsz Wo Nicholas Sze added a comment - h4597_20130313b.patch: adds the FilterFileSystem change.
          Tsz Wo Nicholas Sze made changes -
          Attachment h4597_20130313b.patch [ 12573479 ]
          Hide
          Suresh Srinivas added a comment -

          +1 for the patch.

          Show
          Suresh Srinivas added a comment - +1 for the patch.
          Hide
          Tsz Wo Nicholas Sze added a comment -
               [exec] -1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     +1 tests included.  The patch appears to include 7 new or modified tests.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     -1 findbugs.  The patch appears to introduce 17 new Findbugs (version 1.3.9) warnings.
               [exec] 
          

          The findbugs warnings are not related to the patch.

          Show
          Tsz Wo Nicholas Sze added a comment - [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 7 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 17 new Findbugs (version 1.3.9) warnings. [exec] The findbugs warnings are not related to the patch.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          All HDFS and Common unit tests passed except TestBalancerWithNodeGroup. The failure was not related to the patch.

          Show
          Tsz Wo Nicholas Sze added a comment - All HDFS and Common unit tests passed except TestBalancerWithNodeGroup. The failure was not related to the patch.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this.

          Thanks Suresh for reviewing the patch.

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks Suresh for reviewing the patch.
          Tsz Wo Nicholas Sze made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 1.2.0 [ 12321657 ]
          Resolution Fixed [ 1 ]
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop 1.2.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.
          Matt Foley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development