Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Clean up some code style issues in HDFS-347.

      DomainSocket.java
      do not use AtomicInteger for status, add a new class
      rename fdRef(), fdUnref(boolean), jfds, jbuf, SND_BUF_SIZE, etc.
      do not override finalize().
      remove some dead code.

      1. HDFS-4476.002.patch
        25 kB
        Colin Patrick McCabe
      2. HDFS-4476.001.patch
        24 kB
        Colin Patrick McCabe

        Activity

        Colin Patrick McCabe created issue -
        Colin Patrick McCabe made changes -
        Field Original Value New Value
        Component/s datanode [ 12312927 ]
        Component/s hdfs-client [ 12312928 ]
        Component/s performance [ 12316501 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Thanks for creating this JIRA. Please rename other short variable/method/function in other classes in the branch as well if possible.

        Show
        Tsz Wo Nicholas Sze added a comment - Thanks for creating this JIRA. Please rename other short variable/method/function in other classes in the branch as well if possible.
        Colin Patrick McCabe made changes -
        Attachment HDFS-4476.001.patch [ 12568620 ]
        Colin Patrick McCabe made changes -
        Attachment HDFS-4476.002.patch [ 12568921 ]
        Hide
        Aaron T. Myers added a comment -

        +1, the latest patch looks good to me. I'm going to commit this momentarily.

        Show
        Aaron T. Myers added a comment - +1, the latest patch looks good to me. I'm going to commit this momentarily.
        Hide
        Aaron T. Myers added a comment -

        I've just committed this to the HDFS-347 branch. Thanks a lot for the contribution, Colin.

        Show
        Aaron T. Myers added a comment - I've just committed this to the HDFS-347 branch. Thanks a lot for the contribution, Colin.
        Aaron T. Myers made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        9d 45m 1 Aaron T. Myers 16/Feb/13 00:59

          People

          • Assignee:
            Colin Patrick McCabe
            Reporter:
            Colin Patrick McCabe
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development