[HDFS-4445] All BKJM ledgers are not checked while tailing, So failover will fail.

• Type: Sub-task
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.0.3-alpha
• Fix Version/s: 2.0.3-alpha
• Target Version/s: 2.0.3-alpha
• Hadoop Flags: Reviewed
• Assignee: Vinayakumar B
• Reporter: Vinayakumar B
• Created: 26/Jan/13 07:52
• Updated: 03/Sep/14 23:09
• Resolved: 03/Feb/13 18:11

Description

After the fix of HDFS-4130, all editlog nodes are not iterated if first edit are below fromTxId

Problem part is below code inside BookKeeperJournalManager#selectInputStreams(..)

        if (fromTxId >= l.getFirstTxId() && fromTxId <= lastTxId) {
          LedgerHandle h;
          if (l.isInProgress()) { // we don't want to fence the current journal
            h = bkc.openLedgerNoRecovery(l.getLedgerId(), digestType,
                digestpw.getBytes());
          } else {
            h = bkc
                .openLedger(l.getLedgerId(), digestType, digestpw.getBytes());
          }
          elis = new BookKeeperEditLogInputStream(h, l);
          elis.skipTo(fromTxId);
        } else {
          return;
        }

The else block should have continue statement instead of return.

Issue Links

• is broken by: HDFS-4130 BKJM: The reading for editlog at NN starting using bkjm is not efficient