Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-2802 Support for RW/RO snapshots in HDFS
  3. HDFS-4407

In INodeDirectoryWithSnapshot, change combinePostDiff to merge-sort like

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • Snapshot (HDFS-2802)
    • namenode
    • None
    • Reviewed

    Description

      Change combinePostDiff to merge-sort like so that it is more efficient. Also, it should not modify the postDiff parameter.

      Attachments

        1. h4407_20130115.patch
          3 kB
          Tsz-wo Sze

        Activity

          szetszwo Tsz-wo Sze added a comment -

          h4407_20130115.patch: change it to merge-sort like.

          szetszwo Tsz-wo Sze added a comment - h4407_20130115.patch: change it to merge-sort like.
          jingzhao Jing Zhao added a comment -

          The patch looks good. It also passed all the snapshot-related tests on my machine. +1 for the patch.

          jingzhao Jing Zhao added a comment - The patch looks good. It also passed all the snapshot-related tests on my machine. +1 for the patch.
          szetszwo Tsz-wo Sze added a comment -

          Thanks Jing for reviewing and testing the patch!

          I have committed this.

          szetszwo Tsz-wo Sze added a comment - Thanks Jing for reviewing and testing the patch! I have committed this.
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-Snapshots-Branch-build #73 (See https://builds.apache.org/job/Hadoop-Hdfs-Snapshots-Branch-build/73/)
          HDFS-4407. Change INodeDirectoryWithSnapshot.Diff.combinePostDiff(..) to merge-sort like and keep the postDiff parameter unmodified. (Revision 1433918)

          Result = FAILURE
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1433918
          Files :

          • /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-2802.txt
          • /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/INodeDirectoryWithSnapshot.java
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-Snapshots-Branch-build #73 (See https://builds.apache.org/job/Hadoop-Hdfs-Snapshots-Branch-build/73/ ) HDFS-4407 . Change INodeDirectoryWithSnapshot.Diff.combinePostDiff(..) to merge-sort like and keep the postDiff parameter unmodified. (Revision 1433918) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1433918 Files : /hadoop/common/branches/ HDFS-2802 /hadoop-hdfs-project/hadoop-hdfs/CHANGES. HDFS-2802 .txt /hadoop/common/branches/ HDFS-2802 /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/INodeDirectoryWithSnapshot.java

          People

            szetszwo Tsz-wo Sze
            szetszwo Tsz-wo Sze
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: