Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: auto-failover, ha, tools
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      we have a ZKFC be killed issue yesterday, but there's no shutdown hook msg on current codebase, let's keep the same behivior like HDFS-4153

      1. HDFS-4396.txt
        0.7 kB
        Liang Xie

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2080 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2080/)
        HDFS-4396. Add START_MSG/SHUTDOWN_MSG for ZKFC. Contributed by Liang Xie. (harsh: rev ae3e8c61ff4c926ef3e71c782433ed9764d21478)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2080 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2080/ ) HDFS-4396 . Add START_MSG/SHUTDOWN_MSG for ZKFC. Contributed by Liang Xie. (harsh: rev ae3e8c61ff4c926ef3e71c782433ed9764d21478) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #139 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/139/)
        HDFS-4396. Add START_MSG/SHUTDOWN_MSG for ZKFC. Contributed by Liang Xie. (harsh: rev ae3e8c61ff4c926ef3e71c782433ed9764d21478)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #139 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/139/ ) HDFS-4396 . Add START_MSG/SHUTDOWN_MSG for ZKFC. Contributed by Liang Xie. (harsh: rev ae3e8c61ff4c926ef3e71c782433ed9764d21478) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2098 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2098/)
        HDFS-4396. Add START_MSG/SHUTDOWN_MSG for ZKFC. Contributed by Liang Xie. (harsh: rev ae3e8c61ff4c926ef3e71c782433ed9764d21478)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2098 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2098/ ) HDFS-4396 . Add START_MSG/SHUTDOWN_MSG for ZKFC. Contributed by Liang Xie. (harsh: rev ae3e8c61ff4c926ef3e71c782433ed9764d21478) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #148 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/148/)
        HDFS-4396. Add START_MSG/SHUTDOWN_MSG for ZKFC. Contributed by Liang Xie. (harsh: rev ae3e8c61ff4c926ef3e71c782433ed9764d21478)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #148 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/148/ ) HDFS-4396 . Add START_MSG/SHUTDOWN_MSG for ZKFC. Contributed by Liang Xie. (harsh: rev ae3e8c61ff4c926ef3e71c782433ed9764d21478) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #882 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/882/)
        HDFS-4396. Add START_MSG/SHUTDOWN_MSG for ZKFC. Contributed by Liang Xie. (harsh: rev ae3e8c61ff4c926ef3e71c782433ed9764d21478)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #882 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/882/ ) HDFS-4396 . Add START_MSG/SHUTDOWN_MSG for ZKFC. Contributed by Liang Xie. (harsh: rev ae3e8c61ff4c926ef3e71c782433ed9764d21478) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #148 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/148/)
        HDFS-4396. Add START_MSG/SHUTDOWN_MSG for ZKFC. Contributed by Liang Xie. (harsh: rev ae3e8c61ff4c926ef3e71c782433ed9764d21478)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #148 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/148/ ) HDFS-4396 . Add START_MSG/SHUTDOWN_MSG for ZKFC. Contributed by Liang Xie. (harsh: rev ae3e8c61ff4c926ef3e71c782433ed9764d21478) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7458 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7458/)
        HDFS-4396. Add START_MSG/SHUTDOWN_MSG for ZKFC. Contributed by Liang Xie. (harsh: rev ae3e8c61ff4c926ef3e71c782433ed9764d21478)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7458 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7458/ ) HDFS-4396 . Add START_MSG/SHUTDOWN_MSG for ZKFC. Contributed by Liang Xie. (harsh: rev ae3e8c61ff4c926ef3e71c782433ed9764d21478) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java
        Hide
        qwertymaniac Harsh J added a comment -

        This looked good to me and still applied cleanly (release audit warns appear unrelated in past QA run). I went ahead and committed this to branch-2 and trunk. Many thanks for the patch Liang!

        Show
        qwertymaniac Harsh J added a comment - This looked good to me and still applied cleanly (release audit warns appear unrelated in past QA run). I went ahead and committed this to branch-2 and trunk. Many thanks for the patch Liang!
        Hide
        xieliang007 Liang Xie added a comment -

        The failed case and audit warnings are not relative with this patch, IMHO

        Show
        xieliang007 Liang Xie added a comment - The failed case and audit warnings are not relative with this patch, IMHO
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12564663/HDFS-4396.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 2 release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3833//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3833//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3833//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12564663/HDFS-4396.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 2 release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3833//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3833//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3833//console This message is automatically generated.
        Hide
        tlipcon Todd Lipcon added a comment -

        +1 pending Jenkins

        Show
        tlipcon Todd Lipcon added a comment - +1 pending Jenkins
        Hide
        xieliang007 Liang Xie added a comment -

        A trivial patch without running testcase, i just verified with real test env

        Show
        xieliang007 Liang Xie added a comment - A trivial patch without running testcase, i just verified with real test env

          People

          • Assignee:
            xieliang007 Liang Xie
            Reporter:
            xieliang007 Liang Xie
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development