Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-4393

Empty request and responses in protocol translators can be static final members

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 2.0.3-alpha
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Some of the empty request and responses in protocol translators are unnecessarily created every time. They can be static final members in the translators.

      Example: ClientNamenodeProtocolTranslatorPB.java

      GetServerDefaultsRequestProto req = GetServerDefaultsRequestProto.newBuilder().build();

      1. HDFS-4393.patch
        11 kB
        Brandon Li
      2. HDFS-4393.patch
        18 kB
        Brandon Li
      3. HDFS-4393.patch
        40 kB
        Brandon Li

        Activity

        Brandon Li created issue -
        Brandon Li made changes -
        Field Original Value New Value
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Brandon Li made changes -
        Attachment HDFS-4393.patch [ 12564996 ]
        Brandon Li made changes -
        Attachment HDFS-4393.patch [ 12565011 ]
        Brandon Li made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Brandon Li made changes -
        Affects Version/s 3.0.0 [ 12320356 ]
        Brandon Li made changes -
        Attachment HDFS-4393.patch [ 12565226 ]
        Suresh Srinivas made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 2.0.3-alpha [ 12323274 ]
        Resolution Fixed [ 1 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Brandon Li
            Reporter:
            Brandon Li
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development