Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
2.0.2-alpha, 3.0.0-alpha1
-
None
-
Reviewed
Description
we encountered a NN&DN hung issue, the DN hung was caused by no NN response for heartbeat. Per DN thread dump, i think we can have a little improvement on this detail code :
synchronized List<BPServiceActor> getBPServiceActors()
{ return Lists.newArrayList(bpServices); }the bpServices is declared as :
private List<BPServiceActor> bpServices =
new CopyOnWriteArrayList<BPServiceActor>();
It's a thread-safe variant indead, so we can remove the above synchronized keyword safely, IMHO.
Here is a simple statistic for thread dump:
xieliang@xieliang:/tmp$ grep 0x00000007b00289f0 dn.jstack |wc -l
252