Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-4300

TransferFsImage.downloadEditsToStorage should use a tmp file for destination

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha
    • Fix Version/s: 2.1.0-beta
    • Component/s: None
    • Labels:
      None

      Description

      Currently, in TransferFsImage.downloadEditsToStorage, we download the edits file directly to its finalized path. So, if the transfer fails in the middle, a half-written file is left and cannot be distinguished from a correct file. So, future checkpoints by the 2NN will fail, since the file is truncated in the middle – but it won't ever download a good copy because it thinks it already has the proper file.

      1. hdfs-4300-5.patch
        17 kB
        Andrew Wang
      2. hdfs-4300-4.patch
        17 kB
        Aaron T. Myers
      3. hdfs-4300-3.patch
        17 kB
        Andrew Wang
      4. hdfs-4300-2.patch
        17 kB
        Andrew Wang
      5. hdfs-4300-1.patch
        10 kB
        Andrew Wang

        Issue Links

          Activity

          Todd Lipcon created issue -
          Andrew Wang made changes -
          Field Original Value New Value
          Assignee Todd Lipcon [ tlipcon ] Andrew Wang [ andrew.wang ]
          Andrew Wang made changes -
          Attachment hdfs-4300-1.patch [ 12577683 ]
          Andrew Wang made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Andrew Wang made changes -
          Attachment hdfs-4300-2.patch [ 12581028 ]
          Andrew Wang made changes -
          Attachment hdfs-4300-3.patch [ 12581085 ]
          Chris Nauroth made changes -
          Link This issue is related to HDFS-3519 [ HDFS-3519 ]
          Aaron T. Myers made changes -
          Attachment hdfs-4300-4.patch [ 12582687 ]
          Andrew Wang made changes -
          Attachment hdfs-4300-5.patch [ 12582822 ]
          Aaron T. Myers made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 2.0.5-beta [ 12324031 ]
          Resolution Fixed [ 1 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Andrew Wang
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development