Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-4174

Backport HDFS-1031 to branch-1: to list a few of the corrupted files in WebUI

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Target Version/s:

      Description

      1. Add getCorruptFiles method to FSNamesystem (the getCorruptFiles method is in branch-0.21 but not in branch-1).

      2. Backport HDFS-1031: display corrupt files in WebUI.

      1. Screen Shot 2012-11-10 at 3.56.52 PM.png
        53 kB
        Suresh Srinivas
      2. ScreenShot_dfshealth.png
        113 kB
        Jing Zhao
      3. ScreenShot_corrupt_files.png
        64 kB
        Jing Zhao
      4. Screenshot_corrupt_files_002.png
        70 kB
        Jing Zhao
      5. HDFS-b1.1-4174.patch
        17 kB
        Jing Zhao
      6. HDFS-4174.b1.003.patch
        20 kB
        Jing Zhao
      7. HDFS-4174.b1.002.patch
        17 kB
        Jing Zhao
      8. HDFS-4174.b1.001.patch
        17 kB
        Jing Zhao

        Issue Links

          Activity

          Hide
          Matt Foley added a comment -

          Closed upon release of 1.1.1.

          Show
          Matt Foley added a comment - Closed upon release of 1.1.1.
          Hide
          Suresh Srinivas added a comment -

          I committed this patch to branch-1 and branch-1.1. Thank you Jing for back porting this useful change.

          Show
          Suresh Srinivas added a comment - I committed this patch to branch-1 and branch-1.1. Thank you Jing for back porting this useful change.
          Hide
          Jing Zhao added a comment -

          Patch for branch-1.1. Have tested with corrupted files and the correct WebUI information was provided.

          Show
          Jing Zhao added a comment - Patch for branch-1.1. Have tested with corrupted files and the correct WebUI information was provided.
          Hide
          Jing Zhao added a comment -

          testpatch result:
          -1 overall.
          +1 @author. The patch does not contain any @author tags.
          +1 tests included. The patch appears to include 2 new or modified tests.
          +1 javadoc. The javadoc tool did not generate any warning messages.
          +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          -1 findbugs. The patch appears to introduce 224 new Findbugs (version 2.0.1) warnings.

          Show
          Jing Zhao added a comment - testpatch result: -1 overall. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 224 new Findbugs (version 2.0.1) warnings.
          Hide
          Jing Zhao added a comment -

          The patch passed all the unit tests except TestFileCreation, which is unrelated and was reported in HDFS-4180. Will post test-patch result tonight.

          Show
          Jing Zhao added a comment - The patch passed all the unit tests except TestFileCreation, which is unrelated and was reported in HDFS-4180 . Will post test-patch result tonight.
          Hide
          Suresh Srinivas added a comment -

          +1 for the patch. Can you please run unit tests and test-patch?

          Show
          Suresh Srinivas added a comment - +1 for the patch. Can you please run unit tests and test-patch?
          Hide
          Jing Zhao added a comment -

          Update the patch to include block information. Will run unit testcases for the new patch.

          Show
          Jing Zhao added a comment - Update the patch to include block information. Will run unit testcases for the new patch.
          Hide
          Suresh Srinivas added a comment -

          Posting screenshot from the trunk. This also lists the corrupt block and not just the file name. It would be good to print the block information as well in this patch.

          Show
          Suresh Srinivas added a comment - Posting screenshot from the trunk. This also lists the corrupt block and not just the file name. It would be good to print the block information as well in this patch.
          Hide
          Jing Zhao added a comment -

          Also run unit tests locally and all the tests passed.

          Show
          Jing Zhao added a comment - Also run unit tests locally and all the tests passed.
          Hide
          Jing Zhao added a comment -

          New patch and WebUI images uploaded.

          Show
          Jing Zhao added a comment - New patch and WebUI images uploaded.
          Hide
          Suresh Srinivas added a comment -

          Ported patch looks good. Please make FSNamsystem#getCorruptInodes() private method. Also can you please post screenshots of the WebUI?

          Show
          Suresh Srinivas added a comment - Ported patch looks good. Please make FSNamsystem#getCorruptInodes() private method. Also can you please post screenshots of the WebUI?
          Hide
          Jing Zhao added a comment -

          Initial patch uploaded.

          Show
          Jing Zhao added a comment - Initial patch uploaded.

            People

            • Assignee:
              Jing Zhao
              Reporter:
              Jing Zhao
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development