Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-4151

Passing INodesInPath instead of INode[] in FSDirectory

        Details

        • Type: Improvement Improvement
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 2.1.0-beta
        • Component/s: namenode
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          Currently, many methods in FSDirectory pass INode[] as a parameter. It is better to pass INodesInPath so that we can add more path information later on. This is especially useful in Snapshot implementation.

          1. Text File
            h4151_20121104.patch
            25 kB
            Tsz Wo Nicholas Sze
          2. Text File
            h4151_20121105.patch
            26 kB
            Tsz Wo Nicholas Sze

            Issue Links

            relates to

            New Feature - A new feature of the product, which has yet to be developed. HDFS-2802 Support for RW/RO snapshots in HDFS

            • Major - Major loss of function.
            • Resolved

              Activity

              Descending order - Click to sort in ascending order
              Allen Wittenauer made changes -
              Fix Version/s 3.0.0 [ 12320356 ]
              Arun C Murthy made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Suresh Srinivas made changes -
              Fix Version/s 2.0.5-beta [ 12324031 ]
              Hide
              Permalink
              Suresh Srinivas added a comment -

              I merged this patch to branch-2.

              Show
              Suresh Srinivas added a comment - I merged this patch to branch-2.
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Mapreduce-trunk #1331 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1331/)
              Change incorrect jira number HDFS-4151 to HDFS-4451 and move it to incompatible section. (Revision 1441123)
              HDFS-4151. hdfs balancer command returns exit code 1 on success instead of 0. Contributed by Joshua Blatt. (Revision 1441113)

              Result = SUCCESS
              suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441123
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

              suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441113
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
              Show
              Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1331 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1331/ ) Change incorrect jira number HDFS-4151 to HDFS-4451 and move it to incompatible section. (Revision 1441123) HDFS-4151 . hdfs balancer command returns exit code 1 on success instead of 0. Contributed by Joshua Blatt. (Revision 1441113) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441123 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441113 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Hdfs-trunk #1303 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1303/)
              Change incorrect jira number HDFS-4151 to HDFS-4451 and move it to incompatible section. (Revision 1441123)
              HDFS-4151. hdfs balancer command returns exit code 1 on success instead of 0. Contributed by Joshua Blatt. (Revision 1441113)

              Result = SUCCESS
              suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441123
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

              suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441113
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
              Show
              Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1303 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1303/ ) Change incorrect jira number HDFS-4151 to HDFS-4451 and move it to incompatible section. (Revision 1441123) HDFS-4151 . hdfs balancer command returns exit code 1 on success instead of 0. Contributed by Joshua Blatt. (Revision 1441113) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441123 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441113 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Yarn-trunk #114 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/114/)
              Change incorrect jira number HDFS-4151 to HDFS-4451 and move it to incompatible section. (Revision 1441123)
              HDFS-4151. hdfs balancer command returns exit code 1 on success instead of 0. Contributed by Joshua Blatt. (Revision 1441113)

              Result = SUCCESS
              suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441123
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

              suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441113
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
              Show
              Hudson added a comment - Integrated in Hadoop-Yarn-trunk #114 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/114/ ) Change incorrect jira number HDFS-4151 to HDFS-4451 and move it to incompatible section. (Revision 1441123) HDFS-4151 . hdfs balancer command returns exit code 1 on success instead of 0. Contributed by Joshua Blatt. (Revision 1441113) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441123 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441113 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-trunk-Commit #3306 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3306/)
              Change incorrect jira number HDFS-4151 to HDFS-4451 and move it to incompatible section. (Revision 1441123)

              Result = SUCCESS
              suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441123
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Show
              Hudson added a comment - Integrated in Hadoop-trunk-Commit #3306 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3306/ ) Change incorrect jira number HDFS-4151 to HDFS-4451 and move it to incompatible section. (Revision 1441123) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441123 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-trunk-Commit #3305 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3305/)
              HDFS-4151. hdfs balancer command returns exit code 1 on success instead of 0. Contributed by Joshua Blatt. (Revision 1441113)

              Result = SUCCESS
              suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441113
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
              Show
              Hudson added a comment - Integrated in Hadoop-trunk-Commit #3305 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3305/ ) HDFS-4151 . hdfs balancer command returns exit code 1 on success instead of 0. Contributed by Joshua Blatt. (Revision 1441113) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441113 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Mapreduce-trunk #1248 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1248/)
              HDFS-4151. Change the methods in FSDirectory to pass INodesInPath instead of INode[] as a parameter. (Revision 1406006)

              Result = FAILURE
              szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406006
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeDirectory.java
              Show
              Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1248 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1248/ ) HDFS-4151 . Change the methods in FSDirectory to pass INodesInPath instead of INode[] as a parameter. (Revision 1406006) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406006 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeDirectory.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Hdfs-trunk #1218 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1218/)
              HDFS-4151. Change the methods in FSDirectory to pass INodesInPath instead of INode[] as a parameter. (Revision 1406006)

              Result = SUCCESS
              szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406006
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeDirectory.java
              Show
              Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1218 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1218/ ) HDFS-4151 . Change the methods in FSDirectory to pass INodesInPath instead of INode[] as a parameter. (Revision 1406006) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406006 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeDirectory.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Yarn-trunk #28 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/28/)
              HDFS-4151. Change the methods in FSDirectory to pass INodesInPath instead of INode[] as a parameter. (Revision 1406006)

              Result = SUCCESS
              szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406006
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeDirectory.java
              Show
              Hudson added a comment - Integrated in Hadoop-Yarn-trunk #28 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/28/ ) HDFS-4151 . Change the methods in FSDirectory to pass INodesInPath instead of INode[] as a parameter. (Revision 1406006) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406006 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeDirectory.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-trunk-Commit #2957 (See https://builds.apache.org/job/Hadoop-trunk-Commit/2957/)
              HDFS-4151. Change the methods in FSDirectory to pass INodesInPath instead of INode[] as a parameter. (Revision 1406006)

              Result = SUCCESS
              szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406006
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeDirectory.java
              Show
              Hudson added a comment - Integrated in Hadoop-trunk-Commit #2957 (See https://builds.apache.org/job/Hadoop-trunk-Commit/2957/ ) HDFS-4151 . Change the methods in FSDirectory to pass INodesInPath instead of INode[] as a parameter. (Revision 1406006) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406006 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeDirectory.java
              Tsz Wo Nicholas Sze made changes -
              Status Patch Available [ 10002 ] Resolved [ 5 ]
              Hadoop Flags Reviewed [ 10343 ]
              Fix Version/s 3.0.0 [ 12320356 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Tsz Wo Nicholas Sze added a comment -

              I have committed this.

              Show
              Tsz Wo Nicholas Sze added a comment - I have committed this.
              Hide
              Permalink
              Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12552156/h4151_20121105.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
              Please justify why no new tests are needed for this patch.
              Also please list what manual steps were performed to verify this patch.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 eclipse:eclipse. The patch built with eclipse:eclipse.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3445//testReport/
              Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3445//console

              This message is automatically generated.

              Show
              Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12552156/h4151_20121105.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3445//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3445//console This message is automatically generated.
              Tsz Wo Nicholas Sze made changes -
              Link This issue relates to HDFS-2802 [ HDFS-2802 ]
              Tsz Wo Nicholas Sze made changes -
              Attachment h4151_20121105.patch [ 12552156 ]
              Hide
              Permalink
              Tsz Wo Nicholas Sze added a comment -

              h4151_20121105.patch: fixes the javadoc and some bugs in the patch causing the test failure.

              Show
              Tsz Wo Nicholas Sze added a comment - h4151_20121105.patch: fixes the javadoc and some bugs in the patch causing the test failure.
              Hide
              Permalink
              Suresh Srinivas added a comment -

              +1 with the above comment addressed.

              Show
              Suresh Srinivas added a comment - +1 with the above comment addressed.
              Hide
              Permalink
              Suresh Srinivas added a comment -

              Minort comment - FSNamesystem#allocateBlock() - javadoc @param needs to be updated from "inodes" to "inodesInPath". Otherwise the patch looks good.

              Show
              Suresh Srinivas added a comment - Minort comment - FSNamesystem#allocateBlock() - javadoc @param needs to be updated from "inodes" to "inodesInPath". Otherwise the patch looks good.
              Hide
              Permalink
              Suresh Srinivas added a comment -

              Nicholas, if this is for trunk can you please mark the Affects Versions(s) as 3.0.0?

              Show
              Suresh Srinivas added a comment - Nicholas, if this is for trunk can you please mark the Affects Versions(s) as 3.0.0?
              Hide
              Permalink
              Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12552059/h4151_20121104.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
              Please justify why no new tests are needed for this patch.
              Also please list what manual steps were performed to verify this patch.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 eclipse:eclipse. The patch built with eclipse:eclipse.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

              org.apache.hadoop.fs.TestFcHdfsSymlink

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3441//testReport/
              Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3441//console

              This message is automatically generated.

              Show
              Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12552059/h4151_20121104.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.fs.TestFcHdfsSymlink +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3441//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3441//console This message is automatically generated.
              Tsz Wo Nicholas Sze made changes -
              Status Open [ 1 ] Patch Available [ 10002 ]
              Tsz Wo Nicholas Sze made changes -
              Field Original Value New Value
              Attachment h4151_20121104.patch [ 12552059 ]
              Hide
              Permalink
              Tsz Wo Nicholas Sze added a comment -

              h4151_20121104.patch: replaces INode[] with INodesInPath except for the verifyQuota/verifyFsLimits methods

              Show
              Tsz Wo Nicholas Sze added a comment - h4151_20121104.patch: replaces INode[] with INodesInPath except for the verifyQuota/verifyFsLimits methods
              Tsz Wo Nicholas Sze created issue -

                People

                • Assignee:
                  Tsz Wo Nicholas Sze
                  Reporter:
                  Tsz Wo Nicholas Sze
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development