Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-4062

In branch-1, FSNameSystem#invalidateWorkForOneNode and FSNameSystem#computeReplicationWorkForBlock should print logs outside of the namesystem lock

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Similar to HDFS-4052 for trunk, both FSNameSystem#invalidateWorkForOneNode and FSNameSystem#computeReplicationWorkForBlock in branch-1 should print long log info level information outside of the namesystem lock. We create this separate jira since the description and code is different for 1.x.

        Issue Links

          Activity

          Jing Zhao created issue -
          Jing Zhao made changes -
          Field Original Value New Value
          Link This issue is related to HDFS-4052 [ HDFS-4052 ]
          Hide
          Jing Zhao added a comment -

          Patch uploaded.

          Show
          Jing Zhao added a comment - Patch uploaded.
          Jing Zhao made changes -
          Attachment HDFS-4062.b1.001.patch [ 12549259 ]
          Hide
          Jing Zhao added a comment -

          test-patch output:
          -1 overall.
          +1 @author. The patch does not contain any @author tags.
          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.
          +1 javadoc. The javadoc tool did not generate any warning messages.
          +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          -1 findbugs. The patch appears to introduce 222 new Findbugs (version 2.0.1) warnings.

          Show
          Jing Zhao added a comment - test-patch output: -1 overall. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 222 new Findbugs (version 2.0.1) warnings.
          Hide
          Suresh Srinivas added a comment -

          test-patch is broken in branch-1. Tests not needed because this patch just moves the logs outside the lock.

          +1 for the patch.

          Show
          Suresh Srinivas added a comment - test-patch is broken in branch-1. Tests not needed because this patch just moves the logs outside the lock. +1 for the patch.
          Hide
          Suresh Srinivas added a comment -

          I committed the patch to branch-1. Thank you Jing for fixing this.

          Show
          Suresh Srinivas added a comment - I committed the patch to branch-1. Thank you Jing for fixing this.
          Suresh Srinivas made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Resolution Fixed [ 1 ]
          Matt Foley made changes -
          Fix Version/s 1.2.0 [ 12321657 ]
          Hide
          Matt Foley added a comment -

          Added 1.2.0 to fixVersion. Corrected reference in CHANGES.txt from HDFS-3062 to HDFS-4062.

          Show
          Matt Foley added a comment - Added 1.2.0 to fixVersion. Corrected reference in CHANGES.txt from HDFS-3062 to HDFS-4062 .
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop 1.2.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.
          Matt Foley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          6d 23h 49m 1 Suresh Srinivas 23/Oct/12 05:35
          Resolved Resolved Closed Closed
          204d 40m 1 Matt Foley 15/May/13 06:16

            People

            • Assignee:
              Jing Zhao
              Reporter:
              Jing Zhao
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development