Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-4057

NameNode.namesystem should be private. Use getNamesystem() instead.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      NameNode.namesystem should be private. One should use NameNode.getNamesystem() to get it instead.

      1. HDFS-4057.branch-1.patch
        21 kB
        Brandon Li
      2. HDFS-4057.branch-1.patch
        3 kB
        Brandon Li

        Activity

        Brandon Li created issue -
        Brandon Li made changes -
        Field Original Value New Value
        Attachment HDFS-4057.branch-1.patch [ 12549218 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 Patch looks good.

        Could you run test-patch and unit tests if you haven't done so?

        Show
        Tsz Wo Nicholas Sze added a comment - +1 Patch looks good. Could you run test-patch and unit tests if you haven't done so?
        Tsz Wo Nicholas Sze made changes -
        Hadoop Flags Reviewed [ 10343 ]
        Hide
        Suresh Srinivas added a comment -

        This patch needs more work. Tests do not compile with this.

        Show
        Suresh Srinivas added a comment - This patch needs more work. Tests do not compile with this.
        Hide
        Brandon Li added a comment -

        Re-based the patch and fixed the compilation problem. Sorry.

        Running test-patch

        Show
        Brandon Li added a comment - Re-based the patch and fixed the compilation problem. Sorry. Running test-patch
        Brandon Li made changes -
        Attachment HDFS-4057.branch-1.patch [ 12549591 ]
        Hide
        Brandon Li added a comment -

        test-patch result:

        -1 overall.  
            +1 @author.  The patch does not contain any @author tags.
            +1 tests included.  The patch appears to include 54 new or modified tests.
            +1 javadoc.  The javadoc tool did not generate any warning messages.
            +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
            -1 findbugs.  The patch appears to introduce 197 new Findbugs (version 2.0.0) warnings.
        

        The findbug warnings were not introduced by this patch.

        Show
        Brandon Li added a comment - test-patch result: -1 overall. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 54 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 197 new Findbugs (version 2.0.0) warnings. The findbug warnings were not introduced by this patch.
        Hide
        Suresh Srinivas added a comment -

        I committed the patch to branch-1. Thank you Brandon.

        Show
        Suresh Srinivas added a comment - I committed the patch to branch-1. Thank you Brandon.
        Suresh Srinivas made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.2.0 [ 12321657 ]
        Resolution Fixed [ 1 ]
        Hide
        Matt Foley added a comment -

        Closed upon release of Hadoop 1.2.0.

        Show
        Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.
        Matt Foley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        5d 4h 7m 1 Suresh Srinivas 21/Oct/12 02:41
        Resolved Resolved Closed Closed
        206d 3h 34m 1 Matt Foley 15/May/13 06:16

          People

          • Assignee:
            Brandon Li
            Reporter:
            Brandon Li
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development