NameNode.namesystem should be private. One should use NameNode.getNamesystem() to get it instead.
+1 Patch looks good.
Could you run test-patch and unit tests if you haven't done so?
This patch needs more work. Tests do not compile with this.
Re-based the patch and fixed the compilation problem. Sorry.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 54 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 197 new Findbugs (version 2.0.0) warnings.
The findbug warnings were not introduced by this patch.
I committed the patch to branch-1. Thank you Brandon.
Closed upon release of Hadoop 1.2.0.