Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.5
    • Component/s: None
    • Labels:
      None

      Description

      We suggest a patch that back-ports the change https://issues.apache.org/jira/browse/HDFS-3582 to branch 0.23.

        Issue Links

          Activity

          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12548219/HDFS-4016-branch-0.23.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3289//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12548219/HDFS-4016-branch-0.23.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3289//console This message is automatically generated.
          Hide
          Ivan A. Veselovsky added a comment -

          The patch is against the "branch-0.23" branch, not against "trunk".
          It looks like the system cannot get the branch name automatically from the patch name, as described in http://wiki.apache.org/hadoop/HowToContribute , https://issues.apache.org/jira/browse/HADOOP-7435 is not resolved.

          Show
          Ivan A. Veselovsky added a comment - The patch is against the "branch-0.23" branch, not against "trunk". It looks like the system cannot get the branch name automatically from the patch name, as described in http://wiki.apache.org/hadoop/HowToContribute , https://issues.apache.org/jira/browse/HADOOP-7435 is not resolved.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12548222/HDFS-4016-branch-0.23.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3290//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12548222/HDFS-4016-branch-0.23.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3290//console This message is automatically generated.
          Hide
          gongsuochen added a comment -

          please tell me how to unsubscribe .
          thank you.

          Show
          gongsuochen added a comment - please tell me how to unsubscribe . thank you.
          Hide
          Ivan A. Veselovsky added a comment -

          2gschen: afaik, just click "Watching" link in the upper right corner of this page.

          Show
          Ivan A. Veselovsky added a comment - 2gschen: afaik, just click "Watching" link in the upper right corner of this page.
          Hide
          Robert Joseph Evans added a comment -

          Linking the two together

          Show
          Robert Joseph Evans added a comment - Linking the two together
          Hide
          Robert Joseph Evans added a comment -

          There seems to be a lot in this patch that is not in the original.

          It looks like you pulled in Time.java so that you could also update GenericTestUtils.waitFor, which is something that is not related to HDFS-3582. In fact it looks like GenericTestUtils does not need to be updated at all. Please revert it and Time.java so if we ever do decide to port HDFS-3641 and others it will not be so confusing or difficult.

          The same goes for DFSConfigKeys.java. None of the changes in there are used at all.

          Also the isActive method inside FSEditLog.java looks like it can still be marked as private.

          Other then that the port looks good.

          Show
          Robert Joseph Evans added a comment - There seems to be a lot in this patch that is not in the original. It looks like you pulled in Time.java so that you could also update GenericTestUtils.waitFor, which is something that is not related to HDFS-3582 . In fact it looks like GenericTestUtils does not need to be updated at all. Please revert it and Time.java so if we ever do decide to port HDFS-3641 and others it will not be so confusing or difficult. The same goes for DFSConfigKeys.java. None of the changes in there are used at all. Also the isActive method inside FSEditLog.java looks like it can still be marked as private. Other then that the port looks good.
          Hide
          Ivan A. Veselovsky added a comment -

          Attached 2nd patch version which fixes all the above review comments.

          Show
          Ivan A. Veselovsky added a comment - Attached 2nd patch version which fixes all the above review comments.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12549287/HDFS-4016-branch-0.23.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3343//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12549287/HDFS-4016-branch-0.23.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3343//console This message is automatically generated.
          Hide
          Robert Joseph Evans added a comment -

          The patch looks good to me. I am running the unit tests and I will try to bring up a small cluster. If everything goes OK I'll check it in. +1 Thanks for the work Ivan.

          Show
          Robert Joseph Evans added a comment - The patch looks good to me. I am running the unit tests and I will try to bring up a small cluster. If everything goes OK I'll check it in. +1 Thanks for the work Ivan.
          Hide
          Robert Joseph Evans added a comment -

          Thanks again Ivan. I put this into branch-0.23

          Show
          Robert Joseph Evans added a comment - Thanks again Ivan. I put this into branch-0.23
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #407 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/407/)
          HDFS-4016. back-port HDFS-3582 to branch-0.23 (Ivan A. Veselovsky via bobby) (Revision 1398901)

          Result = UNSTABLE
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1398901
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ExitUtil.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsSetUMask.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestClusterId.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLogJournalFailures.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #407 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/407/ ) HDFS-4016 . back-port HDFS-3582 to branch-0.23 (Ivan A. Veselovsky via bobby) (Revision 1398901) Result = UNSTABLE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1398901 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ExitUtil.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsSetUMask.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestClusterId.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLogJournalFailures.java

            People

            • Assignee:
              Ivan A. Veselovsky
              Reporter:
              Ivan A. Veselovsky
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development