Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-4003

test-patch should build the common native libs before running hdfs tests

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.3-alpha
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HDFS-3753 added a dependency on common's native build, let's modify test-patch to run the common native build before running Hdfs tests so Hdfs tests can depend on libhadoop (eg TestHdfsNativeCodeLoader).

      1. HDFS-4003.002.patch
        0.9 kB
        Colin P. McCabe
      2. HDFS-4003.003.patch
        3 kB
        Colin P. McCabe

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2870 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2870/)
          Amend HDFS-3753 to ignore TestHdfsNativeCodeLoader. To be fixed in HDFS-4003. (Revision 1393830)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393830
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2870 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2870/ ) Amend HDFS-3753 to ignore TestHdfsNativeCodeLoader. To be fixed in HDFS-4003 . (Revision 1393830) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393830 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2808 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2808/)
          Amend HDFS-3753 to ignore TestHdfsNativeCodeLoader. To be fixed in HDFS-4003. (Revision 1393830)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393830
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2808 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2808/ ) Amend HDFS-3753 to ignore TestHdfsNativeCodeLoader. To be fixed in HDFS-4003 . (Revision 1393830) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393830 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2831 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2831/)
          Amend HDFS-3753 to ignore TestHdfsNativeCodeLoader. To be fixed in HDFS-4003. (Revision 1393830)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393830
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2831 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2831/ ) Amend HDFS-3753 to ignore TestHdfsNativeCodeLoader. To be fixed in HDFS-4003 . (Revision 1393830) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393830 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1185 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1185/)
          Amend HDFS-3753 to ignore TestHdfsNativeCodeLoader. To be fixed in HDFS-4003. (Revision 1393830)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393830
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1185 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1185/ ) Amend HDFS-3753 to ignore TestHdfsNativeCodeLoader. To be fixed in HDFS-4003 . (Revision 1393830) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393830 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1216 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1216/)
          Amend HDFS-3753 to ignore TestHdfsNativeCodeLoader. To be fixed in HDFS-4003. (Revision 1393830)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393830
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1216 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1216/ ) Amend HDFS-3753 to ignore TestHdfsNativeCodeLoader. To be fixed in HDFS-4003 . (Revision 1393830) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393830 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Hide
          cmccabe Colin P. McCabe added a comment -

          This patch builds the native code in hadoop-common before running the hadoop-hdfs unit tests.

          Show
          cmccabe Colin P. McCabe added a comment - This patch builds the native code in hadoop-common before running the hadoop-hdfs unit tests.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12547842/HDFS-4003.002.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3270//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3270//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12547842/HDFS-4003.002.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3270//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3270//console This message is automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          I ran the new version of test-patch.sh on a patch which modified the hadoop-hdfs project, and verified that it built the libhadoop.so library correctly.

          I also ran it with a patch that modified the hadoop-common project, and verified that it worked as expected.

          Show
          cmccabe Colin P. McCabe added a comment - I ran the new version of test-patch.sh on a patch which modified the hadoop-hdfs project, and verified that it built the libhadoop.so library correctly. I also ran it with a patch that modified the hadoop-common project, and verified that it worked as expected.
          Hide
          eli Eli Collins added a comment -

          We need to remove the @Ignore from TestHdfsNativeCodeLoader and you can move the if statement into the following for loop. Otherwise looks great.

          Show
          eli Eli Collins added a comment - We need to remove the @Ignore from TestHdfsNativeCodeLoader and you can move the if statement into the following for loop. Otherwise looks great.
          Hide
          cmccabe Colin P. McCabe added a comment -
          • remove {\@Ignore}

            from TestHdfsNativeCodeLoader

          • don't call "mvn compile" on hdfs-common if we've already built it.
          Show
          cmccabe Colin P. McCabe added a comment - remove {\@Ignore} from TestHdfsNativeCodeLoader don't call "mvn compile" on hdfs-common if we've already built it.
          Hide
          cmccabe Colin P. McCabe added a comment -

          I tested this with two patches: one which modified just hadoop-common, and another which modified just hadoop-hdfs.

          Show
          cmccabe Colin P. McCabe added a comment - I tested this with two patches: one which modified just hadoop-common, and another which modified just hadoop-hdfs.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12548055/HDFS-4003.003.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.fs.TestHdfsNativeCodeLoader

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3280//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3280//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12548055/HDFS-4003.003.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.fs.TestHdfsNativeCodeLoader +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3280//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3280//console This message is automatically generated.
          Hide
          eli Eli Collins added a comment -

          +1 lgtm

          Show
          eli Eli Collins added a comment - +1 lgtm
          Hide
          eli Eli Collins added a comment -

          I've committed this. Thanks Colin.

          Show
          eli Eli Collins added a comment - I've committed this. Thanks Colin.
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2822 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2822/)
          HDFS-4003. test-patch should build the common native libs before running hdfs tests. Contributed by Colin Patrick McCabe (Revision 1395708)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395708
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2822 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2822/ ) HDFS-4003 . test-patch should build the common native libs before running hdfs tests. Contributed by Colin Patrick McCabe (Revision 1395708) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395708 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2884 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2884/)
          HDFS-4003. test-patch should build the common native libs before running hdfs tests. Contributed by Colin Patrick McCabe (Revision 1395708)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395708
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2884 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2884/ ) HDFS-4003 . test-patch should build the common native libs before running hdfs tests. Contributed by Colin Patrick McCabe (Revision 1395708) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395708 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2847 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2847/)
          HDFS-4003. test-patch should build the common native libs before running hdfs tests. Contributed by Colin Patrick McCabe (Revision 1395708)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395708
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2847 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2847/ ) HDFS-4003 . test-patch should build the common native libs before running hdfs tests. Contributed by Colin Patrick McCabe (Revision 1395708) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395708 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1190 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1190/)
          HDFS-4003. test-patch should build the common native libs before running hdfs tests. Contributed by Colin Patrick McCabe (Revision 1395708)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395708
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1190 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1190/ ) HDFS-4003 . test-patch should build the common native libs before running hdfs tests. Contributed by Colin Patrick McCabe (Revision 1395708) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395708 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1221 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1221/)
          HDFS-4003. test-patch should build the common native libs before running hdfs tests. Contributed by Colin Patrick McCabe (Revision 1395708)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395708
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1221 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1221/ ) HDFS-4003 . test-patch should build the common native libs before running hdfs tests. Contributed by Colin Patrick McCabe (Revision 1395708) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395708 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHdfsNativeCodeLoader.java

            People

            • Assignee:
              cmccabe Colin P. McCabe
              Reporter:
              eli Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development