Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3966

For branch-1, TestFileCreation should use JUnit4 to make assumeTrue work

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.1.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently in TestFileCreation for branch-1, assumeTrue() is used by two test cases in order to check if the OS is Linux. Thus JUnit 4 should be used to enable assumeTrue.

        Issue Links

          Activity

          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop-1.1.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop-1.1.0.
          Hide
          Suresh Srinivas added a comment -

          I committed the patch to branch-1 and to branch-1.1. Thank you Jing for fixing the test.

          Show
          Suresh Srinivas added a comment - I committed the patch to branch-1 and to branch-1.1. Thank you Jing for fixing the test.
          Hide
          Eli Collins added a comment -

          +1 looks good

          Show
          Eli Collins added a comment - +1 looks good
          Hide
          Jing Zhao added a comment -

          Updated based on Suresh's comments.

          Show
          Jing Zhao added a comment - Updated based on Suresh's comments.
          Hide
          Suresh Srinivas added a comment -

          Quick comment - xxxtestFileCreationNamenodeRestart() was prefixed with xxx to turn the test off. Please comment @Test annotation for this method as well.

          Show
          Suresh Srinivas added a comment - Quick comment - xxxtestFileCreationNamenodeRestart() was prefixed with xxx to turn the test off. Please comment @Test annotation for this method as well.
          Hide
          Jing Zhao added a comment -

          Upload patch for branch 1.1

          Show
          Jing Zhao added a comment - Upload patch for branch 1.1

            People

            • Assignee:
              Jing Zhao
              Reporter:
              Jing Zhao
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development