Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-3916

libwebhdfs (C client) code cleanups

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.0.2-alpha
    • 2.0.3-alpha
    • webhdfs
    • None
    • Reviewed

    Description

      Code cleanups in libwebhdfs.

      • don't duplicate exception.c, exception.h, expect.h, jni_helper.c. We have one copy of these files; we don't need 2.
      • remember to set errno in all public library functions (this is part of the API)
      • fix undefined symbols (if a function is not implemented, it should return ENOTSUP, but still exist)
      • don't expose private data structures in the (end-user visible) public headers
      • can't re-use hdfsBuilder as hdfsFS, because the strings in hdfsBuilder are not dynamically allocated.

      Attachments

        1. 0002-fix.patch
          107 kB
          Colin McCabe
        2. HDFS-3916.003.patch
          136 kB
          Colin McCabe
        3. HDFS-3916.004.patch
          136 kB
          Colin McCabe
        4. HDFS-3916.005.patch
          154 kB
          Colin McCabe
        5. HDFS-3916.006.patch
          154 kB
          Colin McCabe

        Issue Links

          Activity

            People

              cmccabe Colin McCabe
              cmccabe Colin McCabe
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: