Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-3871

Change NameNodeProxies to use HADOOP-8748

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 1.1.0, 2.0.2-alpha
        • Component/s: hdfs-client
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          Change NameNodeProxies to use util method introduced via HADOOP-8748.

          1. Text File
            HDFS-3781_branch1.patch
            7 kB
            Arun C Murthy
          2. Text File
            HDFS-3781.patch
            8 kB
            Arun C Murthy

            Issue Links

            blocks

            Improvement - An improvement or enhancement to an existing feature or task. MAPREDUCE-4603 Allow JobClient to retry job-submission when JT is in safemode

            • Major - Major loss of function.
            • Closed
            is blocked by

            Improvement - An improvement or enhancement to an existing feature or task. HADOOP-8748 Move dfsclient retry to a util class

            • Minor - Minor loss of function, or other problem where easy workaround is present.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              acmurthy Arun C Murthy added a comment -

              Patch for branch-1.

              Show
              acmurthy Arun C Murthy added a comment - Patch for branch-1.
              Hide
              Permalink
              acmurthy Arun C Murthy added a comment -

              Patch for trunk.

              Show
              acmurthy Arun C Murthy added a comment - Patch for trunk.
              Hide
              Permalink
              szetszwo Tsz Wo Nicholas Sze added a comment -

              +1 for both the trunk and the branch-1 patches.

              Show
              szetszwo Tsz Wo Nicholas Sze added a comment - +1 for both the trunk and the branch-1 patches.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12543094/HDFS-3781.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
              Please justify why no new tests are needed for this patch.
              Also please list what manual steps were performed to verify this patch.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 eclipse:eclipse. The patch built with eclipse:eclipse.

              -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

              org.apache.hadoop.hdfs.TestHftpDelegationToken
              org.apache.hadoop.hdfs.TestDatanodeBlockScanner
              org.apache.hadoop.hdfs.TestPersistBlocks

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3124//testReport/
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3124//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
              Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3124//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12543094/HDFS-3781.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestHftpDelegationToken org.apache.hadoop.hdfs.TestDatanodeBlockScanner org.apache.hadoop.hdfs.TestPersistBlocks +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3124//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3124//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3124//console This message is automatically generated.
              Hide
              Permalink
              acmurthy Arun C Murthy added a comment -

              The test failures and findbugs warnings are not related.

              I didn't add a new test since there is an existing test which covers this already.

              Show
              acmurthy Arun C Murthy added a comment - The test failures and findbugs warnings are not related. I didn't add a new test since there is an existing test which covers this already.
              Hide
              Permalink
              acmurthy Arun C Murthy added a comment -

              Nic - can you pls commit the patch yourself? I don't feel quite right committing to HDFS...

              Show
              acmurthy Arun C Murthy added a comment - Nic - can you pls commit the patch yourself? I don't feel quite right committing to HDFS...
              Hide
              Permalink
              szetszwo Tsz Wo Nicholas Sze added a comment -

              No problem.

              I have committed this. Thanks, Arun!

              Show
              szetszwo Tsz Wo Nicholas Sze added a comment - No problem. I have committed this. Thanks, Arun!
              Hide
              Permalink
              hudson Hudson added a comment -

              Integrated in Hadoop-Common-trunk-Commit #2670 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2670/)
              HDFS-3871. Change NameNodeProxies to use RetryUtils. Contributed by Arun C Murthy (Revision 1379743)

              Result = SUCCESS
              szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379743
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
              Show
              hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2670 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2670/ ) HDFS-3871 . Change NameNodeProxies to use RetryUtils. Contributed by Arun C Murthy (Revision 1379743) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379743 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
              Hide
              Permalink
              hudson Hudson added a comment -

              Integrated in Hadoop-Hdfs-trunk-Commit #2733 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2733/)
              HDFS-3871. Change NameNodeProxies to use RetryUtils. Contributed by Arun C Murthy (Revision 1379743)

              Result = SUCCESS
              szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379743
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
              Show
              hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2733 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2733/ ) HDFS-3871 . Change NameNodeProxies to use RetryUtils. Contributed by Arun C Murthy (Revision 1379743) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379743 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
              Hide
              Permalink
              hudson Hudson added a comment -

              Integrated in Hadoop-Mapreduce-trunk-Commit #2695 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2695/)
              HDFS-3871. Change NameNodeProxies to use RetryUtils. Contributed by Arun C Murthy (Revision 1379743)

              Result = FAILURE
              szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379743
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
              Show
              hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2695 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2695/ ) HDFS-3871 . Change NameNodeProxies to use RetryUtils. Contributed by Arun C Murthy (Revision 1379743) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379743 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
              Hide
              Permalink
              hudson Hudson added a comment -

              Integrated in Hadoop-Mapreduce-trunk #1183 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1183/)
              HDFS-3871. Change NameNodeProxies to use RetryUtils. Contributed by Arun C Murthy (Revision 1379743)

              Result = SUCCESS
              szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379743
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
              Show
              hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1183 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1183/ ) HDFS-3871 . Change NameNodeProxies to use RetryUtils. Contributed by Arun C Murthy (Revision 1379743) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379743 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
              Hide
              Permalink
              hudson Hudson added a comment -

              Integrated in Hadoop-Hdfs-trunk #1153 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1153/)
              HDFS-3871. Change NameNodeProxies to use RetryUtils. Contributed by Arun C Murthy (Revision 1379743)

              Result = FAILURE
              szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379743
              Files :

              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
              Show
              hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1153 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1153/ ) HDFS-3871 . Change NameNodeProxies to use RetryUtils. Contributed by Arun C Murthy (Revision 1379743) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379743 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
              Hide
              Permalink
              acmurthy Arun C Murthy added a comment -

              Matt - if you don't mind, I'd like to merge this into branch-1.1 since it's a trivial change. Thoughts?

              Show
              acmurthy Arun C Murthy added a comment - Matt - if you don't mind, I'd like to merge this into branch-1.1 since it's a trivial change. Thoughts?
              Hide
              Permalink
              acmurthy Arun C Murthy added a comment -

              I just merged this to branch-1.1 after talking to Matt.

              Show
              acmurthy Arun C Murthy added a comment - I just merged this to branch-1.1 after talking to Matt.

                People

                • Assignee:
                  acmurthy Arun C Murthy
                  Reporter:
                  acmurthy Arun C Murthy
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development