I just merged this to branch-1.1 after talking to Matt.

Matt - if you don't mind, I'd like to merge this into branch-1.1 since it's a trivial change. Thoughts?

Integrated in Hadoop-Hdfs-trunk #1153 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1153/)
HDFS-3871. Change NameNodeProxies to use RetryUtils. Contributed by Arun C Murthy (Revision 1379743)

Result = FAILURE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379743
Files :

• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java

Integrated in Hadoop-Mapreduce-trunk #1183 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1183/)
HDFS-3871. Change NameNodeProxies to use RetryUtils. Contributed by Arun C Murthy (Revision 1379743)

Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379743
Files :

• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java

Integrated in Hadoop-Mapreduce-trunk-Commit #2695 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2695/)
HDFS-3871. Change NameNodeProxies to use RetryUtils. Contributed by Arun C Murthy (Revision 1379743)

Result = FAILURE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379743
Files :

• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java

Integrated in Hadoop-Hdfs-trunk-Commit #2733 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2733/)
HDFS-3871. Change NameNodeProxies to use RetryUtils. Contributed by Arun C Murthy (Revision 1379743)

Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379743
Files :

• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java

Integrated in Hadoop-Common-trunk-Commit #2670 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2670/)
HDFS-3871. Change NameNodeProxies to use RetryUtils. Contributed by Arun C Murthy (Revision 1379743)

Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379743
Files :

• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java

No problem.

I have committed this. Thanks, Arun!

Nic - can you pls commit the patch yourself? I don't feel quite right committing to HDFS...

The test failures and findbugs warnings are not related.

I didn't add a new test since there is an existing test which covers this already.

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543094/HDFS-3781.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

org.apache.hadoop.hdfs.TestHftpDelegationToken
org.apache.hadoop.hdfs.TestDatanodeBlockScanner
org.apache.hadoop.hdfs.TestPersistBlocks

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3124//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3124//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3124//console

This message is automatically generated.

+1 for both the trunk and the branch-1 patches.

Patch for trunk.

Patch for branch-1.