Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3853

Port MiniDFSCluster enableManagedDfsDirsRedundancy option to branch-2

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha
    • Fix Version/s: 0.23.2, 2.0.2-alpha
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      MiniDFSCluster's enabledManagedDfsDirsRedunancy flag should be ported to branch-2. Certain tests rely on it to get full coverage-- for example, TestNameNodeRecovery and TestFSEditLogLoader.

      Just to give an example, if we're using redundant edit log directories, a test like this may succeed for the wrong reasons:
      1. screw up edit log directory
      2. run recovery
      3. test that we can start NN

      With redundant edit log directories and edit log failover, step 1 is a no-op because we can just fail over to the other directory. So we're not really testing what we need to test. This was supposed to be ported over to branch-2 from trunk with the other stuff from HDFS-3049, but was not.

      1. HDFS-3049-b2.002.patch
        10 kB
        Colin Patrick McCabe

        Issue Links

          Activity

          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Eli Collins made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Target Version/s 2.2.0-alpha [ 12322472 ]
          Fix Version/s 0.23.2 [ 12319852 ]
          Fix Version/s 2.2.0-alpha [ 12322472 ]
          Resolution Fixed [ 1 ]
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Eli Collins made changes -
          Summary port enableManagedDfsDirsRedundancy to branch-2 Port MiniDFSCluster enableManagedDfsDirsRedundancy option to branch-2
          Description enabledManagedDfsDirsRedunancy should be implemented in branch-2 like it is in trunk. Certain tests rely on it to get full coverage-- for example, {{TestNameNodeRecovery}} and {{TestFSEditLogLoader}}.

          Just to give an example, if we're using redundant edit log directories, a test like this may succeed for the wrong reasons:
          1. screw up edit log directory
          2. run recovery
          3. test that we can start NN

          With redundant edit log directories and edit log failover, step 1 is a no-op because we can just fail over to the other directory. So we're not really testing what we need to test. This was supposed to be ported over to branch-2 from trunk with the other stuff from HDFS-3049, but was not.
          MiniDFSCluster's enabledManagedDfsDirsRedunancy flag should be ported to branch-2. Certain tests rely on it to get full coverage-- for example, {{TestNameNodeRecovery}} and {{TestFSEditLogLoader}}.

          Just to give an example, if we're using redundant edit log directories, a test like this may succeed for the wrong reasons:
          1. screw up edit log directory
          2. run recovery
          3. test that we can start NN

          With redundant edit log directories and edit log failover, step 1 is a no-op because we can just fail over to the other directory. So we're not really testing what we need to test. This was supposed to be ported over to branch-2 from trunk with the other stuff from HDFS-3049, but was not.
          Colin Patrick McCabe made changes -
          Link This issue blocks HDFS-3731 [ HDFS-3731 ]
          Colin Patrick McCabe made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Colin Patrick McCabe made changes -
          Description enabledManagedDfsDirsRedunancy should be implemented in branch-2 like it is in trunk. Certain tests rely on it to get full coverage-- for example, {{TestNameNodeRecovery}} and {{TestFSEditLogLoader}}. enabledManagedDfsDirsRedunancy should be implemented in branch-2 like it is in trunk. Certain tests rely on it to get full coverage-- for example, {{TestNameNodeRecovery}} and {{TestFSEditLogLoader}}.

          Just to give an example, if we're using redundant edit log directories, a test like this may succeed for the wrong reasons:
          1. screw up edit log directory
          2. run recovery
          3. test that we can start NN

          With redundant edit log directories and edit log failover, step 1 is a no-op because we can just fail over to the other directory. So we're not really testing what we need to test. This was supposed to be ported over to branch-2 from trunk with the other stuff from HDFS-3049, but was not.
          Colin Patrick McCabe made changes -
          Attachment HDFS-3049-b2.002.patch [ 12542366 ]
          Colin Patrick McCabe made changes -
          Field Original Value New Value
          Link This issue relates to HDFS-3049 [ HDFS-3049 ]
          Colin Patrick McCabe created issue -

            People

            • Assignee:
              Colin Patrick McCabe
              Reporter:
              Colin Patrick McCabe
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development