Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3853

Port MiniDFSCluster enableManagedDfsDirsRedundancy option to branch-2

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha
    • Fix Version/s: 0.23.2, 2.0.2-alpha
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      MiniDFSCluster's enabledManagedDfsDirsRedunancy flag should be ported to branch-2. Certain tests rely on it to get full coverage-- for example, TestNameNodeRecovery and TestFSEditLogLoader.

      Just to give an example, if we're using redundant edit log directories, a test like this may succeed for the wrong reasons:
      1. screw up edit log directory
      2. run recovery
      3. test that we can start NN

      With redundant edit log directories and edit log failover, step 1 is a no-op because we can just fail over to the other directory. So we're not really testing what we need to test. This was supposed to be ported over to branch-2 from trunk with the other stuff from HDFS-3049, but was not.

      1. HDFS-3049-b2.002.patch
        10 kB
        Colin Patrick McCabe

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #356 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/356/)
          HDFS-3853. Port MiniDFSCluster enableManagedDfsDirsRedundancy. Contributed by Colin Patrick McCabe (Revision 1377547)

          Result = UNSTABLE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1377547
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #356 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/356/ ) HDFS-3853 . Port MiniDFSCluster enableManagedDfsDirsRedundancy. Contributed by Colin Patrick McCabe (Revision 1377547) Result = UNSTABLE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1377547 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          Hide
          Eli Collins added a comment -

          I've committed this to branch-2 and branch-0.23. Thanks Colin.

          Show
          Eli Collins added a comment - I've committed this to branch-2 and branch-0.23. Thanks Colin.
          Hide
          Eli Collins added a comment -

          +1 looks good. Im running a full test run on branch-2 for sanity as part of HDFS-3731.

          Show
          Eli Collins added a comment - +1 looks good. Im running a full test run on branch-2 for sanity as part of HDFS-3731 .
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12542366/HDFS-3049-b2.002.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3095//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12542366/HDFS-3049-b2.002.patch against trunk revision . -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3095//console This message is automatically generated.
          Hide
          Colin Patrick McCabe added a comment -

          Tested with: TestCheckpoint,\
          TestEditLog,\
          TestNameNodeRecovery,\
          TestEditLogLoading,\
          TestNameNodeMXBean,\
          TestSaveNamespace,\
          TestSecurityTokenEditLog,\
          TestStorageDirectoryFailure,\
          TestStorageRestore,\
          TestFileJournalManager,\
          TestEditLogsDuringFailover,\
          TestEditLogTailer,\
          TestEditLogFileOutputStream

          Show
          Colin Patrick McCabe added a comment - Tested with: TestCheckpoint,\ TestEditLog,\ TestNameNodeRecovery,\ TestEditLogLoading,\ TestNameNodeMXBean,\ TestSaveNamespace,\ TestSecurityTokenEditLog,\ TestStorageDirectoryFailure,\ TestStorageRestore,\ TestFileJournalManager,\ TestEditLogsDuringFailover,\ TestEditLogTailer,\ TestEditLogFileOutputStream

            People

            • Assignee:
              Colin Patrick McCabe
              Reporter:
              Colin Patrick McCabe
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development