Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3830

test_libhdfs_threaded: use forceNewInstance

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: libhdfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      test_libhdfs_threaded should create new FileSystem instances with newInstance, to make sure that the test doesn't break because of interference between the different threads.

      1. HDFS-3830.001.patch
        0.7 kB
        Colin Patrick McCabe

        Activity

        Colin Patrick McCabe created issue -
        Colin Patrick McCabe made changes -
        Field Original Value New Value
        Attachment HDFS-3830.001.patch [ 12541813 ]
        Hide
        Colin Patrick McCabe added a comment -

        by the way, this fixes a regression introduced by HDFS-2727

        Show
        Colin Patrick McCabe added a comment - by the way, this fixes a regression introduced by HDFS-2727
        Hide
        Andy Isaacson added a comment -

        The patch LGTM. Please comment on what testing you've done with this patch and what the impact of it is. Can you reproduce the failure locally? If so, note the frequency of failure and an example command that triggers failure.

        Show
        Andy Isaacson added a comment - The patch LGTM. Please comment on what testing you've done with this patch and what the impact of it is. Can you reproduce the failure locally? If so, note the frequency of failure and an example command that triggers failure.
        Hide
        Colin Patrick McCabe added a comment -

        I tested the patch by running test_libhdfs_threaded. Before doing so, I added the jars from share/hadoop/hdfs and share/hadoop/common to my CLASSPATH. (I am working with the tarball layout here.)

        Without this patch, the test fails intermittently. The failure mode that I saw was an exception from one thread about the FileSystem being closed (because someone closed FileSystem shared by all threads, and it doesn't reference-count.)

        Show
        Colin Patrick McCabe added a comment - I tested the patch by running test_libhdfs_threaded. Before doing so, I added the jars from share/hadoop/hdfs and share/hadoop/common to my CLASSPATH. (I am working with the tarball layout here.) Without this patch, the test fails intermittently. The failure mode that I saw was an exception from one thread about the FileSystem being closed (because someone closed FileSystem shared by all threads, and it doesn't reference-count.)
        Hide
        Eli Collins added a comment -

        +1 pending jenkins

        Show
        Eli Collins added a comment - +1 pending jenkins
        Eli Collins made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hadoop Flags Reviewed [ 10343 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12541813/HDFS-3830.001.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.TestDatanodeBlockScanner

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3058//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3058//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3058//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541813/HDFS-3830.001.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestDatanodeBlockScanner +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3058//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3058//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3058//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Findbugs warning is HDFS-3837 and the test failure is unrelated.

        Show
        Eli Collins added a comment - Findbugs warning is HDFS-3837 and the test failure is unrelated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2617 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2617/)
        HDFS-3830. test_libhdfs_threaded: use forceNewInstance. Contributed by Colin Patrick McCabe (Revision 1376121)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376121
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2617 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2617/ ) HDFS-3830 . test_libhdfs_threaded: use forceNewInstance. Contributed by Colin Patrick McCabe (Revision 1376121) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376121 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2681 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2681/)
        HDFS-3830. test_libhdfs_threaded: use forceNewInstance. Contributed by Colin Patrick McCabe (Revision 1376121)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376121
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2681 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2681/ ) HDFS-3830 . test_libhdfs_threaded: use forceNewInstance. Contributed by Colin Patrick McCabe (Revision 1376121) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376121 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
        Hide
        Eli Collins added a comment -

        I've committed this and merged to branch-2. Thanks Colin.

        Show
        Eli Collins added a comment - I've committed this and merged to branch-2. Thanks Colin.
        Eli Collins made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Target Version/s 2.2.0-alpha [ 12322472 ]
        Fix Version/s 2.2.0-alpha [ 12322472 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2647 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2647/)
        HDFS-3830. test_libhdfs_threaded: use forceNewInstance. Contributed by Colin Patrick McCabe (Revision 1376121)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376121
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2647 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2647/ ) HDFS-3830 . test_libhdfs_threaded: use forceNewInstance. Contributed by Colin Patrick McCabe (Revision 1376121) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376121 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1143 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1143/)
        HDFS-3830. test_libhdfs_threaded: use forceNewInstance. Contributed by Colin Patrick McCabe (Revision 1376121)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376121
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1143 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1143/ ) HDFS-3830 . test_libhdfs_threaded: use forceNewInstance. Contributed by Colin Patrick McCabe (Revision 1376121) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376121 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1175 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1175/)
        HDFS-3830. test_libhdfs_threaded: use forceNewInstance. Contributed by Colin Patrick McCabe (Revision 1376121)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376121
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1175 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1175/ ) HDFS-3830 . test_libhdfs_threaded: use forceNewInstance. Contributed by Colin Patrick McCabe (Revision 1376121) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376121 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        19m 22s 1 Eli Collins 21/Aug/12 22:13
        Patch Available Patch Available Resolved Resolved
        19h 26m 1 Eli Collins 22/Aug/12 17:39
        Resolved Resolved Closed Closed
        50d 1h 6m 1 Arun C Murthy 11/Oct/12 18:46

          People

          • Assignee:
            Colin Patrick McCabe
            Reporter:
            Colin Patrick McCabe
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development