Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-3802

StartupOption.name in HdfsServerConstants should be final

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.2-alpha
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In HdfsServerConstants, it may be better to define StartupOption.name as final since it will not and should not be modified after initialization. For example, in NameNode.java, the printUsage function prints out multiple startup options' names. The modification/change of the StartupOption.name may cause invalid usage message. Although right now there is no methods to change/set the value of StartupOption.name, it is better to add the final keyword to make sure.

        Attachments

          Activity

            People

            • Assignee:
              jingzhao Jing Zhao
              Reporter:
              jingzhao Jing Zhao
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: