[HDFS-3802] StartupOption.name in HdfsServerConstants should be final

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.0.2-alpha
• Hadoop Flags: Reviewed
• Assignee: Jing Zhao
• Reporter: Jing Zhao
• Created: 14/Aug/12 20:52
• Updated: 11/Oct/12 17:46
• Resolved: 15/Aug/12 08:10

Description

In HdfsServerConstants, it may be better to define StartupOption.name as final since it will not and should not be modified after initialization. For example, in NameNode.java, the printUsage function prints out multiple startup options' names. The modification/change of the StartupOption.name may cause invalid usage message. Although right now there is no methods to change/set the value of StartupOption.name, it is better to add the final keyword to make sure.