Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None

      Description

      Codes implementing DataTransferProtocol are separated in DataNode, DFSClient, etc. Also, DataTransferProtocol only define constants but not methods.

      1. hdfs377_20090622.patch
        29 kB
        Tsz Wo Nicholas Sze
      2. 6047_20090618b.patch
        29 kB
        Tsz Wo Nicholas Sze
      3. 6047_20090618.patch
        29 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Hide
          Tsz Wo Nicholas Sze added a comment -

          6047_20090618.patch: move serialization codes to DataTransferProtocol

          Show
          Tsz Wo Nicholas Sze added a comment - 6047_20090618.patch: move serialization codes to DataTransferProtocol
          Hide
          Suresh Srinivas added a comment -
          1. It would be good to move all the code from DataXceiver.run() that reads operations and the switch statement to DataTransferProtocol.Receiver and just call right opXXX() method implemented by subclasses
          2. DataTransferProtocol.opBlockCheckSum() calls opCopyBlock() instead of opBlockCheckSum()
          Show
          Suresh Srinivas added a comment - It would be good to move all the code from DataXceiver.run() that reads operations and the switch statement to DataTransferProtocol.Receiver and just call right opXXX() method implemented by subclasses DataTransferProtocol.opBlockCheckSum() calls opCopyBlock() instead of opBlockCheckSum()
          Hide
          Tsz Wo Nicholas Sze added a comment -

          6047_20090618b.patch:

          > 1. It would be good to move all the code from DataXceiver.run() that reads operations and the switch statement to DataTransferProtocol.Receiver and just call right opXXX() method implemented by subclasses
          This is a good suggestion. I tried doing it before. It requires some logic changes. I would like to keep this a copy-and-paste patch. Let do it in a separated jira.

          > 2. DataTransferProtocol.opBlockCheckSum() calls opCopyBlock() instead of opBlockCheckSum()
          Good catch.

          Thank you for the comments, Suresh.

          Show
          Tsz Wo Nicholas Sze added a comment - 6047_20090618b.patch: > 1. It would be good to move all the code from DataXceiver.run() that reads operations and the switch statement to DataTransferProtocol.Receiver and just call right opXXX() method implemented by subclasses This is a good suggestion. I tried doing it before. It requires some logic changes. I would like to keep this a copy-and-paste patch. Let do it in a separated jira. > 2. DataTransferProtocol.opBlockCheckSum() calls opCopyBlock() instead of opBlockCheckSum() Good catch. Thank you for the comments, Suresh.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          hdfs377_20090622.patch: updated with the project split.

          Show
          Tsz Wo Nicholas Sze added a comment - hdfs377_20090622.patch: updated with the project split.
          Hide
          Suresh Srinivas added a comment -

          +1, patch looks good

          Show
          Suresh Srinivas added a comment - +1, patch looks good
          Hide
          Tsz Wo Nicholas Sze added a comment -
               [exec] -1 overall.
               [exec]
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec]
               [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
               [exec]                         Please justify why no tests are needed for this patch.
               [exec]
               [exec]     -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.
               [exec]
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec]
               [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
               [exec]
               [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
          

          The javadoc warnings are not introduced by the patch. See HDFS-440.

          Show
          Tsz Wo Nicholas Sze added a comment - [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. The javadoc warnings are not introduced by the patch. See HDFS-440 .
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Ran unit tests locally. TestFTPFileSystem failed but the test is not related. See HDFS-441.

          Show
          Tsz Wo Nicholas Sze added a comment - Ran unit tests locally. TestFTPFileSystem failed but the test is not related. See HDFS-441 .
          Hide
          Tsz Wo Nicholas Sze added a comment -

          This is a code refactoring. No new tests added.

          Show
          Tsz Wo Nicholas Sze added a comment - This is a code refactoring. No new tests added.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this.

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          > > 1. It would be good to move all the code from DataXceiver.run() that reads operations and the switch statement to DataTransferProtocol.Receiver and just call right opXXX() method implemented by subclasses
          > This is a good suggestion. I tried doing it before. It requires some logic changes. I would like to keep this a copy-and-paste patch. Let do it in a separated jira.

          Created HDFS-524.

          Show
          Tsz Wo Nicholas Sze added a comment - > > 1. It would be good to move all the code from DataXceiver.run() that reads operations and the switch statement to DataTransferProtocol.Receiver and just call right opXXX() method implemented by subclasses > This is a good suggestion. I tried doing it before. It requires some logic changes. I would like to keep this a copy-and-paste patch. Let do it in a separated jira. Created HDFS-524 .

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development