Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3760

primitiveCreate is a write, not a read

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: hdfs-client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      DistributedFileSystem.java:
      
      246   protected HdfsDataOutputStream primitiveCreate(Path f,
      247     FsPermission absolutePermission, EnumSet<CreateFlag> flag, int bufferSize,
      248     short replication, long blockSize, Progressable progress,
      249     int bytesPerChecksum) throws IOException {
      250     statistics.incrementReadOps(1);
      

      A create (whether primitive or not) is a write operation, not a read operation.

      1. hdfs-3760.txt
        1 kB
        Andy Isaacson

        Activity

        Andy Isaacson created issue -
        Hide
        Andy Isaacson added a comment -

        I reviewed the rest of the statistics.incrememt...Ops() in DistributedFileSystem.java and they all look right.

        Show
        Andy Isaacson added a comment - I reviewed the rest of the statistics.incrememt...Ops() in DistributedFileSystem.java and they all look right.
        Andy Isaacson made changes -
        Field Original Value New Value
        Attachment hdfs-3760.txt [ 12539094 ]
        Andy Isaacson made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Todd Lipcon added a comment -

        +1 pending jenkins

        Show
        Todd Lipcon added a comment - +1 pending jenkins
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12539094/hdfs-3760.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2949//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2949//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539094/hdfs-3760.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2949//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2949//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        I've just committed this to trunk and branch-2. Thanks a lot for the contribution, Andy.

        Show
        Aaron T. Myers added a comment - I've just committed this to trunk and branch-2. Thanks a lot for the contribution, Andy.
        Aaron T. Myers made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 2.2.0-alpha [ 12322472 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2627 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2627/)
        HDFS-3760. primitiveCreate is a write, not a read. Contributed by Andy Isaacson. (Revision 1370649)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370649
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2627 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2627/ ) HDFS-3760 . primitiveCreate is a write, not a read. Contributed by Andy Isaacson. (Revision 1370649) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370649 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2562 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2562/)
        HDFS-3760. primitiveCreate is a write, not a read. Contributed by Andy Isaacson. (Revision 1370649)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370649
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2562 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2562/ ) HDFS-3760 . primitiveCreate is a write, not a read. Contributed by Andy Isaacson. (Revision 1370649) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370649 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2581 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2581/)
        HDFS-3760. primitiveCreate is a write, not a read. Contributed by Andy Isaacson. (Revision 1370649)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370649
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2581 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2581/ ) HDFS-3760 . primitiveCreate is a write, not a read. Contributed by Andy Isaacson. (Revision 1370649) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370649 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1129 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1129/)
        HDFS-3760. primitiveCreate is a write, not a read. Contributed by Andy Isaacson. (Revision 1370649)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370649
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1129 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1129/ ) HDFS-3760 . primitiveCreate is a write, not a read. Contributed by Andy Isaacson. (Revision 1370649) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370649 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1161 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1161/)
        HDFS-3760. primitiveCreate is a write, not a read. Contributed by Andy Isaacson. (Revision 1370649)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370649
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1161 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1161/ ) HDFS-3760 . primitiveCreate is a write, not a read. Contributed by Andy Isaacson. (Revision 1370649) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370649 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        4m 2s 1 Andy Isaacson 03/Aug/12 21:42
        Patch Available Patch Available Resolved Resolved
        4d 6h 13m 1 Aaron T. Myers 08/Aug/12 03:55
        Resolved Resolved Closed Closed
        64d 14h 50m 1 Arun C Murthy 11/Oct/12 18:46

          People

          • Assignee:
            Andy Isaacson
            Reporter:
            Andy Isaacson
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development