Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3732

fuse_dfs: incorrect configuration value checked for connection expiry timer period

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.1-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: fuse-dfs
    • Labels:
      None

      Description

      In fuse_dfs, we check an incorrect hdfs configuration value checked for the connection expiry timer period.

      gTimerPeriod = FUSE_CONN_DEFAULT_TIMER_PERIOD;
      ret = hdfsConfGetInt(HADOOP_FUSE_CONNECTION_TIMEOUT, &gTimerPeriod);
      if (ret) {
        fprintf(stderr, "Unable to determine the configured value for %s.",
              HADOOP_FUSE_TIMER_PERIOD);
        return -EINVAL
      }
      

      We should be checking HADOOP_FUSE_TIMER_PERIOD.

      1. HDFS-3732.001.patch
        0.7 kB
        Colin Patrick McCabe

        Activity

        Colin Patrick McCabe created issue -
        Colin Patrick McCabe made changes -
        Field Original Value New Value
        Project Hadoop Map/Reduce [ 12310941 ] Hadoop HDFS [ 12310942 ]
        Key MAPREDUCE-4489 HDFS-3732
        Colin Patrick McCabe made changes -
        Affects Version/s 2.0.1-alpha [ 12322465 ]
        Target Version/s 2.0.1-alpha [ 12322465 ]
        Colin Patrick McCabe made changes -
        Attachment HDFS-3732.001.patch [ 12538091 ]
        Colin Patrick McCabe made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Aaron T. Myers added a comment -

        +1 pending Jenkins.

        Show
        Aaron T. Myers added a comment - +1 pending Jenkins.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12538091/HDFS-3732.001.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2916//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2916//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12538091/HDFS-3732.001.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2916//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2916//console This message is automatically generated.
        Aaron T. Myers made changes -
        Target Version/s 2.0.1-alpha [ 12322465 ] 2.2.0-alpha [ 12322472 ]
        Component/s fuse-dfs [ 12312913 ]
        Hide
        Aaron T. Myers added a comment -

        I've just committed this to trunk and branch-2.

        Thanks a lot for the contribution, Colin.

        Show
        Aaron T. Myers added a comment - I've just committed this to trunk and branch-2. Thanks a lot for the contribution, Colin.
        Aaron T. Myers made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 2.2.0-alpha [ 12322472 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2533 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2533/)
        HDFS-3732. fuse_dfs: incorrect configuration value checked for connection expiry timer period. Contributed by Colin Patrick McCabe. (Revision 1367199)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367199
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_connect.c
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2533 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2533/ ) HDFS-3732 . fuse_dfs: incorrect configuration value checked for connection expiry timer period. Contributed by Colin Patrick McCabe. (Revision 1367199) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367199 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_connect.c
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2597 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2597/)
        HDFS-3732. fuse_dfs: incorrect configuration value checked for connection expiry timer period. Contributed by Colin Patrick McCabe. (Revision 1367199)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367199
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_connect.c
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2597 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2597/ ) HDFS-3732 . fuse_dfs: incorrect configuration value checked for connection expiry timer period. Contributed by Colin Patrick McCabe. (Revision 1367199) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367199 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_connect.c
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2553 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2553/)
        HDFS-3732. fuse_dfs: incorrect configuration value checked for connection expiry timer period. Contributed by Colin Patrick McCabe. (Revision 1367199)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367199
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_connect.c
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2553 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2553/ ) HDFS-3732 . fuse_dfs: incorrect configuration value checked for connection expiry timer period. Contributed by Colin Patrick McCabe. (Revision 1367199) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367199 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_connect.c
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        3m 51s 1 Colin Patrick McCabe 26/Jul/12 23:17
        Patch Available Patch Available Resolved Resolved
        3d 19h 51m 1 Aaron T. Myers 30/Jul/12 19:08
        Resolved Resolved Closed Closed
        72d 23h 37m 1 Arun C Murthy 11/Oct/12 18:46

          People

          • Assignee:
            Colin Patrick McCabe
            Reporter:
            Colin Patrick McCabe
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development