[HDFS-3683] Edit log replay progress indicator shows >100% complete

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0-alpha
• Fix Version/s: 2.0.2-alpha
• Component/s: namenode
• Target Version/s: 2.0.2-alpha
• Hadoop Flags: Reviewed
• Assignee: Plamen Jeliazkov
• Reporter: Todd Lipcon
• Created: 19/Jul/12 17:42
• Updated: 11/Oct/12 17:46
• Resolved: 26/Aug/12 00:32

Description

When loading a large edit log, the NameNode prints a percentage-complete progress indicator:

              int percent = Math.round((float)lastAppliedTxId / numTxns * 100);
              LOG.info("replaying edit log: " + lastAppliedTxId + "/" + numTxns
                  + " transactions completed. (" + percent + "%)");

But the percentage is calculated incorrectly, since it divides the transaction ID by the number of expected transactions. This only works when starting at txid 1. (eg if we are loading 1000 transaction starting at txid 1000, the indicator will start at 100% and go to 200%)