Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3663

MiniDFSCluster should capture the code path that led to the first ExitException

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The MiniDFSCluster should capture the code path that led to the first ExitException being thrown since it's now always available in the logs when an ExitException was unexpected, eg HDFS-3642.

      1. hdfs-3663.txt
        3 kB
        Eli Collins

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1138 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1138/)
        HDFS-3663. MiniDFSCluster should capture the code path that led to the first ExitException. Contributed by Eli Collins (Revision 1361775)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361775
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ExitUtil.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1138 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1138/ ) HDFS-3663 . MiniDFSCluster should capture the code path that led to the first ExitException. Contributed by Eli Collins (Revision 1361775) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361775 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ExitUtil.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1105 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1105/)
        HDFS-3663. MiniDFSCluster should capture the code path that led to the first ExitException. Contributed by Eli Collins (Revision 1361775)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361775
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ExitUtil.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1105 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1105/ ) HDFS-3663 . MiniDFSCluster should capture the code path that led to the first ExitException. Contributed by Eli Collins (Revision 1361775) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361775 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ExitUtil.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2494 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2494/)
        HDFS-3663. MiniDFSCluster should capture the code path that led to the first ExitException. Contributed by Eli Collins (Revision 1361775)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361775
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ExitUtil.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2494 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2494/ ) HDFS-3663 . MiniDFSCluster should capture the code path that led to the first ExitException. Contributed by Eli Collins (Revision 1361775) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361775 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ExitUtil.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2474 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2474/)
        HDFS-3663. MiniDFSCluster should capture the code path that led to the first ExitException. Contributed by Eli Collins (Revision 1361775)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361775
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ExitUtil.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2474 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2474/ ) HDFS-3663 . MiniDFSCluster should capture the code path that led to the first ExitException. Contributed by Eli Collins (Revision 1361775) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361775 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ExitUtil.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2539 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2539/)
        HDFS-3663. MiniDFSCluster should capture the code path that led to the first ExitException. Contributed by Eli Collins (Revision 1361775)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361775
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ExitUtil.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2539 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2539/ ) HDFS-3663 . MiniDFSCluster should capture the code path that led to the first ExitException. Contributed by Eli Collins (Revision 1361775) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361775 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ExitUtil.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        Hide
        Eli Collins added a comment -

        Thanks for the review ATM. I've committed this and merged to branch-2.

        Show
        Eli Collins added a comment - Thanks for the review ATM. I've committed this and merged to branch-2.
        Hide
        Aaron T. Myers added a comment -

        +1, the patch looks good to me.

        Show
        Aaron T. Myers added a comment - +1, the patch looks good to me.
        Hide
        Eli Collins added a comment -

        Test failures are unrelated. TestZKFailoverController is HADOOP-8591. TestTfile* is HADOOP-8537. Filed HDFS-3664 for the TestPersistBlocks NPE.

        Show
        Eli Collins added a comment - Test failures are unrelated. TestZKFailoverController is HADOOP-8591 . TestTfile* is HADOOP-8537 . Filed HDFS-3664 for the TestPersistBlocks NPE.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12536512/hdfs-3663.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.ha.TestZKFailoverController
        org.apache.hadoop.io.file.tfile.TestTFileByteArrays
        org.apache.hadoop.io.file.tfile.TestTFileJClassComparatorByteArrays
        org.apache.hadoop.hdfs.TestPersistBlocks

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2825//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2825//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12536512/hdfs-3663.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.ha.TestZKFailoverController org.apache.hadoop.io.file.tfile.TestTFileByteArrays org.apache.hadoop.io.file.tfile.TestTFileJClassComparatorByteArrays org.apache.hadoop.hdfs.TestPersistBlocks +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2825//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2825//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Patch attached.

        Show
        Eli Collins added a comment - Patch attached.

          People

          • Assignee:
            Eli Collins
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development