Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3628

The dfsadmin -setBalancerBandwidth command on branch-1 does not check for superuser privileges

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.20.205.0
    • Fix Version/s: 1.2.0
    • Component/s: datanode, namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The changes from HDFS-2202 for 0.20.x/1.x failed to add in a checkSuperuserPrivilege();, and hence any user (not admins alone) can reset the balancer bandwidth across the cluster if they wished to.

        Issue Links

          Activity

          Matt Foley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop 1.2.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.
          Harsh J made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Target Version/s 1.2.0 [ 12321657 ]
          Fix Version/s 1.2.0 [ 12321657 ]
          Resolution Fixed [ 1 ]
          Hide
          Harsh J added a comment -

          Committed to branch-1. Thanks Eli.

          Show
          Harsh J added a comment - Committed to branch-1. Thanks Eli.
          Hide
          Eli Collins added a comment -

          +1 Since this is a 1-liner no test-patch is necessary.

          Show
          Eli Collins added a comment - +1 Since this is a 1-liner no test-patch is necessary.
          Harsh J made changes -
          Description The changes from HDFS-2202 failed to add in a checkSuperuserPrivilege();, and hence any user (not admins alone) can reset the balancer bandwidth across the cluster if they wished to. The changes from HDFS-2202 for 0.20.x/1.x failed to add in a checkSuperuserPrivilege();, and hence any user (not admins alone) can reset the balancer bandwidth across the cluster if they wished to.
          Hide
          Harsh J added a comment -

          (Change in the patch is akin to refreshNodes in FSNameSystem. Functions in the same way, so no tests are required. Patch compiles branch-1 build locally, but let me know if test-patch is still required…)

          Show
          Harsh J added a comment - (Change in the patch is akin to refreshNodes in FSNameSystem. Functions in the same way, so no tests are required. Patch compiles branch-1 build locally, but let me know if test-patch is still required…)
          Harsh J made changes -
          Summary The dfsadmin -setBalancerBandwidth command does not check for superuser privileges The dfsadmin -setBalancerBandwidth command on branch-1 does not check for superuser privileges
          Harsh J made changes -
          Link This issue is superceded by HDFS-3331 [ HDFS-3331 ]
          Hide
          Harsh J added a comment -

          For trunk it was handled via HDFS-3331

          Show
          Harsh J added a comment - For trunk it was handled via HDFS-3331
          Harsh J made changes -
          Attachment HDFS-3628.patch [ 12535910 ]
          Hide
          Harsh J added a comment -

          Patch for branch-1 that adds in the super-user privileges check akin to trunk.

          Show
          Harsh J added a comment - Patch for branch-1 that adds in the super-user privileges check akin to trunk.
          Harsh J made changes -
          Affects Version/s 0.23.0 [ 12315571 ]
          Target Version/s 1.2.0, 2.0.1-alpha [ 12321657, 12321440 ] 1.2.0 [ 12321657 ]
          Hide
          Harsh J added a comment -

          Upon further research, this affects only the branch-1 code. Not an issue for trunk.

          Show
          Harsh J added a comment - Upon further research, this affects only the branch-1 code. Not an issue for trunk.
          Harsh J made changes -
          Field Original Value New Value
          Issue Type Improvement [ 4 ] Bug [ 1 ]
          Target Version/s 1.2.0, 2.0.1-alpha [ 12321657, 12321440 ]
          Harsh J created issue -

            People

            • Assignee:
              Harsh J
              Reporter:
              Harsh J
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development