Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3613

GSet prints some INFO level values, which aren't really very useful to all

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: namenode
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The following has long been seen in NameNode but I have never seen it being valued by anyone other than a HDFS developer:

      12/07/08 20:00:22 INFO util.GSet: VM type       = 64-bit
      12/07/08 20:00:22 INFO util.GSet: 2% max memory = 19.75 MB
      12/07/08 20:00:22 INFO util.GSet: capacity      = 2^21 = 2097152 entries
      12/07/08 20:00:22 INFO util.GSet: recommended=2097152, actual=2097152
      

      Lets switch it down to DEBUG.

      1. hdfs-3613.patch
        2 kB
        Andrew Wang
      2. hdfs-3613-2.patch
        2 kB
        Andrew Wang

        Activity

        Hide
        Andrew Wang added a comment -

        That logging is split across two classes, changed both to DEBUG. Tested by adding the following lines to log4j.properties, seeing them at debug on namenode startup:

        log4j.logger.org.apache.hadoop.hdfs.server.blockmanagement=DEBUG
        log4j.logger.org.apache.hadoop.hdfs.util=DEBUG

        Show
        Andrew Wang added a comment - That logging is split across two classes, changed both to DEBUG. Tested by adding the following lines to log4j.properties, seeing them at debug on namenode startup: log4j.logger.org.apache.hadoop.hdfs.server.blockmanagement=DEBUG log4j.logger.org.apache.hadoop.hdfs.util=DEBUG
        Hide
        Harsh J added a comment -

        Thanks Andrew!

        This looks good, just one nit: Please wrap all LOG.debug performing lines under an {{if (LOG.isDebugEnabled()) { }}} check, to stay consistent with the rest of the code base (it is for a performance reason, check out HADOOP-6884 if you want to have some historical reading).

        Show
        Harsh J added a comment - Thanks Andrew! This looks good, just one nit: Please wrap all LOG.debug performing lines under an {{if (LOG.isDebugEnabled()) { }}} check, to stay consistent with the rest of the code base (it is for a performance reason, check out HADOOP-6884 if you want to have some historical reading).
        Hide
        Andrew Wang added a comment -

        Added the if check for the logging.

        Show
        Andrew Wang added a comment - Added the if check for the logging.
        Hide
        Aaron T. Myers added a comment -

        Marking PA for Andrew so that Jenkins runs.

        Show
        Aaron T. Myers added a comment - Marking PA for Andrew so that Jenkins runs.
        Hide
        Harsh J added a comment -

        Thanks Andrew and Aaron.

        +1 pending Jenkins.

        Show
        Harsh J added a comment - Thanks Andrew and Aaron. +1 pending Jenkins.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12535914/hdfs-3613-2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2777//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2777//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2777//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12535914/hdfs-3613-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2777//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2777//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2777//console This message is automatically generated.
        Hide
        Andrew Wang added a comment -

        No tests since this is trivial, and was tested manually. Findbugs seems unrelated; talks about synchronization in security code.

        Show
        Andrew Wang added a comment - No tests since this is trivial, and was tested manually. Findbugs seems unrelated; talks about synchronization in security code.
        Hide
        Harsh J added a comment -

        Committed to branch-2 and trunk. Thank you for your contributions Andrew!

        Show
        Harsh J added a comment - Committed to branch-2 and trunk. Thank you for your contributions Andrew!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2463 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2463/)
        HDFS-3613. GSet prints some INFO level values, which aren't really very useful to all. Contributed by Andrew Wang. (harsh) (Revision 1359999)

        Result = FAILURE
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359999
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/LightWeightGSet.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2463 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2463/ ) HDFS-3613 . GSet prints some INFO level values, which aren't really very useful to all. Contributed by Andrew Wang. (harsh) (Revision 1359999) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359999 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/LightWeightGSet.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2445 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2445/)
        HDFS-3613. GSet prints some INFO level values, which aren't really very useful to all. Contributed by Andrew Wang. (harsh) (Revision 1359999)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359999
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/LightWeightGSet.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2445 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2445/ ) HDFS-3613 . GSet prints some INFO level values, which aren't really very useful to all. Contributed by Andrew Wang. (harsh) (Revision 1359999) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359999 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/LightWeightGSet.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2512 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2512/)
        HDFS-3613. GSet prints some INFO level values, which aren't really very useful to all. Contributed by Andrew Wang. (harsh) (Revision 1359999)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359999
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/LightWeightGSet.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2512 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2512/ ) HDFS-3613 . GSet prints some INFO level values, which aren't really very useful to all. Contributed by Andrew Wang. (harsh) (Revision 1359999) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359999 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/LightWeightGSet.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1100 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1100/)
        HDFS-3613. GSet prints some INFO level values, which aren't really very useful to all. Contributed by Andrew Wang. (harsh) (Revision 1359999)

        Result = FAILURE
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359999
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/LightWeightGSet.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1100 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1100/ ) HDFS-3613 . GSet prints some INFO level values, which aren't really very useful to all. Contributed by Andrew Wang. (harsh) (Revision 1359999) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359999 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/LightWeightGSet.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1133 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1133/)
        HDFS-3613. GSet prints some INFO level values, which aren't really very useful to all. Contributed by Andrew Wang. (harsh) (Revision 1359999)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359999
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/LightWeightGSet.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1133 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1133/ ) HDFS-3613 . GSet prints some INFO level values, which aren't really very useful to all. Contributed by Andrew Wang. (harsh) (Revision 1359999) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359999 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/LightWeightGSet.java

          People

          • Assignee:
            Andrew Wang
            Reporter:
            Harsh J
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development