Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3603

Decouple TestHDFSTrash from TestTrash

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.3, 2.0.0-alpha
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      TestHDFSTrash is failing pretty regularly during test builds.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1h 9m 1 Jason Lowe 05/Jul/12 22:20
        Patch Available Patch Available Resolved Resolved
        3d 18h 39m 1 Daryn Sharp 09/Jul/12 17:00
        Resolved Resolved Closed Closed
        94d 1h 45m 1 Arun C Murthy 11/Oct/12 18:46
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Arun C Murthy made changes -
        Affects Version/s 2.0.0-alpha [ 12320353 ]
        Affects Version/s 2.1.0-alpha [ 12321440 ]
        Arun C Murthy made changes -
        Fix Version/s 2.0.2-alpha [ 12322472 ]
        Fix Version/s 2.1.0-alpha [ 12321440 ]
        Suresh Srinivas made changes -
        Priority Blocker [ 1 ] Major [ 3 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2441 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2441/)
        HDFS-3603. Decouple TestHDFSTrash from TestTrash. Contributed by Jason Lowe (Revision 1358804)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358804
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2441 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2441/ ) HDFS-3603 . Decouple TestHDFSTrash from TestTrash. Contributed by Jason Lowe (Revision 1358804) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358804 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2508 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2508/)
        HDFS-3603. Decouple TestHDFSTrash from TestTrash. Contributed by Jason Lowe (Revision 1358804)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358804
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2508 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2508/ ) HDFS-3603 . Decouple TestHDFSTrash from TestTrash. Contributed by Jason Lowe (Revision 1358804) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358804 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #309 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/309/)
        svn merge -c 1358804 FIXES: HDFS-3603. Decouple TestHDFSTrash from TestTrash. Contributed by Jason Lowe (Revision 1359233)

        Result = SUCCESS
        daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359233
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #309 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/309/ ) svn merge -c 1358804 FIXES: HDFS-3603 . Decouple TestHDFSTrash from TestTrash. Contributed by Jason Lowe (Revision 1359233) Result = SUCCESS daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359233 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
        Daryn Sharp made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.23.3 [ 12320052 ]
        Resolution Fixed [ 1 ]
        Hide
        Daryn Sharp added a comment -

        I've committed this to branch-23 as well.

        Show
        Daryn Sharp added a comment - I've committed this to branch-23 as well.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1131 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1131/)
        HDFS-3603. Decouple TestHDFSTrash from TestTrash. Contributed by Jason Lowe (Revision 1358804)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358804
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1131 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1131/ ) HDFS-3603 . Decouple TestHDFSTrash from TestTrash. Contributed by Jason Lowe (Revision 1358804) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358804 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2502 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2502/)
        HDFS-3603. Decouple TestHDFSTrash from TestTrash. Contributed by Jason Lowe (Revision 1358804)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358804
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2502 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2502/ ) HDFS-3603 . Decouple TestHDFSTrash from TestTrash. Contributed by Jason Lowe (Revision 1358804) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358804 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2434 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2434/)
        HDFS-3603. Decouple TestHDFSTrash from TestTrash. Contributed by Jason Lowe (Revision 1358804)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358804
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2434 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2434/ ) HDFS-3603 . Decouple TestHDFSTrash from TestTrash. Contributed by Jason Lowe (Revision 1358804) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358804 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1098 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1098/)
        HDFS-3603. Decouple TestHDFSTrash from TestTrash. Contributed by Jason Lowe (Revision 1358804)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358804
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1098 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1098/ ) HDFS-3603 . Decouple TestHDFSTrash from TestTrash. Contributed by Jason Lowe (Revision 1358804) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358804 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2451 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2451/)
        HDFS-3603. Decouple TestHDFSTrash from TestTrash. Contributed by Jason Lowe (Revision 1358804)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358804
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2451 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2451/ ) HDFS-3603 . Decouple TestHDFSTrash from TestTrash. Contributed by Jason Lowe (Revision 1358804) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358804 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
        Eli Collins made changes -
        Fix Version/s 2.0.1-alpha [ 12321440 ]
        Target Version/s 0.23.3, 2.0.1-alpha [ 12320052, 12321440 ] 0.23.3 [ 12320052 ]
        Hide
        Eli Collins added a comment -

        I've committed this to trunk and merged to branch-2.

        Show
        Eli Collins added a comment - I've committed this to trunk and merged to branch-2.
        Eli Collins made changes -
        Summary TestHDFSTrash is failing Decouple TestHDFSTrash from TestTrash
        Affects Version/s 3.0.0 [ 12320356 ]
        Target Version/s 0.23.3, 2.0.1-alpha, 3.0.0 [ 12320052, 12321440, 12320356 ] 0.23.3, 2.0.1-alpha [ 12320052, 12321440 ]
        Hide
        Eli Collins added a comment -

        +1 Decoupling these makes sense to me, and the patch looks good. We still need to push on HADOOP-7326.

        Show
        Eli Collins added a comment - +1 Decoupling these makes sense to me, and the patch looks good. We still need to push on HADOOP-7326 .
        Hide
        Kihwal Lee added a comment -

        The patch looks good. One concern I have is that some users may experience a hdfs build failure until the new common build artifacts become available.

        Show
        Kihwal Lee added a comment - The patch looks good. One concern I have is that some users may experience a hdfs build failure until the new common build artifacts become available.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12535260/HDFS-3603.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2744//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2744//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12535260/HDFS-3603.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2744//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2744//console This message is automatically generated.
        Jason Lowe made changes -
        Assignee Jason Lowe [ jlowe ]
        Jason Lowe made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Target Version/s 0.23.3, 2.0.1-alpha, 3.0.0 [ 12320052, 12321440, 12320356 ]
        Jason Lowe made changes -
        Field Original Value New Value
        Attachment HDFS-3603.patch [ 12535260 ]
        Hide
        Jason Lowe added a comment -

        Patch to update TestHDFSTrash to JUnit 4 and only execute the two test cases that TestHDFSTrash provides.

        Show
        Jason Lowe added a comment - Patch to update TestHDFSTrash to JUnit 4 and only execute the two test cases that TestHDFSTrash provides.
        Hide
        Jason Lowe added a comment -

        Failure is:

        testTrashEmptier(org.apache.hadoop.hdfs.TestHDFSTrash)  Time elapsed: 0.025 sec  <<< FAILURE!
        junit.framework.AssertionFailedError: null
                at junit.framework.Assert.fail(Assert.java:47)
                at junit.framework.Assert.assertTrue(Assert.java:20)
                at junit.framework.Assert.assertTrue(Assert.java:27)
                at org.apache.hadoop.fs.TestTrash.testTrashEmptier(TestTrash.java:536)
                at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
                at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
                at java.lang.reflect.Method.invoke(Method.java:597)
                at junit.framework.TestCase.runTest(TestCase.java:168)
                at junit.framework.TestCase.runBare(TestCase.java:134)
                at junit.framework.TestResult$1.protect(TestResult.java:110)
                at junit.framework.TestResult.runProtected(TestResult.java:128)
                at junit.framework.TestResult.run(TestResult.java:113)
                at junit.framework.TestCase.run(TestCase.java:124)
                at junit.framework.TestSuite.runTest(TestSuite.java:243)
                at junit.framework.TestSuite.run(TestSuite.java:238)
                at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
                at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
                at junit.framework.TestResult.runProtected(TestResult.java:128)
                at junit.extensions.TestSetup.run(TestSetup.java:27)
                at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
                at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
                at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
                at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
                at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
                at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
                at java.lang.reflect.Method.invoke(Method.java:597)
                at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
                at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
                at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
                at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
                at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
        

        Problem seems to have been triggered since HADOOP-8110 was integrated, although that appears to have uncovered an existing issue rather than causing it. Here's what's happening:

        • TestViewFSTrash runs and can end up leaving 4 things in the trash, like:
        $ ls ~/.Trash
        120705182754  120705182754-1  120705182754-2  Current
        
        • TestHDFSTrash runs testTrashEmptier, sees there are 4 things in the trash, and since it has found 4 checkpoints, it immediately asserts if the current trash directory listing is < 4. The 4 < 4 assert fails the test.
        • If there are fewer than 4 things in the trash when testTrashEmptier starts, the test will pass. If there are more than 4 things in the trash when testTrashEmptier starts then it can hang, see HADOOP-7326.

        The saddest thing is TestHDFSTrash isn't even testing HDFS when it runs testTrashEmptier, because that test simply uses a local filesystem config. TestHDFSTrash is picking it up because it inherits from TestTrash which contains that test case.

        Show
        Jason Lowe added a comment - Failure is: testTrashEmptier(org.apache.hadoop.hdfs.TestHDFSTrash) Time elapsed: 0.025 sec <<< FAILURE! junit.framework.AssertionFailedError: null at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at junit.framework.Assert.assertTrue(Assert.java:27) at org.apache.hadoop.fs.TestTrash.testTrashEmptier(TestTrash.java:536) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at junit.framework.TestCase.runTest(TestCase.java:168) at junit.framework.TestCase.runBare(TestCase.java:134) at junit.framework.TestResult$1.protect(TestResult.java:110) at junit.framework.TestResult.runProtected(TestResult.java:128) at junit.framework.TestResult.run(TestResult.java:113) at junit.framework.TestCase.run(TestCase.java:124) at junit.framework.TestSuite.runTest(TestSuite.java:243) at junit.framework.TestSuite.run(TestSuite.java:238) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:23) at junit.framework.TestResult.runProtected(TestResult.java:128) at junit.extensions.TestSetup.run(TestSetup.java:27) at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74) Problem seems to have been triggered since HADOOP-8110 was integrated, although that appears to have uncovered an existing issue rather than causing it. Here's what's happening: TestViewFSTrash runs and can end up leaving 4 things in the trash, like: $ ls ~/.Trash 120705182754 120705182754-1 120705182754-2 Current TestHDFSTrash runs testTrashEmptier, sees there are 4 things in the trash, and since it has found 4 checkpoints, it immediately asserts if the current trash directory listing is < 4. The 4 < 4 assert fails the test. If there are fewer than 4 things in the trash when testTrashEmptier starts, the test will pass. If there are more than 4 things in the trash when testTrashEmptier starts then it can hang, see HADOOP-7326 . The saddest thing is TestHDFSTrash isn't even testing HDFS when it runs testTrashEmptier, because that test simply uses a local filesystem config. TestHDFSTrash is picking it up because it inherits from TestTrash which contains that test case.
        Jason Lowe created issue -

          People

          • Assignee:
            Jason Lowe
            Reporter:
            Jason Lowe
          • Votes:
            0 Vote for this issue
            Watchers:
            11 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development