Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3507

DFS#isInSafeMode needs to execute only on Active NameNode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha
    • Fix Version/s: 2.0.3-alpha
    • Component/s: ha
    • Labels:
      None

      Description

      Currently DFS#isInSafeMode is not Checking for the NN state. It can be executed on any of the NNs.

      But HBase will use this API to check for the NN safemode before starting up its service.

      If first NN configured is in standby then DFS#isInSafeMode will check standby NNs safemode but hbase want state of Active NN.

      1. HDFS-3507.patch
        28 kB
        Vinayakumar B
      2. HDFS-3507.patch
        28 kB
        Vinayakumar B
      3. HDFS-3507.patch
        26 kB
        Vinayakumar B
      4. HDFS-3507.patch
        26 kB
        Vinayakumar B

        Issue Links

          Activity

          Hide
          Vinayakumar B added a comment -

          Adding to above description...
          Since standby will not do any write operations, DFS#isInSafeMode check on standby will not add value.

          StandBy can enter safemode in following cases
          1. Waiting for the block report from datanodes
          2. And If the machine resources are low. If HDFS-2914 committed, this standby will not enter because of resources unavailability.

          Currently DFS#isInSafeMode() will use ClientProtocol.setSafeMode(..) itself which is currently UNCHECKED.

            @Override // ClientProtocol
            public boolean setSafeMode(SafeModeAction action) throws IOException {
              namesystem.checkOperation(OperationCategory.UNCHECKED);
              return namesystem.setSafeMode(action);
            }

          If ClientProtocol.setSafeMode restricted to only Active NN, then it will impact the DFSAdmin -safemode command also.

          I feel there can be two ways to solve this.

          1. Add one more API isInSafeMode to ClientProtocol which is restricted to only ActiveNN.
          2. Restrict setSafeMode API itself to ANN, and hence restricting DFSAdmin -safemode command to only ANN.

          I choose option 1, to leave the DFSAdmin -safemode behaviour as it is.

          Show
          Vinayakumar B added a comment - Adding to above description... Since standby will not do any write operations, DFS#isInSafeMode check on standby will not add value. StandBy can enter safemode in following cases 1. Waiting for the block report from datanodes 2. And If the machine resources are low. If HDFS-2914 committed, this standby will not enter because of resources unavailability. Currently DFS#isInSafeMode() will use ClientProtocol.setSafeMode(..) itself which is currently UNCHECKED. @Override // ClientProtocol public boolean setSafeMode(SafeModeAction action) throws IOException { namesystem.checkOperation(OperationCategory.UNCHECKED); return namesystem.setSafeMode(action); } If ClientProtocol.setSafeMode restricted to only Active NN, then it will impact the DFSAdmin -safemode command also. I feel there can be two ways to solve this. 1. Add one more API isInSafeMode to ClientProtocol which is restricted to only ActiveNN. 2. Restrict setSafeMode API itself to ANN, and hence restricting DFSAdmin -safemode command to only ANN. I choose option 1, to leave the DFSAdmin -safemode behaviour as it is.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          For option 1, we may simply add a parameter to setSafeMode(..), say isUnchecked, instead of adding a new method to the protocol.

          Show
          Tsz Wo Nicholas Sze added a comment - For option 1, we may simply add a parameter to setSafeMode(..), say isUnchecked, instead of adding a new method to the protocol.
          Hide
          Vinayakumar B added a comment -

          Hi Nicholas,

          For option 1, we may simply add a parameter to setSafeMode(..), say isUnchecked, instead of adding a new method to the protocol.

          Your suggestion looks good.

          But I am concerned that need to change lot of places if we add one more parameter to the setSafemeode(..)

          Show
          Vinayakumar B added a comment - Hi Nicholas, For option 1, we may simply add a parameter to setSafeMode(..), say isUnchecked, instead of adding a new method to the protocol. Your suggestion looks good. But I am concerned that need to change lot of places if we add one more parameter to the setSafemeode(..)
          Hide
          Vinayakumar B added a comment -

          Attaching the patch with changes as suggested by nicholas

          Show
          Vinayakumar B added a comment - Attaching the patch with changes as suggested by nicholas
          Hide
          Vinayakumar B added a comment -

          Submitting patch again, so that Hadoop QA can catch.

          Show
          Vinayakumar B added a comment - Submitting patch again, so that Hadoop QA can catch.
          Hide
          Aaron T. Myers added a comment -

          Hi Vinay, merely marking a patch open/PA again won't trigger another build. You either need to attach another file (could have the same content) or get someone to kick the HDFS pre-commit build. I've just done the latter for you.

          Show
          Aaron T. Myers added a comment - Hi Vinay, merely marking a patch open/PA again won't trigger another build. You either need to attach another file (could have the same content) or get someone to kick the HDFS pre-commit build. I've just done the latter for you.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12532364/HDFS-3507.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 11 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2698//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2698//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12532364/HDFS-3507.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2698//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2698//console This message is automatically generated.
          Hide
          Vinayakumar B added a comment -

          Thanks Aaron., I really did not know about it..

          Show
          Vinayakumar B added a comment - Thanks Aaron., I really did not know about it..
          Hide
          Vinayakumar B added a comment -

          Attaching the latest re-based patch

          Show
          Vinayakumar B added a comment - Attaching the latest re-based patch
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12541223/HDFS-3507.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 11 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3024//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3024//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541223/HDFS-3507.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3024//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3024//console This message is automatically generated.
          Hide
          Aaron T. Myers added a comment -

          My preference is to introduce a new isInSafeMode or getSafeMode function to the ClientProtocol, instead of parameterizing the check. I've always found it a little bizarre that a method called "setSafeMode" actually may not set anything, and may be non-mutative depending upon a parameter. I don't feel super strongly about this, though. Nicholas, is there some reason you prefer keeping this as a single method?

          Two comments on the correctness of the patch:

          1. The new parameter in the SetSafeModeRequestProto should be marked optional, defaulted to false, to maintain compatibility.
          2. Seems like the calls in DFSAdmin should be passing "true" for isChecked, so that the the active NN is used.

          Another issue related to this: I'm not super happy with the current handling of setting (not getting) safemode in an HA setup, since an admin command will only affect a single NN. Imagine the scenario where an operator runs `hdfs dfsadmin -safemode enter' and then a failure occurs of the active NN, triggering a failover. Presently, this will have the side effect of causing HDFS to leave safe mode. I think when an operator calls `safemode -enter' they usually intend to put the HDFS service into safemode, and not any particular NN. Perhaps we should make the the DFSAdmin command notice when a logical HA URI is being used, and make the appropriate RPC call to all of the NNs, instead of just one? There's some related discussion about this on HDFS-3744, where we discuss the fact that one must call `hdfs dfsadmin -refreshNodes' on both NNs in an HA setup.

          What are peoples' thoughts on this issue?

          Show
          Aaron T. Myers added a comment - My preference is to introduce a new isInSafeMode or getSafeMode function to the ClientProtocol, instead of parameterizing the check. I've always found it a little bizarre that a method called "setSafeMode" actually may not set anything, and may be non-mutative depending upon a parameter. I don't feel super strongly about this, though. Nicholas, is there some reason you prefer keeping this as a single method? Two comments on the correctness of the patch: The new parameter in the SetSafeModeRequestProto should be marked optional, defaulted to false, to maintain compatibility. Seems like the calls in DFSAdmin should be passing "true" for isChecked, so that the the active NN is used. Another issue related to this: I'm not super happy with the current handling of setting (not getting) safemode in an HA setup, since an admin command will only affect a single NN. Imagine the scenario where an operator runs `hdfs dfsadmin -safemode enter' and then a failure occurs of the active NN, triggering a failover. Presently, this will have the side effect of causing HDFS to leave safe mode. I think when an operator calls `safemode -enter' they usually intend to put the HDFS service into safemode, and not any particular NN. Perhaps we should make the the DFSAdmin command notice when a logical HA URI is being used, and make the appropriate RPC call to all of the NNs, instead of just one? There's some related discussion about this on HDFS-3744 , where we discuss the fact that one must call `hdfs dfsadmin -refreshNodes' on both NNs in an HA setup. What are peoples' thoughts on this issue?
          Hide
          Vinayakumar B added a comment -

          Thanks Aaron for your inputs.

          The new parameter in the SetSafeModeRequestProto should be marked optional, defaulted to false, to maintain compatibility

          Got it.

          Seems like the calls in DFSAdmin should be passing "true" for isChecked, so that the the active NN is used.

          I think this also similar one to HDFS-3744, may be this we can take up in separate Jira or HDFS-3744 itself. In current patch I am just passing "false" to maintain previous behaviour.

          I agree with your opinion about setting the HDFS service to safemode instead of setting it to only one NN.

          Show
          Vinayakumar B added a comment - Thanks Aaron for your inputs. The new parameter in the SetSafeModeRequestProto should be marked optional, defaulted to false, to maintain compatibility Got it. Seems like the calls in DFSAdmin should be passing "true" for isChecked, so that the the active NN is used. I think this also similar one to HDFS-3744 , may be this we can take up in separate Jira or HDFS-3744 itself. In current patch I am just passing "false" to maintain previous behaviour. I agree with your opinion about setting the HDFS service to safemode instead of setting it to only one NN.
          Hide
          Vinayakumar B added a comment -

          Hi Aaron and Nicholas,
          Any more updates required on this patch..?

          Show
          Vinayakumar B added a comment - Hi Aaron and Nicholas, Any more updates required on this patch..?
          Hide
          Tsz Wo Nicholas Sze added a comment -

          > ... Nicholas, is there some reason you prefer keeping this as a single method?

          I don't have a strong preference except for compatibility. I agree with you that the setSafeMode method is misleading.

          I took a quick look at the patch. I think it is good enough for this issue. Aaron, see if you want to review it. Or I can take another look at it in more details.

          Show
          Tsz Wo Nicholas Sze added a comment - > ... Nicholas, is there some reason you prefer keeping this as a single method? I don't have a strong preference except for compatibility. I agree with you that the setSafeMode method is misleading. I took a quick look at the patch. I think it is good enough for this issue. Aaron, see if you want to review it. Or I can take another look at it in more details.
          Hide
          Aaron T. Myers added a comment -

          The latest patch looks pretty good to me. We can address the larger points about setting the service's vs just a single NN's safemode value, and changing the ClientProtocol to have an actual isInSafeMode/getSafeMode operation in separate JIRA(s).

          One comment on the patch:

          I don't think this will actually affect the correctness of the patch, but this code makes me a little wary, since as we've discussed a setSafeMode operation is not in fact necessarily a write:

          +    OperationCategory opCategory = OperationCategory.UNCHECKED;
          +    if (isChecked) {
          +      opCategory = OperationCategory.WRITE;
          +    }
          

          I think better would be something like this:

          +    OperationCategory opCategory = OperationCategory.UNCHECKED;
          +    if (isChecked) {
          +      if (action == SafeModeAction.SAFEMODE_GET) {
          +        opCategory = OperationCategory.READ;
          +      } else {
          +        opCategory = OperationCategory.WRITE
          +      }
          +    }
          

          This should be in line with the behavior that an eventual split of setSafeMode/getSafeMode operations would implement.

          How does that sound?

          Show
          Aaron T. Myers added a comment - The latest patch looks pretty good to me. We can address the larger points about setting the service's vs just a single NN's safemode value, and changing the ClientProtocol to have an actual isInSafeMode/getSafeMode operation in separate JIRA(s). One comment on the patch: I don't think this will actually affect the correctness of the patch, but this code makes me a little wary, since as we've discussed a setSafeMode operation is not in fact necessarily a write: + OperationCategory opCategory = OperationCategory.UNCHECKED; + if (isChecked) { + opCategory = OperationCategory.WRITE; + } I think better would be something like this: + OperationCategory opCategory = OperationCategory.UNCHECKED; + if (isChecked) { + if (action == SafeModeAction.SAFEMODE_GET) { + opCategory = OperationCategory.READ; + } else { + opCategory = OperationCategory.WRITE + } + } This should be in line with the behavior that an eventual split of setSafeMode/getSafeMode operations would implement. How does that sound?
          Hide
          Vinayakumar B added a comment -

          Thanks aaron, Your suggestion looks good. I will post a patch soon about that.

          Show
          Vinayakumar B added a comment - Thanks aaron, Your suggestion looks good. I will post a patch soon about that.
          Hide
          Vinayakumar B added a comment -

          Ah! I just realize that, intention of this Jira is to get safemode status( i.e SafeModeAction.GET ) from only Active NN.
          I agree that SAFEMODE_GET is not a write operation, but If we consider SAFEMODE_GET as READ, and "dfs.ha.allow.stale.reads" is set, then SAFEMODE_GET will be again executed on the STANBY NN.

          +    if (isChecked) {
          +      if (action == SafeModeAction.SAFEMODE_GET) {
          +        opCategory = OperationCategory.READ;
          +      } else {
          +        opCategory = OperationCategory.WRITE
          +      }

          So I feel, SAFEMODE_GET also should be categorized as WRITE ( only to avoid execution on STANBY NN), else need to check state explicitly.

          Show
          Vinayakumar B added a comment - Ah! I just realize that, intention of this Jira is to get safemode status( i.e SafeModeAction.GET ) from only Active NN. I agree that SAFEMODE_GET is not a write operation, but If we consider SAFEMODE_GET as READ, and "dfs.ha.allow.stale.reads" is set, then SAFEMODE_GET will be again executed on the STANBY NN. + if (isChecked) { + if (action == SafeModeAction.SAFEMODE_GET) { + opCategory = OperationCategory.READ; + } else { + opCategory = OperationCategory.WRITE + } So I feel, SAFEMODE_GET also should be categorized as WRITE ( only to avoid execution on STANBY NN), else need to check state explicitly.
          Hide
          Aaron T. Myers added a comment -

          Hi Vinay, the config "dfs.ha.allow.stale.reads" is only used for tests. As such, I think it's OK to label these operations as I previously suggested.

          Show
          Aaron T. Myers added a comment - Hi Vinay, the config "dfs.ha.allow.stale.reads" is only used for tests. As such, I think it's OK to label these operations as I previously suggested.
          Hide
          Vinayakumar B added a comment -

          Attaching the patch

          Show
          Vinayakumar B added a comment - Attaching the patch
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12553638/HDFS-3507.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 11 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestHDFSFileSystemContract

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3517//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3517//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12553638/HDFS-3507.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 11 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestHDFSFileSystemContract +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3517//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3517//console This message is automatically generated.
          Hide
          Aaron T. Myers added a comment -

          Hi Vinay, the latest patch looks pretty good to me, except that the current patch doesn't default the value of the checked field in the .proto file, as I already commented it should. It should be something like this:

           message SetSafeModeRequestProto {
             required SafeModeActionProto action = 1;
          +  optional bool checked = 2 [default = false];
           }
          
          Show
          Aaron T. Myers added a comment - Hi Vinay, the latest patch looks pretty good to me, except that the current patch doesn't default the value of the checked field in the .proto file, as I already commented it should. It should be something like this: message SetSafeModeRequestProto { required SafeModeActionProto action = 1; + optional bool checked = 2 [ default = false ]; }
          Hide
          Vinayakumar B added a comment -

          Attaching the updated patch

          Show
          Vinayakumar B added a comment - Attaching the updated patch
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12553782/HDFS-3507.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 11 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3524//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3524//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12553782/HDFS-3507.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 11 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3524//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3524//console This message is automatically generated.
          Hide
          Aaron T. Myers added a comment -

          +1, the latest patch looks good to me. Will commit momentarily.

          Show
          Aaron T. Myers added a comment - +1, the latest patch looks good to me. Will commit momentarily.
          Hide
          Aaron T. Myers added a comment -

          I've just committed this patch to trunk and branch-2.

          Thanks a lot for the contribution, Vinay, and thanks a lot for bearing with my feedback.

          Show
          Aaron T. Myers added a comment - I've just committed this patch to trunk and branch-2. Thanks a lot for the contribution, Vinay, and thanks a lot for bearing with my feedback.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #3035 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3035/)
          HDFS-3507. DFS#isInSafeMode needs to execute only on Active NameNode. Contributed by Vinay. (Revision 1410587)

          Result = SUCCESS
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1410587
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientNamenodeProtocol.proto
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFetchImage.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecovery.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/UpgradeUtilities.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestListCorruptFileBlocks.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNNStorageRetentionFunctional.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStartup.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/metrics/TestNameNodeMetrics.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
          Show
          Hudson added a comment - Integrated in Hadoop-trunk-Commit #3035 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3035/ ) HDFS-3507 . DFS#isInSafeMode needs to execute only on Active NameNode. Contributed by Vinay. (Revision 1410587) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1410587 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientNamenodeProtocol.proto /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFetchImage.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecovery.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/UpgradeUtilities.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestListCorruptFileBlocks.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNNStorageRetentionFunctional.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStartup.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/metrics/TestNameNodeMetrics.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #39 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/39/)
          HDFS-3507. DFS#isInSafeMode needs to execute only on Active NameNode. Contributed by Vinay. (Revision 1410587)

          Result = SUCCESS
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1410587
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientNamenodeProtocol.proto
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFetchImage.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecovery.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/UpgradeUtilities.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestListCorruptFileBlocks.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNNStorageRetentionFunctional.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStartup.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/metrics/TestNameNodeMetrics.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Yarn-trunk #39 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/39/ ) HDFS-3507 . DFS#isInSafeMode needs to execute only on Active NameNode. Contributed by Vinay. (Revision 1410587) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1410587 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientNamenodeProtocol.proto /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFetchImage.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecovery.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/UpgradeUtilities.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestListCorruptFileBlocks.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNNStorageRetentionFunctional.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStartup.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/metrics/TestNameNodeMetrics.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1229 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1229/)
          HDFS-3507. DFS#isInSafeMode needs to execute only on Active NameNode. Contributed by Vinay. (Revision 1410587)

          Result = SUCCESS
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1410587
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientNamenodeProtocol.proto
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFetchImage.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecovery.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/UpgradeUtilities.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestListCorruptFileBlocks.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNNStorageRetentionFunctional.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStartup.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/metrics/TestNameNodeMetrics.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1229 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1229/ ) HDFS-3507 . DFS#isInSafeMode needs to execute only on Active NameNode. Contributed by Vinay. (Revision 1410587) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1410587 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientNamenodeProtocol.proto /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFetchImage.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecovery.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/UpgradeUtilities.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestListCorruptFileBlocks.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNNStorageRetentionFunctional.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStartup.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/metrics/TestNameNodeMetrics.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1260 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1260/)
          HDFS-3507. DFS#isInSafeMode needs to execute only on Active NameNode. Contributed by Vinay. (Revision 1410587)

          Result = FAILURE
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1410587
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientNamenodeProtocol.proto
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFetchImage.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecovery.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/UpgradeUtilities.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestListCorruptFileBlocks.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNNStorageRetentionFunctional.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStartup.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/metrics/TestNameNodeMetrics.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1260 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1260/ ) HDFS-3507 . DFS#isInSafeMode needs to execute only on Active NameNode. Contributed by Vinay. (Revision 1410587) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1410587 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientNamenodeProtocol.proto /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFetchImage.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecovery.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/UpgradeUtilities.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestListCorruptFileBlocks.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNNStorageRetentionFunctional.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStartup.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/metrics/TestNameNodeMetrics.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
          Hide
          Vinayakumar B added a comment -

          Thanks Aaron and Nicholas for comments and suggestions.

          Show
          Vinayakumar B added a comment - Thanks Aaron and Nicholas for comments and suggestions.

            People

            • Assignee:
              Vinayakumar B
              Reporter:
              Vinayakumar B
            • Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development