Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.2-alpha
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We already have BlockCollection and MutableBlockCollection interfaces so that INodeFile and INodeFileUnderConstruction can be changed to package private.

      1. h3502_20120608.patch
        11 kB
        Tsz Wo Nicholas Sze
      2. h3502_20120611.patch
        11 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        h3502_20120608.patch: changed them to package private.

        Show
        Tsz Wo Nicholas Sze added a comment - h3502_20120608.patch: changed them to package private.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12531487/h3502_20120608.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2633//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2633//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12531487/h3502_20120608.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2633//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2633//console This message is automatically generated.
        Hide
        John George added a comment -

        The patch looks good generally. A couple of questions:
        Should we add Interface.Private above INodeFileUnderConstruction class?
        The change in BlockInfo.java - I do not see EMPTY_ARRAY being used anywhere - am I missing something?

        +  public static final BlockInfo[] EMPTY_ARRAY = {}; 
        
        Show
        John George added a comment - The patch looks good generally. A couple of questions: Should we add Interface.Private above INodeFileUnderConstruction class? The change in BlockInfo.java - I do not see EMPTY_ARRAY being used anywhere - am I missing something? + public static final BlockInfo[] EMPTY_ARRAY = {};
        Hide
        Tsz Wo Nicholas Sze added a comment -

        John, good point. I added @InterfaceAudience.Private in the following path.

        h3502_20120611.patch

        For BlockInfo.EMPTY_ARRAY, it is used in INodeFileUnderConstruction and FSDirectory. The original code passes length 0 and create new BlockInfo[0]. It is a small optimization to avoid creating empty array since empty arrays are immutable.

        Show
        Tsz Wo Nicholas Sze added a comment - John, good point. I added @InterfaceAudience.Private in the following path. h3502_20120611.patch For BlockInfo.EMPTY_ARRAY, it is used in INodeFileUnderConstruction and FSDirectory. The original code passes length 0 and create new BlockInfo [0] . It is a small optimization to avoid creating empty array since empty arrays are immutable.
        Hide
        John George added a comment -

        Great. +1

        Show
        John George added a comment - Great. +1
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Thanks John for the review!

        I have committed this.

        (I did not wait for Jerkins again since the different between two patches is only @InterfaceAudience.Private.)

        Show
        Tsz Wo Nicholas Sze added a comment - Thanks John for the review! I have committed this. (I did not wait for Jerkins again since the different between two patches is only @InterfaceAudience.Private.)
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12531705/h3502_20120611.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2636//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2636//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12531705/h3502_20120611.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2636//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2636//console This message is automatically generated.

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development