Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3428

move DelegationTokenRenewer to common

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently DelegationTokenRenewer is in HDFS, it seems more appropriate for it to be in common so it could be used by other FS implementations not necessary depending on HDFS (ie HttpFS)

      1. HDFS-3428.patch
        14 kB
        Alejandro Abdelnur

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1108 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1108/)
        Amendment to my previous commit, fixing JIRA in CHANGES.txt from HDFS-3228 to HDFS-3428 (Revision 1349556)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349556
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1108 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1108/ ) Amendment to my previous commit, fixing JIRA in CHANGES.txt from HDFS-3228 to HDFS-3428 (Revision 1349556) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349556 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1075 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1075/)
        Amendment to my previous commit, fixing JIRA in CHANGES.txt from HDFS-3228 to HDFS-3428 (Revision 1349556)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349556
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1075 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1075/ ) Amendment to my previous commit, fixing JIRA in CHANGES.txt from HDFS-3228 to HDFS-3428 (Revision 1349556) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349556 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2373 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2373/)
        Amendment to my previous commit, fixing JIRA in CHANGES.txt from HDFS-3228 to HDFS-3428 (Revision 1349556)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349556
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2373 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2373/ ) Amendment to my previous commit, fixing JIRA in CHANGES.txt from HDFS-3228 to HDFS-3428 (Revision 1349556) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349556 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2350 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2350/)
        Amendment to my previous commit, fixing JIRA in CHANGES.txt from HDFS-3228 to HDFS-3428 (Revision 1349556)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349556
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2350 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2350/ ) Amendment to my previous commit, fixing JIRA in CHANGES.txt from HDFS-3228 to HDFS-3428 (Revision 1349556) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349556 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2423 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2423/)
        Amendment to my previous commit, fixing JIRA in CHANGES.txt from HDFS-3228 to HDFS-3428 (Revision 1349556)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349556
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2423 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2423/ ) Amendment to my previous commit, fixing JIRA in CHANGES.txt from HDFS-3228 to HDFS-3428 (Revision 1349556) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349556 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Alejandro Abdelnur added a comment -

        committed to trunk and branch-2

        Show
        Alejandro Abdelnur added a comment - committed to trunk and branch-2
        Hide
        Daryn Sharp added a comment -

        +1 Thanks!

        Show
        Daryn Sharp added a comment - +1 Thanks!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12530413/HDFS-3428.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.fs.viewfs.TestViewFsTrash

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2555//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2555//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530413/HDFS-3428.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.fs.viewfs.TestViewFsTrash +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2555//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2555//console This message is automatically generated.
        Hide
        Alejandro Abdelnur added a comment -

        @Daryn, as you said, move and import changes only.

        Show
        Alejandro Abdelnur added a comment - @Daryn, as you said, move and import changes only.
        Hide
        Daryn Sharp added a comment -

        To save me some effort, did you just copy the file to the new location? Or do anything beyond changing imports?

        Show
        Daryn Sharp added a comment - To save me some effort, did you just copy the file to the new location? Or do anything beyond changing imports?

          People

          • Assignee:
            Alejandro Abdelnur
            Reporter:
            Alejandro Abdelnur
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development