Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3422

TestStandbyIsHot timeouts too aggressive

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      I've seen TestStandbyIsHot timeout a few times waiting for replication to change, but when I look at the logs, it appears everything is fine. The block deletions are just a bit slow in being processed.

      To improve the test we should either increase the timeouts, or explicitly trigger heartbeats and replication work after changing the desired replication levels.

      1. hdfs-3422.txt
        3 kB
        Todd Lipcon

        Activity

        Hide
        Todd Lipcon added a comment -

        Following patch more explicitly forces replication work to be calculated in an expedient matter, increases timeouts, etc. I looped this for an hour or so locally and it passed every time.

        Show
        Todd Lipcon added a comment - Following patch more explicitly forces replication work to be calculated in an expedient matter, increases timeouts, etc. I looped this for an hour or so locally and it passed every time.
        Hide
        Aaron T. Myers added a comment -

        +1, the patch looks good to me. Thanks, Todd.

        Show
        Aaron T. Myers added a comment - +1, the patch looks good to me. Thanks, Todd.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12527743/hdfs-3422.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2450//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2450//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12527743/hdfs-3422.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2450//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2450//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Committed to branch-2 and trunk, thanks for reviewing.

        Show
        Todd Lipcon added a comment - Committed to branch-2 and trunk, thanks for reviewing.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2273 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2273/)
        HDFS-3422. TestStandbyIsHot timeouts too aggressive. Contributed by Todd Lipcon. (Revision 1339452)

        Result = ABORTED
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339452
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyIsHot.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2273 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2273/ ) HDFS-3422 . TestStandbyIsHot timeouts too aggressive. Contributed by Todd Lipcon. (Revision 1339452) Result = ABORTED todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339452 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyIsHot.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2330 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2330/)
        HDFS-3422. TestStandbyIsHot timeouts too aggressive. Contributed by Todd Lipcon. (Revision 1339452)

        Result = SUCCESS
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339452
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyIsHot.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2330 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2330/ ) HDFS-3422 . TestStandbyIsHot timeouts too aggressive. Contributed by Todd Lipcon. (Revision 1339452) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339452 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyIsHot.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2256 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2256/)
        HDFS-3422. TestStandbyIsHot timeouts too aggressive. Contributed by Todd Lipcon. (Revision 1339452)

        Result = SUCCESS
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339452
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyIsHot.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2256 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2256/ ) HDFS-3422 . TestStandbyIsHot timeouts too aggressive. Contributed by Todd Lipcon. (Revision 1339452) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339452 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyIsHot.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1048 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1048/)
        HDFS-3422. TestStandbyIsHot timeouts too aggressive. Contributed by Todd Lipcon. (Revision 1339452)

        Result = SUCCESS
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339452
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyIsHot.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1048 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1048/ ) HDFS-3422 . TestStandbyIsHot timeouts too aggressive. Contributed by Todd Lipcon. (Revision 1339452) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339452 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyIsHot.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1082 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1082/)
        HDFS-3422. TestStandbyIsHot timeouts too aggressive. Contributed by Todd Lipcon. (Revision 1339452)

        Result = SUCCESS
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339452
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyIsHot.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1082 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1082/ ) HDFS-3422 . TestStandbyIsHot timeouts too aggressive. Contributed by Todd Lipcon. (Revision 1339452) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339452 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyIsHot.java

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development