Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3344

Unreliable corrupt blocks counting in TestProcessCorruptBlocks

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.7
    • Fix Version/s: 3.0.0, 0.23.7, 2.0.4-alpha
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It failed in build #2356:

      java.lang.AssertionError: expected:<0> but was:<1>
      	at org.junit.Assert.fail(Assert.java:91)
      	at org.junit.Assert.failNotEquals(Assert.java:645)
      	at org.junit.Assert.assertEquals(Assert.java:126)
      	at org.junit.Assert.assertEquals(Assert.java:470)
      	at org.junit.Assert.assertEquals(Assert.java:454)
      	at org.apache.hadoop.hdfs.server.namenode.TestProcessCorruptBlocks.testWithReplicationFactorAsOne(TestProcessCorruptBlocks.java:192)
      	...
      

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1372 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1372/)
        HDFS-3344. Unreliable corrupt blocks counting in TestProcessCorruptBlocks. Contributed by Kihwal Lee. (Revision 1456172)

        Result = SUCCESS
        kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456172
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestProcessCorruptBlocks.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1372 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1372/ ) HDFS-3344 . Unreliable corrupt blocks counting in TestProcessCorruptBlocks. Contributed by Kihwal Lee. (Revision 1456172) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456172 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestProcessCorruptBlocks.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1344 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1344/)
        HDFS-3344. Unreliable corrupt blocks counting in TestProcessCorruptBlocks. Contributed by Kihwal Lee. (Revision 1456172)

        Result = FAILURE
        kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456172
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestProcessCorruptBlocks.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1344 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1344/ ) HDFS-3344 . Unreliable corrupt blocks counting in TestProcessCorruptBlocks. Contributed by Kihwal Lee. (Revision 1456172) Result = FAILURE kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456172 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestProcessCorruptBlocks.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #553 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/553/)
        svn merge -c 1456172 Merging from trunk to branch-0.23 to fix HDFS-3344. (Revision 1456189)

        Result = SUCCESS
        kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456189
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestProcessCorruptBlocks.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #553 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/553/ ) svn merge -c 1456172 Merging from trunk to branch-0.23 to fix HDFS-3344 . (Revision 1456189) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456189 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestProcessCorruptBlocks.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #155 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/155/)
        HDFS-3344. Unreliable corrupt blocks counting in TestProcessCorruptBlocks. Contributed by Kihwal Lee. (Revision 1456172)

        Result = SUCCESS
        kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456172
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestProcessCorruptBlocks.java
        Show
        Hudson added a comment - Integrated in Hadoop-Yarn-trunk #155 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/155/ ) HDFS-3344 . Unreliable corrupt blocks counting in TestProcessCorruptBlocks. Contributed by Kihwal Lee. (Revision 1456172) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456172 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestProcessCorruptBlocks.java
        Hide
        Kihwal Lee added a comment -

        I've committed to trunk, branch-2 and branch-0.23. Updated the description. Thanks for the review, Nicholas.

        Show
        Kihwal Lee added a comment - I've committed to trunk, branch-2 and branch-0.23. Updated the description. Thanks for the review, Nicholas.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3467 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3467/)
        HDFS-3344. Unreliable corrupt blocks counting in TestProcessCorruptBlocks. Contributed by Kihwal Lee. (Revision 1456172)

        Result = SUCCESS
        kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456172
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestProcessCorruptBlocks.java
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #3467 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3467/ ) HDFS-3344 . Unreliable corrupt blocks counting in TestProcessCorruptBlocks. Contributed by Kihwal Lee. (Revision 1456172) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456172 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestProcessCorruptBlocks.java
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good. Thanks, Kihwal.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good. Thanks, Kihwal.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12573157/hdfs-3344.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 tests included appear to have a timeout.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.datanode.TestDataDirs

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4077//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4077//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12573157/hdfs-3344.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 tests included appear to have a timeout. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.datanode.TestDataDirs +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4077//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4077//console This message is automatically generated.
        Hide
        Kihwal Lee added a comment -

        I see this in 0.23.7 as well. Looking at the logs, it seems that the first block report from a dn sometimes does not come in 3 seconds even if the interval is set to 1 second. Do you see it failing 2.0 or trunk as much as it used to?

        Show
        Kihwal Lee added a comment - I see this in 0.23.7 as well. Looking at the logs, it seems that the first block report from a dn sometimes does not come in 3 seconds even if the interval is set to 1 second. Do you see it failing 2.0 or trunk as much as it used to?

          People

          • Assignee:
            Kihwal Lee
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development