Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-330

Datanode Web UIs should provide robots.txt

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      A robots.txt is now in place which will prevent well behaved crawlers from perusing Hadoop web interfaces.

      Description

      There is a potential issue that someone might have an internal corporate crawler that goes through HDFS browser accidentally. It might be a good idea to provide a default robots file that disables crawling. [No, this didn't happen to us. :) ]

      1. HDFS-330.txt
        0.2 kB
        Allen Wittenauer

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        707d 23h 50m 1 Allen Wittenauer 23/Apr/10 22:31
        Patch Available Patch Available Resolved Resolved
        106d 3h 6m 1 Jakob Homan 08/Aug/10 01:38
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #370 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/370/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #370 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/370/ )
        Jakob Homan made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Jakob Homan added a comment -

        I've committed this. Thanks, Allen. Resolving as fixed.

        Show
        Jakob Homan added a comment - I've committed this. Thanks, Allen. Resolving as fixed.
        Jakob Homan made changes -
        Summary Web UIs should provide robots.txt Datanode Web UIs should provide robots.txt
        Assignee Allen Wittenauer [ aw ]
        Fix Version/s 0.22.0 [ 12314241 ]
        Affects Version/s 0.22.0 [ 12314241 ]
        Affects Version/s 0.20.2 [ 12314204 ]
        Component/s data-node [ 12312927 ]
        Hide
        Jakob Homan added a comment -

        +1. This is reasonable. Since this is a minor change, previous Hudson run is still ok. Release audit warning is about lack of license in the robots.txt, which is ok.

        Show
        Jakob Homan added a comment - +1. This is reasonable. Since this is a minor change, previous Hudson run is still ok. Release audit warning is about lack of license in the robots.txt, which is ok.
        Tom White made changes -
        Fix Version/s 0.21.0 [ 12314046 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12442709/HDFS-330.txt
        against trunk revision 937185.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        -1 release audit. The applied patch generated 114 release audit warnings (more than the trunk's current 112 warnings).

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/323/testReport/
        Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/323/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/323/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/323/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/323/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12442709/HDFS-330.txt against trunk revision 937185. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 114 release audit warnings (more than the trunk's current 112 warnings). +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/323/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/323/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/323/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/323/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/323/console This message is automatically generated.
        Allen Wittenauer made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hadoop Flags [Incompatible change]
        Release Note A robots.txt is now in place which will prevent well behaved crawlers from perusing Hadoop web interfaces.
        Fix Version/s 0.21.0 [ 12314046 ]
        Allen Wittenauer made changes -
        Attachment HDFS-330.txt [ 12442709 ]
        Hide
        Allen Wittenauer added a comment -

        block all on datanode.

        Show
        Allen Wittenauer added a comment - block all on datanode.
        Allen Wittenauer made changes -
        Affects Version/s 0.20.2 [ 12314204 ]
        Owen O'Malley made changes -
        Project Hadoop Common [ 12310240 ] HDFS [ 12310942 ]
        Key HADOOP-3397 HDFS-330
        Affects Version/s 0.16.4 [ 12313132 ]
        Component/s dfs [ 12310710 ]
        Hide
        Raghu Angadi added a comment -

        +1. Could be a default for Hadoop wrapper over jetty server.

        Show
        Raghu Angadi added a comment - +1. Could be a default for Hadoop wrapper over jetty server.
        Allen Wittenauer made changes -
        Component/s dfs [ 12310710 ]
        Affects Version/s 0.16.4 [ 12313132 ]
        Allen Wittenauer made changes -
        Field Original Value New Value
        Description There is a potential that someone might have an internal corporate crawler that goes through HDFS browser accidentally. It might be a good idea to provide a default robots file that disables crawling. [No, this didn't happen to us. :) ] There is a potential issue that someone might have an internal corporate crawler that goes through HDFS browser accidentally. It might be a good idea to provide a default robots file that disables crawling. [No, this didn't happen to us. :) ]
        Allen Wittenauer created issue -

          People

          • Assignee:
            Allen Wittenauer
            Reporter:
            Allen Wittenauer
          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development