Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3156

TestDFSHAAdmin is failing post HADOOP-8202

        Details

        • Type: Bug Bug
        • Status: Resolved
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 2.0.0-alpha
        • Fix Version/s: 2.0.0-alpha
        • Component/s: test
        • Labels:
          None

          Description

          TestDFSHAAdmin mocks a protocol object without implementing Closeable, which is now required.

          1. Text File
            HDFS-3156.patch
            1.0 kB
            Aaron T. Myers

            Activity

            Ascending order - Click to sort in descending order
            Aaron T. Myers created issue -
            Hide
            Permalink
            Aaron T. Myers added a comment -

            Here's a patch which addresses the issue.

            Show
            Aaron T. Myers added a comment - Here's a patch which addresses the issue.
            Aaron T. Myers made changes -
            Field Original Value New Value
            Attachment HDFS-3156.patch [ 12520239 ]
            Hide
            Permalink
            Todd Lipcon added a comment -

            +1 pending hudson

            Show
            Todd Lipcon added a comment - +1 pending hudson
            Todd Lipcon made changes -
            Status Open [ 1 ] Patch Available [ 10002 ]
            Hadoop Flags Reviewed [ 10343 ]
            Target Version/s 0.23.3, 0.24.0 [ 12320052, 12317653 ] 0.24.0, 0.23.3 [ 12317653, 12320052 ]
            Hide
            Permalink
            Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12520239/HDFS-3156.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 3 new or modified tests.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            -1 javac. The patch appears to cause tar ant target to fail.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            -1 core tests. The patch failed the unit tests build

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2108//testReport/
            Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2108//console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520239/HDFS-3156.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed the unit tests build +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2108//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2108//console This message is automatically generated.
            Hide
            Permalink
            Aaron T. Myers added a comment -

            Hmmm, for some reason the patch failed to compile because MockitoUtil couldn't be found, even though HADOOP-8218 has already been committed. Perhaps the Jenkins slaves run against an svn mirror that hasn't been updated yet? I'll kick another Jenkins build tomorrow to give it another shot.

            Show
            Aaron T. Myers added a comment - Hmmm, for some reason the patch failed to compile because MockitoUtil couldn't be found, even though HADOOP-8218 has already been committed. Perhaps the Jenkins slaves run against an svn mirror that hasn't been updated yet? I'll kick another Jenkins build tomorrow to give it another shot.
            Hide
            Permalink
            Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12520239/HDFS-3156.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 3 new or modified tests.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            -1 core tests. The patch failed these unit tests:
            org.apache.hadoop.hdfs.TestGetBlocks
            org.apache.hadoop.cli.TestHDFSCLI

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2109//testReport/
            Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2109//console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520239/HDFS-3156.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestGetBlocks org.apache.hadoop.cli.TestHDFSCLI +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2109//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2109//console This message is automatically generated.
            Hide
            Permalink
            Aaron T. Myers added a comment -

            Those two tests are known to be failing on trunk (HDFS-3142 and HDFs-3143). I'm going to commit this shortly.

            Show
            Aaron T. Myers added a comment - Those two tests are known to be failing on trunk ( HDFS-3142 and HDFs-3143). I'm going to commit this shortly.
            Aaron T. Myers made changes -
            Affects Version/s 0.24.0 [ 12317653 ]
            Target Version/s 0.23.3, 0.24.0 [ 12320052, 12317653 ] 0.23.3 [ 12320052 ]
            Aaron T. Myers made changes -
            Affects Version/s 2.0.0 [ 12320353 ]
            Affects Version/s 0.23.3 [ 12320052 ]
            Target Version/s 0.23.3 [ 12320052 ] 2.0.0 [ 12320353 ]
            Hide
            Permalink
            Aaron T. Myers added a comment -

            I've just committed this to trunk and branch-2. Thanks a lot for the quick review, Todd.

            Show
            Aaron T. Myers added a comment - I've just committed this to trunk and branch-2. Thanks a lot for the quick review, Todd.
            Aaron T. Myers made changes -
            Status Patch Available [ 10002 ] Resolved [ 5 ]
            Fix Version/s 2.0.0 [ 12320353 ]
            Resolution Fixed [ 1 ]
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk-Commit #2014 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2014/)
            HDFS-3156. TestDFSHAAdmin is failing post HADOOP-8202. Contributed by Aaron T. Myers. (Revision 1306517)

            Result = SUCCESS
            atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306517
            Files :

            • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSHAAdmin.java
            Show
            Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2014 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2014/ ) HDFS-3156 . TestDFSHAAdmin is failing post HADOOP-8202 . Contributed by Aaron T. Myers. (Revision 1306517) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306517 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSHAAdmin.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Common-trunk-Commit #1939 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1939/)
            HDFS-3156. TestDFSHAAdmin is failing post HADOOP-8202. Contributed by Aaron T. Myers. (Revision 1306517)

            Result = SUCCESS
            atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306517
            Files :

            • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSHAAdmin.java
            Show
            Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1939 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1939/ ) HDFS-3156 . TestDFSHAAdmin is failing post HADOOP-8202 . Contributed by Aaron T. Myers. (Revision 1306517) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306517 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSHAAdmin.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Mapreduce-trunk-Commit #1952 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1952/)
            HDFS-3156. TestDFSHAAdmin is failing post HADOOP-8202. Contributed by Aaron T. Myers. (Revision 1306517)

            Result = ABORTED
            atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306517
            Files :

            • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSHAAdmin.java
            Show
            Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1952 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1952/ ) HDFS-3156 . TestDFSHAAdmin is failing post HADOOP-8202 . Contributed by Aaron T. Myers. (Revision 1306517) Result = ABORTED atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306517 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSHAAdmin.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Mapreduce-trunk #1034 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1034/)
            HDFS-3156. TestDFSHAAdmin is failing post HADOOP-8202. Contributed by Aaron T. Myers. (Revision 1306517)

            Result = FAILURE
            atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306517
            Files :

            • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSHAAdmin.java
            Show
            Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1034 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1034/ ) HDFS-3156 . TestDFSHAAdmin is failing post HADOOP-8202 . Contributed by Aaron T. Myers. (Revision 1306517) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306517 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSHAAdmin.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk #999 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/999/)
            HDFS-3156. TestDFSHAAdmin is failing post HADOOP-8202. Contributed by Aaron T. Myers. (Revision 1306517)

            Result = FAILURE
            atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306517
            Files :

            • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSHAAdmin.java
            Show
            Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #999 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/999/ ) HDFS-3156 . TestDFSHAAdmin is failing post HADOOP-8202 . Contributed by Aaron T. Myers. (Revision 1306517) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306517 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSHAAdmin.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Mapreduce-trunk #1035 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1035/)
            HDFS-3156. TestDFSHAAdmin is failing post HADOOP-8202. Contributed by Aaron T. Myers. (Revision 1306517)

            Result = SUCCESS
            atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306517
            Files :

            • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSHAAdmin.java
            Show
            Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1035 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1035/ ) HDFS-3156 . TestDFSHAAdmin is failing post HADOOP-8202 . Contributed by Aaron T. Myers. (Revision 1306517) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306517 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSHAAdmin.java

              People

              • Assignee:
                Aaron T. Myers
                Reporter:
                Aaron T. Myers
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development