Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0, 2.0.0-alpha
    • Fix Version/s: 1.1.0
    • Component/s: None
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Aaron has the following comments on TestStorageRestore in HDFS-3127.

      1. removeStorageAccess, restoreAccess, and numStorageDirs can all be made private
      2. numStorageDirs can be made static
      3. Rather than do set(Readable/Executable/Writable), use FileUtil.chmod(...).
      4. Please put the contents of the test in a try/finally, with the calls to shutdown the cluster and the 2NN in the finally block.
      5. Some lines are over 80 chars.
      6. No need for the numDatanodes variable - it's only used in one place.
      7. Instead of "xwr" use "rwx", which I think is a more common way of describing permissions.

        Attachments

        1. HDFS-3131.patch
          3 kB
          Brandon Li
        2. HDFS-3131.branch-1.patch
          6 kB
          Brandon Li
        3. HDFS-3131.patch
          3 kB
          Brandon Li

          Issue Links

            Activity

              People

              • Assignee:
                brandonli Brandon Li
                Reporter:
                szetszwo Tsz Wo Nicholas Sze
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: