Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.24.0, 1.1.0
    • Fix Version/s: 1.1.0
    • Component/s: None
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Aaron has the following comments on TestStorageRestore in HDFS-3127.

      1. removeStorageAccess, restoreAccess, and numStorageDirs can all be made private
      2. numStorageDirs can be made static
      3. Rather than do set(Readable/Executable/Writable), use FileUtil.chmod(...).
      4. Please put the contents of the test in a try/finally, with the calls to shutdown the cluster and the 2NN in the finally block.
      5. Some lines are over 80 chars.
      6. No need for the numDatanodes variable - it's only used in one place.
      7. Instead of "xwr" use "rwx", which I think is a more common way of describing permissions.
      1. HDFS-3131.branch-1.patch
        6 kB
        Brandon Li
      2. HDFS-3131.patch
        3 kB
        Brandon Li
      3. HDFS-3131.patch
        3 kB
        Brandon Li

        Issue Links

          Activity

          Tsz Wo Nicholas Sze created issue -
          Aaron T. Myers made changes -
          Field Original Value New Value
          Labels newbie
          Affects Version/s 0.24.0 [ 12317653 ]
          Target Version/s 0.24.0 [ 12317653 ]
          Tsz Wo Nicholas Sze made changes -
          Assignee Brandon Li [ brandonli ]
          Tsz Wo Nicholas Sze made changes -
          Link This issue is related to HDFS-3127 [ HDFS-3127 ]
          Brandon Li made changes -
          Attachment HDFS-3131.patch [ 12519744 ]
          Brandon Li made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Release Note added test case to make sure that restore failure doesn't stop checkpoint process
          Brandon Li made changes -
          Affects Version/s 1.1.0 [ 12317959 ]
          Brandon Li made changes -
          Target Version/s 0.24.0 [ 12317653 ] 0.24.0, 1.1.0 [ 12317653, 12317959 ]
          Brandon Li made changes -
          Attachment HDFS-3131.branch-1.patch [ 12519752 ]
          Brandon Li made changes -
          Attachment HDFS-3131.patch [ 12520018 ]
          Aaron T. Myers made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Release Note added test case to make sure that restore failure doesn't stop checkpoint process
          Target Version/s 1.1.0, 0.24.0 [ 12317959, 12317653 ] 0.24.0, 1.1.0 [ 12317653, 12317959 ]
          Fix Version/s 0.24.0 [ 12317653 ]
          Fix Version/s 1.1.0 [ 12317959 ]
          Resolution Fixed [ 1 ]
          Arun C Murthy made changes -
          Fix Version/s 0.24.0 [ 12317653 ]
          Target Version/s 1.1.0, 0.24.0 [ 12317959, 12317653 ] 0.24.0, 1.1.0 [ 12317653, 12317959 ]
          Matt Foley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Brandon Li
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development