Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
0.23.2
-
None
-
Reviewed
Description
The SecondaryNameNode is not properly initializing its metrics system. This results in the UgiMetrics, Metrics subsystem stats, and JvmMetrics not being output.
Attachments
Attachments
- HDFS-3099.patch
- 4 kB
- Aaron Myers
- HDFS-3099.patch
- 4 kB
- Aaron Myers
- HDFS-3099.patch
- 0.8 kB
- Aaron Myers
Activity
Any chance you could add a simple test case in TestSecondaryWebUi? Should be only a few lines.
You're going to slap me for making you do another rev on this, but: can you change the @Before to a @BeforeClass, so that we only use one minicluster here instead of one per case?
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12518530/HDFS-3099.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.cli.TestHDFSCLI
org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2012//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2012//console
This message is automatically generated.
The test failures are unrelated to this patch. TestHDFSCLI is currently failing on trunk, and the TestValidateConfigurationSettings failure seems spurious. It just passed for me just fine on my box.
I'm going to commit this momentarily.
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12518530/HDFS-3099.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hdfs.TestDFSShell
org.apache.hadoop.hdfs.TestDFSClientRetries
org.apache.hadoop.cli.TestHDFSCLI
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2018//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2018//console
This message is automatically generated.
Integrated in Hadoop-Common-trunk-Commit #1880 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1880/)
HDFS-3099. SecondaryNameNode does not properly initialize metrics system. Contributed by Aaron T. Myers. (Revision 1301222)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301222
Files :
- /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
- /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSecondaryWebUi.java
Integrated in Hadoop-Hdfs-trunk-Commit #1955 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1955/)
HDFS-3099. SecondaryNameNode does not properly initialize metrics system. Contributed by Aaron T. Myers. (Revision 1301222)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301222
Files :
- /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
- /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSecondaryWebUi.java
Integrated in Hadoop-Common-0.23-Commit #685 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/685/)
HDFS-3099. SecondaryNameNode does not properly initialize metrics system. Contributed by Aaron T. Myers. (Revision 1301230)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301230
Files :
- /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
- /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSecondaryWebUi.java
Integrated in Hadoop-Hdfs-0.23-Commit #676 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/676/)
HDFS-3099. SecondaryNameNode does not properly initialize metrics system. Contributed by Aaron T. Myers. (Revision 1301230)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301230
Files :
- /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
- /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSecondaryWebUi.java
Integrated in Hadoop-Mapreduce-trunk-Commit #1889 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1889/)
HDFS-3099. SecondaryNameNode does not properly initialize metrics system. Contributed by Aaron T. Myers. (Revision 1301222)
Result = ABORTED
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301222
Files :
- /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
- /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSecondaryWebUi.java
Integrated in Hadoop-Mapreduce-0.23-Commit #693 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/693/)
HDFS-3099. SecondaryNameNode does not properly initialize metrics system. Contributed by Aaron T. Myers. (Revision 1301230)
Result = ABORTED
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301230
Files :
- /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
- /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSecondaryWebUi.java
Integrated in Hadoop-Hdfs-trunk #986 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/986/)
HDFS-3099. SecondaryNameNode does not properly initialize metrics system. Contributed by Aaron T. Myers. (Revision 1301222)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301222
Files :
- /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
- /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSecondaryWebUi.java
Integrated in Hadoop-Hdfs-0.23-Build #199 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/199/)
HDFS-3099. SecondaryNameNode does not properly initialize metrics system. Contributed by Aaron T. Myers. (Revision 1301230)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301230
Files :
- /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
- /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSecondaryWebUi.java
Integrated in Hadoop-Mapreduce-0.23-Build #227 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/227/)
HDFS-3099. SecondaryNameNode does not properly initialize metrics system. Contributed by Aaron T. Myers. (Revision 1301230)
Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301230
Files :
- /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
- /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSecondaryWebUi.java
Integrated in Hadoop-Mapreduce-trunk #1021 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1021/)
HDFS-3099. SecondaryNameNode does not properly initialize metrics system. Contributed by Aaron T. Myers. (Revision 1301222)
Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301222
Files :
- /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
- /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSecondaryWebUi.java
Here's a trivial patched which fixes the issue. I tested this manually by starting up a 2NN and browsing to "/jmx". I confirmed that the expected metrics do appear with this patch, where as they do not without it.