Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3040

TestMulitipleNNDataBlockScanner is misspelled

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 2.0.2-alpha
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There's an unnecessary extra "i" in the name of the test.

      1. HDFS-3040-1.patch
        13 kB
        madhukara phatak
      2. HDFS-3040.patch
        6 kB
        madhukara phatak

        Activity

        Aaron T. Myers created issue -
        Hide
        madhukara phatak added a comment -

        Test class renamed

        Show
        madhukara phatak added a comment - Test class renamed
        madhukara phatak made changes -
        Field Original Value New Value
        Attachment HDFS-3040.patch [ 12526725 ]
        madhukara phatak made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12526725/HDFS-3040.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2438//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2438//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526725/HDFS-3040.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2438//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2438//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        Thanks a lot for the patch, Madhukara. Unfortunately JIRA is having some issues at the moment so I can't assign this to issue to you. Unassigning it for now.

        The patch doesn't include the removal of the misspelled class name, and in fact still depends on it since it creates the LOG object using that class.

        Show
        Aaron T. Myers added a comment - Thanks a lot for the patch, Madhukara. Unfortunately JIRA is having some issues at the moment so I can't assign this to issue to you. Unassigning it for now. The patch doesn't include the removal of the misspelled class name, and in fact still depends on it since it creates the LOG object using that class.
        Aaron T. Myers made changes -
        Assignee Aaron T. Myers [ atm ]
        Aaron T. Myers made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Affects Version/s 3.0.0 [ 12320356 ]
        Affects Version/s 0.24.0 [ 12317653 ]
        Target Version/s 0.24.0 [ 12317653 ] 3.0.0 [ 12320356 ]
        Hide
        madhukara phatak added a comment -

        updated the patch with correct class name

        Show
        madhukara phatak added a comment - updated the patch with correct class name
        madhukara phatak made changes -
        Attachment HDFS-3040-1.patch [ 12527810 ]
        madhukara phatak made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12527810/HDFS-3040-1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2472//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2472//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12527810/HDFS-3040-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2472//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2472//console This message is automatically generated.
        Aaron T. Myers made changes -
        Assignee madhukara phatak [ phatak.dev ]
        Hide
        Aaron T. Myers added a comment -

        +1, the patch looks good to me. I'm going to commit this momentarily.

        Show
        Aaron T. Myers added a comment - +1, the patch looks good to me. I'm going to commit this momentarily.
        Hide
        Aaron T. Myers added a comment -

        I've just committed this to trunk. Thanks a lot for the contribution, Madhukara.

        Show
        Aaron T. Myers added a comment - I've just committed this to trunk. Thanks a lot for the contribution, Madhukara.
        Aaron T. Myers made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 3.0.0 [ 12320356 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2355 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2355/)
        HDFS-3040. TestMulitipleNNDataBlockScanner is misspelled. Contributed by Madhukara Phatak. (Revision 1347891)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347891
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMulitipleNNDataBlockScanner.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMultipleNNDataBlockScanner.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2355 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2355/ ) HDFS-3040 . TestMulitipleNNDataBlockScanner is misspelled. Contributed by Madhukara Phatak. (Revision 1347891) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347891 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMulitipleNNDataBlockScanner.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMultipleNNDataBlockScanner.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2336 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2336/)
        HDFS-3040. TestMulitipleNNDataBlockScanner is misspelled. Contributed by Madhukara Phatak. (Revision 1347891)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347891
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMulitipleNNDataBlockScanner.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMultipleNNDataBlockScanner.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2336 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2336/ ) HDFS-3040 . TestMulitipleNNDataBlockScanner is misspelled. Contributed by Madhukara Phatak. (Revision 1347891) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347891 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMulitipleNNDataBlockScanner.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMultipleNNDataBlockScanner.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2409 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2409/)
        HDFS-3040. TestMulitipleNNDataBlockScanner is misspelled. Contributed by Madhukara Phatak. (Revision 1347891)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347891
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMulitipleNNDataBlockScanner.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMultipleNNDataBlockScanner.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2409 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2409/ ) HDFS-3040 . TestMulitipleNNDataBlockScanner is misspelled. Contributed by Madhukara Phatak. (Revision 1347891) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347891 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMulitipleNNDataBlockScanner.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMultipleNNDataBlockScanner.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1071 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1071/)
        HDFS-3040. TestMulitipleNNDataBlockScanner is misspelled. Contributed by Madhukara Phatak. (Revision 1347891)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347891
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMulitipleNNDataBlockScanner.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMultipleNNDataBlockScanner.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1071 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1071/ ) HDFS-3040 . TestMulitipleNNDataBlockScanner is misspelled. Contributed by Madhukara Phatak. (Revision 1347891) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347891 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMulitipleNNDataBlockScanner.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMultipleNNDataBlockScanner.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1104 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1104/)
        HDFS-3040. TestMulitipleNNDataBlockScanner is misspelled. Contributed by Madhukara Phatak. (Revision 1347891)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347891
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMulitipleNNDataBlockScanner.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMultipleNNDataBlockScanner.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1104 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1104/ ) HDFS-3040 . TestMulitipleNNDataBlockScanner is misspelled. Contributed by Madhukara Phatak. (Revision 1347891) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347891 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMulitipleNNDataBlockScanner.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMultipleNNDataBlockScanner.java
        Hide
        Eli Collins added a comment -

        I've merged this to branch-2.

        Show
        Eli Collins added a comment - I've merged this to branch-2.
        Eli Collins made changes -
        Fix Version/s 2.2.0-alpha [ 12322472 ]
        Fix Version/s 3.0.0 [ 12320356 ]
        Target Version/s 3.0.0 [ 12320356 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        1d 12h 15m 1 Aaron T. Myers 15/May/12 21:15
        Open Open Patch Available Patch Available
        75d 22h 2m 2 madhukara phatak 18/May/12 11:47
        Patch Available Patch Available Resolved Resolved
        20d 19h 51m 1 Aaron T. Myers 08/Jun/12 07:39
        Resolved Resolved Closed Closed
        125d 11h 6m 1 Arun C Murthy 11/Oct/12 18:46

          People

          • Assignee:
            madhukara phatak
            Reporter:
            Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development