Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-2956

calling fetchdt without a --renewer argument throws NPE

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha, 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, then it will throw a NullPointerException:

      Exception in thread "main" java.lang.NullPointerException
      at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830)

      this is because getDelegationToken is being called with a null renewer

      1. HDFS-2956.patch
        4 kB
        Vinayakumar B
      2. HDFS-2956-01.patch
        0.9 kB
        Vinayakumar B
      3. HDFS-2956-02.patch
        4 kB
        Vinayakumar B
      4. HDFS-2956.03.patch
        4 kB
        Vinayakumar B
      5. HDFS-2956.branch-2.03.patch
        4 kB
        Vinayakumar B
      6. HDFS-2956-04.patch
        4 kB
        Vinayakumar B

        Activity

        Hide
        daryn Daryn Sharp added a comment -

        It's supposed to be acceptable to pass a null renewer. Since the renewer is a Text, the typical problem is code leaving off a null check before calling renewer.toString().

        Show
        daryn Daryn Sharp added a comment - It's supposed to be acceptable to pass a null renewer. Since the renewer is a Text , the typical problem is code leaving off a null check before calling renewer.toString() .
        Hide
        daryn Daryn Sharp added a comment -

        If someone doesn't take this, I'll get to it in the next few days since I'm already touching tokens.

        Show
        daryn Daryn Sharp added a comment - If someone doesn't take this, I'll get to it in the next few days since I'm already touching tokens.
        Hide
        atm Aaron T. Myers added a comment -

        Hey Daryn, any update here? I just bumped into this myself.

        Show
        atm Aaron T. Myers added a comment - Hey Daryn, any update here? I just bumped into this myself.
        Hide
        daryn Daryn Sharp added a comment -

        I'll look into it. It's probably a 1-line fix.

        Show
        daryn Daryn Sharp added a comment - I'll look into it. It's probably a 1-line fix.
        Hide
        daryn Daryn Sharp added a comment -

        It's potentially more than a 1-liner. The NN used to generate (apparently by design) a non-renewable token if the renewer is null. The PB stuff broke the ability to pass a null renewer. OTOH, the hftp servlet defaults the renewer to the client's UGI when passed a null renewer.

        The quick and dirty answer is for the token fetcher to default the renewer to UGI's login user unless the renewer flag is explicitly provided. This breaks the ability to request a non-renewable hdfs token, but as mentioned earlier, PB broke that anyway.

        Or should the PB code be fixed to allow a null renewer once again, and perhaps for consistency change hftp to not default a null renewer to the client's UGI?

        Show
        daryn Daryn Sharp added a comment - It's potentially more than a 1-liner. The NN used to generate (apparently by design) a non-renewable token if the renewer is null. The PB stuff broke the ability to pass a null renewer. OTOH, the hftp servlet defaults the renewer to the client's UGI when passed a null renewer. The quick and dirty answer is for the token fetcher to default the renewer to UGI's login user unless the renewer flag is explicitly provided. This breaks the ability to request a non-renewable hdfs token, but as mentioned earlier, PB broke that anyway. Or should the PB code be fixed to allow a null renewer once again, and perhaps for consistency change hftp to not default a null renewer to the client's UGI?
        Hide
        tlipcon Todd Lipcon added a comment -

        Seems to me (without a ton of expertise in this area of the code) that we should treat it as a bug in the PB-ification and restore the previous behavior of non-renewable tokens.

        Show
        tlipcon Todd Lipcon added a comment - Seems to me (without a ton of expertise in this area of the code) that we should treat it as a bug in the PB-ification and restore the previous behavior of non-renewable tokens.
        Hide
        daryn Daryn Sharp added a comment -

        I am leaning towards fixing it to be like it was before, but wanted input before making the change. Does anyone else disagree?

        Show
        daryn Daryn Sharp added a comment - I am leaning towards fixing it to be like it was before, but wanted input before making the change. Does anyone else disagree?
        Hide
        atm Aaron T. Myers added a comment -

        I am leaning towards fixing it to be like it was befor

        +1

        Show
        atm Aaron T. Myers added a comment - I am leaning towards fixing it to be like it was befor +1
        Hide
        rajuvishnu Raju added a comment -

        Here we are defining the protocol message as

        message GetDelegationTokenRequestProto {
          required string renewer = 1;
        }
        

        based on some of the above comments I feel the renewer should be optional (since null can be passed I mean we are not providing renewer).

        Even with optional we will have the generated class with null check for renewer, so I guess we can have null check for renewer like

        if(renewer != null) {
            GetDelegationTokenRequestProto req = GetDelegationTokenRequestProto
                .newBuilder()
                .setRenewer(renewer.toString())
                .build();
            } else {
              GetDelegationTokenRequestProto req = GetDelegationTokenRequestProto
              .newBuilder()
              .build();
            }    
        

        This should be possible since we are declaring the renewer optional, similarly we can parse the message back at serverside translator.

        Please correct me if I am wrong

        Show
        rajuvishnu Raju added a comment - Here we are defining the protocol message as message GetDelegationTokenRequestProto { required string renewer = 1; } based on some of the above comments I feel the renewer should be optional (since null can be passed I mean we are not providing renewer). Even with optional we will have the generated class with null check for renewer, so I guess we can have null check for renewer like if (renewer != null ) { GetDelegationTokenRequestProto req = GetDelegationTokenRequestProto .newBuilder() .setRenewer(renewer.toString()) .build(); } else { GetDelegationTokenRequestProto req = GetDelegationTokenRequestProto .newBuilder() .build(); } This should be possible since we are declaring the renewer optional, similarly we can parse the message back at serverside translator. Please correct me if I am wrong
        Hide
        atm Aaron T. Myers added a comment -

        Hey Daryn, any update on this?

        Show
        atm Aaron T. Myers added a comment - Hey Daryn, any update on this?
        Hide
        daryn Daryn Sharp added a comment -

        Unfortunately I've been too consumed with other token work to double back to this jira... I can spare time to review if you want to take a stab at a patch.

        Show
        daryn Daryn Sharp added a comment - Unfortunately I've been too consumed with other token work to double back to this jira... I can spare time to review if you want to take a stab at a patch.
        Hide
        atm Aaron T. Myers added a comment -

        Thanks for the update, Daryn. Unassigning from you.

        Show
        atm Aaron T. Myers added a comment - Thanks for the update, Daryn. Unassigning from you.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Attaching the patch, Please review

        Made the renewer optional as per above comments.

        Show
        vinayrpet Vinayakumar B added a comment - Attaching the patch, Please review Made the renewer optional as per above comments.
        Hide
        daryn Daryn Sharp added a comment -

        I'm not a protobuf expert, but I think downgrading a required field to optional is ok for compatibility but someone else should definitively comment.

        Only nit is the condition renewer.toString() != null) is unnecessary because it will never return null.

        Show
        daryn Daryn Sharp added a comment - I'm not a protobuf expert, but I think downgrading a required field to optional is ok for compatibility but someone else should definitively comment. Only nit is the condition renewer.toString() != null) is unnecessary because it will never return null.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Hi Aaron T. Myers, could you please take a look at the patch as you already aware of the issue..?
        Thanks

        Show
        vinayrpet Vinayakumar B added a comment - Hi Aaron T. Myers , could you please take a look at the patch as you already aware of the issue..? Thanks
        Hide
        atm Aaron T. Myers added a comment -

        You actually can't safely downgrade a PB field from required to optional in a compatible fashion. If you did so, the side trying to deserialize a message that still has the field marked "required" will consider a message missing this field to be a malformed message. See the section on this page entitled "Required is Forever."

        Show
        atm Aaron T. Myers added a comment - You actually can't safely downgrade a PB field from required to optional in a compatible fashion. If you did so, the side trying to deserialize a message that still has the field marked "required" will consider a message missing this field to be a malformed message. See the section on this page entitled "Required is Forever."
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12600339/HDFS-2956.patch
        against trunk revision 47f7f18.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
        org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
        org.apache.hadoop.hdfs.TestAppendSnapshotTruncate

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9811//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9811//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12600339/HDFS-2956.patch against trunk revision 47f7f18. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager org.apache.hadoop.hdfs.TestAppendSnapshotTruncate Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9811//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9811//console This message is automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Attaching a patch.
        Passing a empty renewer string if renewer not passed.

        Show
        vinayrpet Vinayakumar B added a comment - Attaching a patch. Passing a empty renewer string if renewer not passed.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 17m 50s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 29s There were no new javac warning messages.
        +1 javadoc 9m 39s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 12s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 14s Pre-build of native portion
        -1 hdfs tests 160m 22s Tests failed in hadoop-hdfs.
            206m 32s  



        Reason Tests
        Failed unit tests hadoop.hdfs.web.TestWebHdfsFileSystemContract
          hadoop.hdfs.TestHDFSFileSystemContract



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12742491/HDFS-2956-01.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / c815344
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11528/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11528/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11528/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11528/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 50s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 12s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 14s Pre-build of native portion -1 hdfs tests 160m 22s Tests failed in hadoop-hdfs.     206m 32s   Reason Tests Failed unit tests hadoop.hdfs.web.TestWebHdfsFileSystemContract   hadoop.hdfs.TestHDFSFileSystemContract Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742491/HDFS-2956-01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / c815344 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11528/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11528/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11528/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11528/console This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Test failures are unrelated to current patch. Those are related to HADOOP-12009.

        Show
        vinayrpet Vinayakumar B added a comment - Test failures are unrelated to current patch. Those are related to HADOOP-12009 .
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Hi Vinayakumar B, thank you for taking this issue. My concern is, when passing empty string renewer to a request, the request will fail under any condition. If the concern is true, it's better to fail fast by checking if --renewer argument exists in DelegationTokenFetcher#main.

        Show
        ajisakaa Akira Ajisaka added a comment - Hi Vinayakumar B , thank you for taking this issue. My concern is, when passing empty string renewer to a request, the request will fail under any condition. If the concern is true, it's better to fail fast by checking if --renewer argument exists in DelegationTokenFetcher#main .
        Hide
        vinayrpet Vinayakumar B added a comment -

        IMO, Without renewer, non-renewable delegationToken should be able to fetch, But renew should fail.

        Attached a test also to verify the same.

        Show
        vinayrpet Vinayakumar B added a comment - IMO, Without renewer, non-renewable delegationToken should be able to fetch, But renew should fail. Attached a test also to verify the same.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12744434/HDFS-2956-02.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 63d0365
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11644/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744434/HDFS-2956-02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 63d0365 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11644/console This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Last patch was generated from branch-2.

        Now attaching the patch for trunk.

        Show
        vinayrpet Vinayakumar B added a comment - Last patch was generated from branch-2. Now attaching the patch for trunk.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Vinayakumar B for the clarification and creating the regression test. +1 pending Jenkins.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Vinayakumar B for the clarification and creating the regression test. +1 pending Jenkins.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Attaching the branch-2 patch.
        Since DelegationTokenFetcher differs b/w trunk and branch-2, test also needs update in branch-2.
        cherry-pick will not work.

        Show
        vinayrpet Vinayakumar B added a comment - Attaching the branch-2 patch. Since DelegationTokenFetcher differs b/w trunk and branch-2, test also needs update in branch-2. cherry-pick will not work.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 15m 14s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 35s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 32s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        -1 findbugs 2m 36s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
        +1 native 3m 3s Pre-build of native portion
        -1 hdfs tests 161m 49s Tests failed in hadoop-hdfs.
            202m 59s  



        Reason Tests
        FindBugs module:hadoop-hdfs
        Failed unit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.TestAppendSnapshotTruncate



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12744441/HDFS-2956.03.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 63d0365
        Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11645/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11645/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11645/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11645/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 14s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 35s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 32s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. -1 findbugs 2m 36s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 native 3m 3s Pre-build of native portion -1 hdfs tests 161m 49s Tests failed in hadoop-hdfs.     202m 59s   Reason Tests FindBugs module:hadoop-hdfs Failed unit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.TestAppendSnapshotTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744441/HDFS-2956.03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 63d0365 Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11645/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11645/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11645/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11645/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 15m 30s Findbugs (version ) appears to be broken on branch-2.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 6m 2s There were no new javac warning messages.
        +1 javadoc 9m 39s There were no new javadoc warning messages.
        +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 5s The applied patch generated 40 new checkstyle issues (total was 0, now 40).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 11s mvn install still works.
        +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
        -1 findbugs 2m 35s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
        +1 native 1m 22s Pre-build of native portion
        +1 hdfs tests 155m 58s Tests passed in hadoop-hdfs.
            194m 19s  



        Reason Tests
        FindBugs module:hadoop-hdfs



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12744457/HDFS-2956.branch-2.03.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision branch-2 / d17a7bb
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11647/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11647/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11647/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11647/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11647/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 30s Findbugs (version ) appears to be broken on branch-2. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 6m 2s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 5s The applied patch generated 40 new checkstyle issues (total was 0, now 40). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 11s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. -1 findbugs 2m 35s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 native 1m 22s Pre-build of native portion +1 hdfs tests 155m 58s Tests passed in hadoop-hdfs.     194m 19s   Reason Tests FindBugs module:hadoop-hdfs Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744457/HDFS-2956.branch-2.03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision branch-2 / d17a7bb checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11647/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11647/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11647/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11647/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11647/console This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Findbugs is not actually there.
        trunk test failures are not related.
        branch-2 checkstyles are also not related.

        Show
        vinayrpet Vinayakumar B added a comment - Findbugs is not actually there. trunk test failures are not related. branch-2 checkstyles are also not related.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Akira Ajisaka, Thanks for the reviews.

        Could you also take a look at the branch-2 patch? This is different in test.

        Show
        vinayrpet Vinayakumar B added a comment - Akira Ajisaka , Thanks for the reviews. Could you also take a look at the branch-2 patch? This is different in test.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Findbugs is not actually there.

        Not related to the patch. Filed HDFS-8749.

        Show
        ajisakaa Akira Ajisaka added a comment - Findbugs is not actually there. Not related to the patch. Filed HDFS-8749 .
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Vinayakumar B for creating the patch for branch-2. Mostly looks good to me. I noticed there is a difference in the test between trunk and branch-2.

        branch-2
              // make sure we got back exactly the 1 token we expected
              assertTrue(itr.hasNext());
              assertNotNull("Token without renewer shouldn't be null", itr.next());
              assertTrue(!itr.hasNext());
        
        trunk
             assertTrue("token not exist error", itr.hasNext());
             assertNotNull("Token should be there without renewer", itr.next());
        

        I'm thinking we can add assertTrue(!itr.hasNext()) to the trunk as well.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Vinayakumar B for creating the patch for branch-2. Mostly looks good to me. I noticed there is a difference in the test between trunk and branch-2. branch-2 // make sure we got back exactly the 1 token we expected assertTrue(itr.hasNext()); assertNotNull( "Token without renewer shouldn't be null " , itr.next()); assertTrue(!itr.hasNext()); trunk assertTrue( "token not exist error" , itr.hasNext()); assertNotNull( "Token should be there without renewer" , itr.next()); I'm thinking we can add assertTrue(!itr.hasNext()) to the trunk as well.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Updated the trunk patch as per comments

        Show
        vinayrpet Vinayakumar B added a comment - Updated the trunk patch as per comments
        Hide
        vinayrpet Vinayakumar B added a comment -

        Attached the patch with correct name now.

        Show
        vinayrpet Vinayakumar B added a comment - Attached the patch with correct name now.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 16m 31s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 14s There were no new javac warning messages.
        +1 javadoc 10m 11s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 43s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        -1 findbugs 2m 42s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
        +1 native 3m 14s Pre-build of native portion
        -1 hdfs tests 160m 20s Tests failed in hadoop-hdfs.
            204m 28s  



        Reason Tests
        FindBugs module:hadoop-hdfs
        Failed unit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12744645/HDFS-8578-03.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 5214876
        Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11654/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11654/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11654/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11654/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 31s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 14s There were no new javac warning messages. +1 javadoc 10m 11s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 43s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. -1 findbugs 2m 42s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 native 3m 14s Pre-build of native portion -1 hdfs tests 160m 20s Tests failed in hadoop-hdfs.     204m 28s   Reason Tests FindBugs module:hadoop-hdfs Failed unit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744645/HDFS-8578-03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 5214876 Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11654/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11654/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11654/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11654/console This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        test failure unrelated

        Show
        vinayrpet Vinayakumar B added a comment - test failure unrelated
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1

        Show
        ajisakaa Akira Ajisaka added a comment - +1
        Hide
        vinayrpet Vinayakumar B added a comment -

        Thanks for the reviews Akira Ajisaka, I will commit the patch soon.

        Show
        vinayrpet Vinayakumar B added a comment - Thanks for the reviews Akira Ajisaka , I will commit the patch soon.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 15m 35s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 48s There were no new javac warning messages.
        +1 javadoc 9m 46s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 34s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 31s mvn install still works.
        +1 eclipse:eclipse 0m 44s The patch built with eclipse:eclipse.
        +1 findbugs 2m 35s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 9s Pre-build of native portion
        -1 hdfs tests 160m 52s Tests failed in hadoop-hdfs.
            203m 0s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestEncryptionZonesWithKMS
          hadoop.hdfs.TestLeaseRecovery2



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12744653/HDFS-2956-04.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / d66302e
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11656/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11656/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11656/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 35s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 48s There were no new javac warning messages. +1 javadoc 9m 46s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 34s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 44s The patch built with eclipse:eclipse. +1 findbugs 2m 35s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 9s Pre-build of native portion -1 hdfs tests 160m 52s Tests failed in hadoop-hdfs.     203m 0s   Reason Tests Failed unit tests hadoop.hdfs.TestEncryptionZonesWithKMS   hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744653/HDFS-2956-04.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d66302e hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11656/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11656/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11656/console This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Committed to trunk and branch-2.
        Thanks Akira Ajisaka for the final reviews.
        Thanks Aaron T. Myers, Daryn Sharp, Todd Lipcon for earlier discussions and reviews.

        Show
        vinayrpet Vinayakumar B added a comment - Committed to trunk and branch-2. Thanks Akira Ajisaka for the final reviews. Thanks Aaron T. Myers , Daryn Sharp , Todd Lipcon for earlier discussions and reviews.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #252 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/252/)
        HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B)HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #252 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/252/ ) HDFS-2956 . calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) HDFS-2956 . calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #982 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/982/)
        HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B)HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #982 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/982/ ) HDFS-2956 . calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) HDFS-2956 . calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8147 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8147/)
        HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B)HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8147 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8147/ ) HDFS-2956 . calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) HDFS-2956 . calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2179 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2179/)
        HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B)HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2179 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2179/ ) HDFS-2956 . calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) HDFS-2956 . calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2198 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2198/)
        HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B)HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2198 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2198/ ) HDFS-2956 . calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) HDFS-2956 . calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #240 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/240/)
        HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B)HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #240 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/240/ ) HDFS-2956 . calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) HDFS-2956 . calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #250 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/250/)
        HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B)HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #250 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/250/ ) HDFS-2956 . calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) HDFS-2956 . calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java

          People

          • Assignee:
            vinayrpet Vinayakumar B
            Reporter:
            tlipcon Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            13 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development